117714 - digital signature preferences won't stick

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Patrick]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.7+)
Gecko/20020101
BuildID:    2002010103

A while ago we had a bug that MESSAGE COPIES wouldn't stick for IMAP accounts.
Now i have the same problems with digital signatures (S/MIME). Steps are listed
below

Reproducible: Always
Steps to Reproduce:
1.get a digital signature (mine is from Thawte.com)
2.request and install one under Mozilla
3.verify if it is there (PREFERENCES - PRIVACY - CERTIFICATES - MANAGE
CERTIFICATES - tab YOUR CERTIFICATES)
4.In mozilla mail : EDIT - MAIL & NEWSGROUP ACCOUNT SETTINGS - expand your
(IMAP) mail account, go to SECURITY - check the box, and select the certificate
to use - click OK
5.repeat step 4, and you'll notice that the box is unchecked again

Actual Results:  mozilla unchecked the boz
Expected Results:  that it would remain checked

Comment 1

[Jesse Houwing]

I've also seen this happen for POP and NEWS, so it's all horked :(

See my bug 118405

Comment 2

[John Unruh]

Confirming.

Comment 3

[John Unruh]

*** Bug 118405 has been marked as a duplicate of this bug. ***

Comment 4

[John Unruh]

*** Bug 118586 has been marked as a duplicate of this bug. ***

Comment 5

[racham]

I will take care of this today. Thanks for filing the bug.

Comment 6

[Stephane Saux]

Attachment: proposed patch.

Comment 7

[Stephane Saux]

racham: I don't have cvs write access. If you agree to the patch, you can take
it from there.

Comment 8

[racham]

Sure. Thanks for your patch. I have looked at the patch. It seemed to have done
things to enable and disable depending on the cert availability, which certainly
seemed to be missing today. Anyway, I will apply your patch and will go on from
there. Thanks again.

Comment 9

[racham]

Stephane, 
Never mind. Your patch looks right. I will just polish it little bit and land
it. thanks.

Comment 10

[Stephane Saux]

*** Bug 116622 has been marked as a duplicate of this bug. ***

Comment 11

[Stephane Saux]

This really prevents users from configuring s/mime. Can we get it in?

Comment 12

[racham]

Attachment: patch, v1.1 - updated patch with proper identity pref retrieval mechanism

I had to fix couple of other places (besides the patch Stephane posted) to come
up with a complete patch. Pref reflection via Identity interface is the right
way of doing this. I have tested this latest updated patch on accounts
with/without certificates. It works fine.

Comment 13

[Scott MacGregor]

Comment on attachment 64081 [details] [diff] [review]
patch, v1.1 - updated patch with proper identity pref retrieval mechanism

ack please don't check this in Bhuvan. All of the smime attributes are generic
attributes on the identity. They are all stored generically via a mechanism
Seth and I wrote. You just bypassed all of that and put back raw security
properties in the identity =). 

I'll take a look at this bug but right now setting smime properties via the
account manager stick just fine for me. I'm not sure if there's a specific
scenario where they aren't.

Comment 14

[racham]

Attachment: patch, v1.2 - Fresh patch, reworked keeping smime generic pref saving mechanism (as mentioned by Scott) intact

Please ignore the patch 64081. Sorry about that mess.

Here is another attempy. Posting a new patch.

In order to reproduce the problem, 

1. Create a new account inside a profile that has a ccsee to certs. 
2. Click on Security item under that account in AccountManager window. 
3. If you are running a debug build, you should see the following js error on
console
JavaScript error:
chrome://messenger/content/am-smime.js line 61: gEncryptAlways is not defined
4. Notice that all the fields on the panel are enabled. None of items could be
saved as prefs.
5. Fixed the error in step 4, by defining gEncryptAlways.
6. Now, make changes to items on Security panel. Click on some other account 
items like Addressing or Server Settings. Click back on Security. Notice that
all the changes made are gone.
7. We need to save those values as prefs as user leaves the panel. The new
patch achieves that.

Note : In step 6, if you do not switch panels and click on OK to close the
AccountManager window, changes made are saved properly.

Please do let me know if there are issues with this patch. thanks.

Comment 15

[Antonio Lam]

*** Bug 118045 has been marked as a duplicate of this bug. ***

Comment 16

[Antonio Lam]

In step 6, Even I did not switch panels and click OK to close the AccountManager 
window, the change in the security pane still NOT saved properly when I open the 
AccountManager window again...

I used 2002010810 trunk build.

Does anyone know any workaround for this bug? (like changing the prefs.js file)

Comment 17

[Scott MacGregor]

Comment on attachment 64106 [details] [diff] [review]
patch, v1.2 - Fresh patch, reworked keeping smime generic pref saving mechanism (as mentioned by Scott) intact

sr=mscott

Comment 18

[(not reading, please use [e-mail] instead)]

Comment on attachment 64106 [details] [diff] [review]
patch, v1.2 - Fresh patch, reworked keeping smime generic pref saving mechanism (as mentioned by Scott) intact

r=sspitzer

Comment 19

[racham]

Fix landed. Thanks to Stephane, Scott & Seth.

Marking fixed.

Comment 20

[Antonio Lam]

Verified fixed with 2002011103 build.

1. Change the security mail options in the Mail Account Setting (check/uncheck 
checkbox, selecting sign/encrypt cert), switch to other panel, back to security 
setting, the previous changes are preserved.

2. Change the security mail options in the Mail Account Setting (check/uncheck 
checkbox, selecting sign/encrypt cert), without switching to other panel, click 
OK to save and exit the Mail Account Setting. Verified the previous changes are 
saved when open the Mail Account Setting again.

Comment 21

[Blu3]

Yes, it is fixed however you cannot select the encrypt if possible option.  It
is  grayed out.

David

Comment 22

[Jesse Houwing]

But still.... taht isn't a fix is it? It should save them regardless of if you
switch to other tabs.

Comment 23

[Antonio Lam]

There is already a separate bug regarding unable to select encrypt if possible 
option. Please see bug 117763 for details.

Comment 24

[racham]

*** Bug 119558 has been marked as a duplicate of this bug. ***