1178045 - Fix the magnifier/icon situation for keywords in awesomebar results

Status: RESOLVED DUPLICATE of bug 1512660

(Firefox :: Address Bar, defect, P3)

Description

[Marco Bonardo [:mak]]

Attachment: Schermata 2015-06-27 alle 16.23.54.png

On keywords we append the magnifier icon and have no favicon, likely we should just put the magnifier before the keyword host, like we do for any other kind of search, mostly for coherence.

STR:
1. Add a keyword
2. type keyword search_terms
3. note the magnifier is appended

Comment 1

[Elbart]

Will bookmarks get their proper favicon back, when they have a keyword/shortcut without %s? Showing the search-magnifier-lens doesn't make much sense in this context.

Comment 2

[Marco Bonardo [:mak]]

(In reply to Elbart from comment #1)
> Will bookmarks get their proper favicon back, when they have a
> keyword/shortcut without %s? Showing the search-magnifier-lens doesn't make
> much sense in this context.

aliasing uris is not keywords intended scope, they are shortcut to searches, so likely not.

Comment 3

[:shell escalante]

hi drew - this sounds like what you said you just landed (moving icon to left).  Is it?

Comment 4

[Drew Willcoxon :adw]

Hi Shell, the bug I landed (bug 1162142) was about adding the magnifying glass inside the awesomebar, in the textbox where you type, not in the results in the popup, so this isn't related.  This is a fairly longstanding bug I think.

Comment 5

[Marco Bonardo [:mak]]

(In reply to Drew Willcoxon :adw from comment #4)
> This is a fairly longstanding bug I think.

Well, not exactly longstanding. this is a bug from when we put an icon on the left of search suggestions, and now the keywords entry look "exotic".

Comment 6

[Stephen Horlander [:shorlander]]

(In reply to Marco Bonardo [::mak] from comment #0)
> Created attachment 8626944 [details]
> Schermata 2015-06-27 alle 16.23.54.png
> 
> On keywords we append the magnifier icon and have no favicon, likely we
> should just put the magnifier before the keyword host, like we do for any
> other kind of search, mostly for coherence.
> 
> STR:
> 1. Add a keyword
> 2. type keyword search_terms
> 3. note the magnifier is appended

Yes. Makes this interaction a lot clearer.

Comment 7

[Marco Bonardo [:mak]]

not blocking the release of unified complete.

Comment 8

[Marco Bonardo [:mak]]

With the new styling the magnifier is before the keyword, as expected...

Though now we show both the magnifier and a default favicon.
We should either:

1. only show the magnifier: could make sense since we plan to unify keywords and search engines UI (bug 648398)

2. try to guess a favicon for keywords as domain/favicon.ico

Comment 9

[Marco Bonardo [:mak]]

note that currently search engines aliases show the engine icon and no magnifier icon.