1178639 - nsOuterWindowProxy::getOwnPropertyDescriptor should always claim the property is configurable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

Because it can go away on navigation.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: WindowProxy should claim almost all its properties as configurable

The only exceptions are the spec properties which are readonly non-configurable
and have values that are primitives, so don't observably change on navigation.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 9025405 [details] [diff] [review]
WindowProxy should claim almost all its properties as configurable

Per https://github.com/tc39/ecma262/pull/688#issuecomment-439164998 this is not going to work...

Comment 3

[Mark S. Miller]

See https://github.com/tc39/ecma262/pull/688#issuecomment-439224017

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: WindowProxy should generally claim that properties on it are configurable

The one exception are properties that are:

1) Defined in the ES spec.
2) Non-configurable.
3) Readonly.
4) Have values that don't observable change on navigation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c8ad4d5dbe9
WindowProxy should generally claim that properties on it are configurable.  r=peterv

Comment 6

[Arthur Iakab [arthur_iakab]]

Backed out 2 changesets (bug 1329324, bug 1178639) for failing wpt tests on window-properties.https.htm

Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/db5251bae3d4e09b0cadab5378005fa402841f39

Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=214196389&revision=8c8ad4d5dbe94b90b340acd449fac1516b563a07

Failure logs:
https://treeherder.mozilla.org/logviewer.html#?job_id=214196389&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=214198472&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=214198905&repo=mozilla-inbound

:bzbarsky Could you please take a look at this issue?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Oh, right, the tests are wrong in the new world...  I thought I'd included the relevant annotations.  :(

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95651672782a
WindowProxy should generally claim that properties on it are configurable.  r=peterv

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/95651672782a