Closed Bug 1329324 Opened 3 years ago Closed Last year

nsOuterWindowProxy should allow Object.defineProperty to return false

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox53 --- affected
firefox65 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 3 open bugs)

Details

(Keywords: dev-doc-needed)

User Story

Sites that need retesting to make sure this fix doesn't (re)break them:

* https://www.structube.com/en/emerson-desk-59-50-37-10 (see <https://github.com/webcompat/web-bugs/issues/4272>)
* http://hildr.luminance.org/SampleFNA/ (see bug 1197958)
* https://shop.cyberlink.com/c/shop?curr=EUR&cntr=&ml=EN&LOCALE=en_EU&OFFER_ID=6112WA033101&AFFILIATE_ID=2581_-1_37_CJaffiliate_SID-617e8c1ffb8145a88908cf5f85919deb&AM=1&ID=P11028558 (see bug 1261572)
* starbucks.com (see bug 1326392)

Attachments

(1 file, 2 obsolete files)

We should replace the code we're ripping out in bug 1329323 with something based on bug 1329321.
When this happens, we should retest the bugs this blocks...
Priority: -- → P3
User Story: (updated)
See https://bugzilla.mozilla.org/show_bug.cgi?id=1329321#c15 for some useful explanations when documenting this.
Depends on: 1496475
Attached patch Work in progress (obsolete) — Splinter Review
This is mostly what we want here, but there are some open questions around behavior in https://github.com/tc39/ecma262/pull/688#issuecomment-427417248
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #9014837 - Attachment is obsolete: true
Attachment #9025404 - Attachment is obsolete: true
Attachment #9025404 - Flags: review?(peterv)
Comment on attachment 9025731 [details] [diff] [review]
When trying to define non-configurable properties on a WindowProxy, communicate back that we didn't "really" define them as non-configurable

Review of attachment 9025731 [details] [diff] [review]:
-----------------------------------------------------------------

This depends on the patch in bug 1496475, right?
Attachment #9025731 - Flags: review?(peterv) → review+
> This depends on the patch in bug 1496475, right?

That's correct.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/052522c1bc3b
When trying to define non-configurable properties on a WindowProxy, communicate back that we didn't "really" define them as non-configurable.  r=peterv
Backout by aiakab@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db5251bae3d4
Backed out 2 changesets (bug 1329324, bug 1178639) for failing wpt tests on window-properties.https.html
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9dac00a9eef
When trying to define non-configurable properties on a WindowProxy, communicate back that we didn't "really" define them as non-configurable.  r=peterv
Flags: needinfo?(bzbarsky)
Issue was with the patch from bug 1178639: the tests don't expect that behavior yet.  They need to get fixed.  Filed bug 1510437 on that.
https://hg.mozilla.org/mozilla-central/rev/a9dac00a9eef
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
(The site-compat keyword is in Bug 1496510)
Keywords: site-compat
Note to MDN team:

I've added a note to the Fx65 rel notes to cover this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#JavaScript

It will need documenting on the ref pages too.

(and yes, I know the {{bug}} macro is broken; I've just reported to the MDN dev team.)
Chris, this is nightly-only for now while we check for web compat.  It's not shipping in Firefox 65, and won't until bug 1496510 is fixed.
Flags: needinfo?(cmills)
(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #16)
> Chris, this is nightly-only for now while we check for web compat.  It's not
> shipping in Firefox 65, and won't until bug 1496510 is fixed.

Ah, OK - thank for the heads-up Boris! I've removed the note.
Flags: needinfo?(cmills)
Depends on: 1521677
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.