1329324 - nsOuterWindowProxy should allow Object.defineProperty to return false

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

We should replace the code we're ripping out in bug 1329323 with something based on bug 1329321.

Comment 1

[Boris Zbarsky [:bzbarsky]]

When this happens, we should retest the bugs this blocks...

Comment 2

[Florian Scholz (Open Web Docs)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1329321#c15 for some useful explanations when documenting this.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Work in progress

This is mostly what we want here, but there are some open questions around behavior in https://github.com/tc39/ecma262/pull/688#issuecomment-427417248

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: When trying to define non-configurable properties on a WindowProxy, communicate back that we didn't "really" define them as non-configurable

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: When trying to define non-configurable properties on a WindowProxy, communicate back that we didn't "really" define them as non-configurable

Comment 6

[Peter Van der Beken [:peterv]]

Comment on attachment 9025731 [details] [diff] [review]
When trying to define non-configurable properties on a WindowProxy, communicate back that we didn't "really" define them as non-configurable

Review of attachment 9025731 [details] [diff] [review]:
-----------------------------------------------------------------

This depends on the patch in bug 1496475, right?

Comment 7

[Boris Zbarsky [:bzbarsky]]

> This depends on the patch in bug 1496475, right?

That's correct.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/052522c1bc3b
When trying to define non-configurable properties on a WindowProxy, communicate back that we didn't "really" define them as non-configurable.  r=peterv

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db5251bae3d4
Backed out 2 changesets (bug 1329324, bug 1178639) for failing wpt tests on window-properties.https.html

Comment 10

[Arthur Iakab [arthur_iakab]]

Backed out 2 changesets (bug 1329324, bug 1178639) for failing wpt tests on window-properties.https.htm

Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/db5251bae3d4e09b0cadab5378005fa402841f39

Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=214196389&revision=8c8ad4d5dbe94b90b340acd449fac1516b563a07

Failure logs:
https://treeherder.mozilla.org/logviewer.html#?job_id=214196389&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=214198472&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=214198905&repo=mozilla-inbound

:bzbarsky Could you please take a look at this issue?

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9dac00a9eef
When trying to define non-configurable properties on a WindowProxy, communicate back that we didn't "really" define them as non-configurable.  r=peterv

Comment 12

[Boris Zbarsky [:bzbarsky]]

Issue was with the patch from bug 1178639: the tests don't expect that behavior yet.  They need to get fixed.  Filed bug 1510437 on that.

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a9dac00a9eef

Comment 14

[Kohei Yoshino]

(The site-compat keyword is in Bug 1496510)

Comment 15

[Chris Mills [:cmills]]

Note to MDN team:

I've added a note to the Fx65 rel notes to cover this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#JavaScript

It will need documenting on the ref pages too.

(and yes, I know the {{bug}} macro is broken; I've just reported to the MDN dev team.)

Comment 16

[Boris Zbarsky [:bzbarsky]]

Chris, this is nightly-only for now while we check for web compat.  It's not shipping in Firefox 65, and won't until bug 1496510 is fixed.

Comment 17

[Chris Mills [:cmills]]

(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #16)
> Chris, this is nightly-only for now while we check for web compat.  It's not
> shipping in Firefox 65, and won't until bug 1496510 is fixed.

Ah, OK - thank for the heads-up Boris! I've removed the note.