Closed Bug 1329323 Opened 8 years ago Closed 8 years ago

Remove the "throw when defining a non-configurable property" bits in nsOuterWindowProxy, since they are not web-compatible

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webcompat])

Attachments

(1 file)

See bug 1178638 discussion.
Blocks: 1329324
Whiteboard: [webcompat]
Attachment #8824546 - Flags: review?(peterv) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb289d414cb2
Stop throwing on nightly/aurora when trying to define a non-configurable property on the window, since we've determined that this is not web-compatible.  r=peterv
https://hg.mozilla.org/mozilla-central/rev/fb289d414cb2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Just got a webcompat.com report from an aurora user running into this on structube.com. Can this be uplifted to 52 so we don't ship with such breakage?
This code was only ever enabled on nightly and aurora, not beta or release.  So there is no risk of shipping with any breakage.

I suppose we could consider uplifting to aurora just to reduce noise and problems for current Aurora users, but given that nightly moves to Aurora in a week anyway we'd win at most a few days.  Doesn't seem worth it.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: