1329323 - Remove the "throw when defining a non-configurable property" bits in nsOuterWindowProxy, since they are not web-compatible

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 1178638 discussion.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop throwing on nightly/aurora when trying to define a non-configurable property on the window, since we've determined that this is not web-compatible

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb289d414cb2
Stop throwing on nightly/aurora when trying to define a non-configurable property on the window, since we've determined that this is not web-compatible.  r=peterv

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fb289d414cb2

Comment 4

[Thomas Wisniewski]

Just got a webcompat.com report from an aurora user running into this on structube.com. Can this be uplifted to 52 so we don't ship with such breakage?

Comment 5

[Boris Zbarsky [:bzbarsky]]

This code was only ever enabled on nightly and aurora, not beta or release.  So there is no risk of shipping with any breakage.

I suppose we could consider uplifting to aurora just to reduce noise and problems for current Aurora users, but given that nightly moves to Aurora in a week anyway we'd win at most a few days.  Doesn't seem worth it.