1186996 - Update en-GB searchplugin icons for Gecko 41

Status: RESOLVED FIXED

(Mozilla Localizations :: en-GB / English (United Kingdom), defect)

Description

[Ian Neal]

Bug 1156917 updated the en-US icons for searchplugins, which means the Amazon and Yahoo searchplugin files for en-GB need updating in time for Gecko 41.

Comment 1

[Ian Neal]

Attachment: Update Mobile 41 en-GB searchplugins

This also ports the fixes for:
* Bug 762046 - Amazon search-plugin hard-coded for desktop site
* Bug 852714 - Add Mozilla's sourceid to Fennec's Amazon search URL
* Bug 891879 - Amazon search provider should be at www instead of m.amazon.com
* Bug 1089598 - Yahoo search code for the search activity widget
* Bug 1126511 - update Yahoo search plugins to use per-access point tags for better reporting/analysis

and changing from DOS to UNIX line endings on amazon file.

Not sure who needs to check that the amazon param tag is correct though.

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8638062 [details] [diff] [review]
Update Mobile 41 en-GB searchplugins

Review of attachment 8638062 [details] [diff] [review]:
-----------------------------------------------------------------

Please update only images (the ones you used are fine), not the rest of the searchplugins.
Adding the MPL license to Amazon is OK.

In particular, Yahoo for en-US has a completely different structure, given that's default for en-US, and must not be copied on other locales.

Comment 3

[Ian Neal]

Attachment: Update Mobile 41 en-GB icons for searchplugins [Checked in: Comment 5]

Just the icon changes plus for amazon file:
* adding the MPL license
* removing unneeded <Description> tag
* changing from DOS to UNIX line endings

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8638082 [details] [diff] [review]
Update Mobile 41 en-GB icons for searchplugins [Checked in: Comment 5]

Review of attachment 8638082 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks.

Comment 5

[Ian Neal]

Comment on attachment 8638082 [details] [diff] [review]
Update Mobile 41 en-GB icons for searchplugins [Checked in: Comment 5]

http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-GB/rev/e54eadd66891