1179851 - Filtered search: subsequent search queries are undefined.

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: Search, enhancement)

Description

[Stephanie Hobson [:shobson]]

I can only replicate this with the new search filters/suggestions enabled (https://developer.mozilla.org/en-US/?dwft_search_suggestions=1)


No matter why I type it searches for "undefined"

Steps to reproduce:
1) follow link above to get filtered search
2) pick a filter out of the list (I chose #beginner)
3) add some search text (I used "css")
4) hit enter to trigger search
5) on search results page click on a filter in the right column (I chose "APIs and DOM")
Problem: search results come back for "undefined"
Expected: search for "css" with "beginner" and "api and dom" filters 
6) type something else to search for (I chose "HTML")
7) hit enter to search
Problem: search results come back for "undefined"
Expected: search results for "HTML"

Comment 4

[Rob Hudson [:robhudson]]

I took a look at this today.

The "undefined" comes from a larger problem, which is that the search-suggestions.js was written mostly with the homepage in mind.

For example:
https://github.com/mozilla/kuma/blob/5167c6ebc611eb58352be1b774dcce742dd6f9a0/kuma/static/js/search-suggestions.js#L277-L295

This code sets up an on-submit handler for the search form. The `$searchInput` value is derived from '#home-q' which only exists on the home page. On the search results page this field is called '#search-q' which is why this is "undefined".

I think the larger issue here is the search results page is missing not only this, but also the search filters themselves when you starting typing a string with a "#" for a filter tag. Although I'm not sure if we need to support that or use the filters on the side of the page, but typing "#" opens a drop-down that is unpopulated.

Comment 5

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.