1181719 - Stagefright: CHECK_GT( mSize,0u) failed in ABitReader.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Tyson Smith [:tsmith]]

Attachment: test_case.mp4

A/        (20375): /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/media/libstagefright/frameworks/av/media/libstagefright/foundation/ABitReader.cpp:32 CHECK_GT( mSize,0u) failed: 0 vs. 0

Comment 1

[Chris Peterson [:cpeterson]]

Gerald, here's another Stagefright bug.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1181719-gtest.patch

Part 1: Added gtest case (without mdat).

The mdat is big and not useful in this test that only looks at metadata.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1181719-check-numBitsLeft-before-getBits.patch

Part 2: Check numBitsLeft() before each getBits().

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1181719-gtest.patch

Clarified check-in comment, no actual changes; carrying r+.

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Check-in in this order: bug 1181719, bug 1181223, bug 1181220, bug 1181215, bug 1181213
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=20e7b755a695

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2801114b2b72
https://hg.mozilla.org/integration/mozilla-inbound/rev/141a05a20042

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2801114b2b72
https://hg.mozilla.org/mozilla-central/rev/141a05a20042

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2801114b2b72
https://hg.mozilla.org/mozilla-central/rev/141a05a20042