1183512 - Add "advisor" to spellcheck dictionary

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Enter the word "advisor" or "Advisor" into a text field in Firefox.
   (e.g. a comment form on this bug page, or https://pastebin.mozilla.org/ )

ACTUAL RESULTS:
Squiggly red underline, indicating that we think it's misspelled. "Adviser" (with an "er" instead of "or") is suggested.

EXPECTED RESULTS:
No squiggly red underline.


Both "Adviser" and "Advisor" are accepted spellings, according to these resources:
 https://en.wikipedia.org/wiki/Adviser
 http://grammarist.com/spelling/adviser-advisor/
 http://www.oxforddictionaries.com/definition/english/adviser
 http://ninjawords.com/advisor

Comment 1

[Jorg K (CEST = GMT+2)]

This is not a Mozilla core bug. Please contact the person who maintains the
dictionary:
https://addons.mozilla.org/en-US/firefox/addon/united-states-english-spellche/
and
https://dxr.mozilla.org/comm-central/source/mozilla/extensions/spellcheck/locales/en-US/hunspell/README_en_US.txt
As far as I can tell, Mozilla does not maintain the content of the
dictionaries.

For the British dictionary contact the respective maintainer, there are
various:
https://addons.mozilla.org/en-US/firefox/addon/british-english-dictionary/
https://addons.mozilla.org/en-us/firefox/addon/british-english-dictionary-2/
(I can recommend the latter and the maintainer, Marco, is a really nice guy)

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Jorg K (GMT+1) from comment #1)
> This is not a Mozilla core bug.

Disagree. Reopening, per below.

> Please contact the person who maintains the
> dictionary:
> https://addons.mozilla.org/en-US/firefox/addon/united-states-english-spellche/

That is not the dictionary that's shipped with Firefox. That's an add-on.

> https://dxr.mozilla.org/comm-central/source/mozilla/extensions/spellcheck/locales/en-US/hunspell/README_en_US.txt

(That's the readme from upstream, yeah. I'm not sure that's relevant here. It would be relevant if we needed to upstream this change, but I'm not sure we need to.)

> As far as I can tell, Mozilla does not maintain the content of the
> dictionaries.

hg log of the directory you linked to (in mozilla-central, not comm-central) proves otherwise -- see changes here:
 https://hg.mozilla.org/mozilla-central/log/tip/extensions/spellcheck/locales/en-US/hunspell/en-US.dic

The dictionary comes from upstream, but we do take local changes as well (and track them).

Also, see the description of this component:
   ▾ Spelling checker
  For bugs with the spelling checker used by Mozilla-based applications.
  This includes [...] the en-US Hunspell dictionary


> For the British dictionary contact the respective maintainer

I'm not concerned with the British dictionary.

Comment 3

[Daniel Holbert [:dholbert]]

(Also, RE british dictionary -- this isn't a british-ism, like e.g. "colour".  The Wikipedia page linked in comment 0 says "advisor has gained frequency in recent years and is a common alternative, especially in North America.")

Comment 4

[Ekanan Ketunuti]

Attachment: MozReview Request: Bug 1183512 - Add advisor to the en-US dictionary. r?ehsan

Review commit: https://reviewboard.mozilla.org/r/29077/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29077/

Comment 5

[Jorg K (CEST = GMT+2)]

> hg log of the directory you linked to proves otherwise.
OK, my mistake. I didn't know that Ehsan spends time on every word added to the dictionary.

At the same time as closing this bug as invalid, I closed a few more:
Bug 301712  (from 2005) - complaining about the invalid word "Aurthur"
Bug 1198052 - complaining about the invalid word "unfeasible" instead of "infeasible"
Bug 1144254 - complaining about "naïve" (with diaeresis) missing.

Sorry about that, anyway, closing the bug got it some attention ;-)
You might want to deal with the other three bugs at the same time: Either do what is asked for or wontfix.

In the future I will send those bugs to Ekanan Ketunuti straight away.

I assume it was correct to close bugs regarding other dictionaries:
Bug 1229454 (German) and bug 1229406 (French Canadian?).

Comment 6

[Daniel Holbert [:dholbert]]

(In reply to Jorg K (GMT+1) from comment #5)
> > hg log of the directory you linked to proves otherwise.
> OK, my mistake. I didn't know that Ehsan spends time on every word added to
> the dictionary.

(Only on words that people notice are missing from the upstream dictionary [& get a patch written].  Very good of him, but I suspect it's not as time-consuming as your statement here suggests. :))
 
> At the same time as closing this bug as invalid, I closed a few more:

Thanks. Reopened all of those.

> In the future I will send those bugs to Ekanan Ketunuti straight away.

Cool, as long as he's up for having those sent his way! :)  (thanks Ekanan for taking this bug!)

> I assume it was correct to close bugs regarding other dictionaries:
> Bug 1229454 (German) and bug 1229406 (French Canadian?).

It probably would have been better to re-classify them as Mozilla Localizations :: [language].  I suspect that's where the locale-specific spellchecker dictionaries are tracked.  I'll go ahead and reopen them & make that reclassification now.  (Further comments about these bugs can go on these bugs.)

Comment 7

[Ekanan Ketunuti]

Comment on attachment 8702160 [details]
MozReview Request: Bug 1183512 - Add advisor to the en-US dictionary. r?ehsan

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29077/diff/1-2/

Comment 8

[Ekanan Ketunuti]

Attachment: MozReview Request: Bug 1198052 - Add infeasible, infeasibility, and unfeasibility to the en-US dictionary. r?ehsan

Review commit: https://reviewboard.mozilla.org/r/29079/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29079/

Comment 9

[Ekanan Ketunuti]

Attachment: MozReview Request: Bug 301712 - Remove Aurthur from the en-US dictionary. r?ehsan

Review commit: https://reviewboard.mozilla.org/r/29081/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29081/

Comment 10

[Ekanan Ketunuti]

Attachment: Add advisor to the en-US dictionary

Comment 11

[Jorg K (CEST = GMT+2)]

Sorry to be picky here, I just want to prove the point that this should be maintained elsewhere. It's already messy and I don't see why Mozilla needs another version of messy.

The proposed change is:
 adviser/M
+advisor/M
 advisory/SM

Comparing to en-US (https://addons.mozilla.org/en-US/firefox/addon/united-states-english-spellche/)
adviser/M
advisor/S
advisor's
advisory/S

and en-GB:
adviser/MS
advisor/MS
advisory/S

I hope I'm reading the affix file correctly. S gives us a plural "s", advisors, and M gives us the possessive "'s", the advisor's wife.

So I don't see why adding "advisor/M" is the right thing to do.

IMHO all three words, adviser, advisor and advisory should have /SM.

Comment 12

[Jorg K (CEST = GMT+2)]

Also see bug 1137544, comment #33.

Comment 13

[Jorg K (CEST = GMT+2)]

Let's fix all the issues in bug 1235506.

Comment 14

[Jorg K (CEST = GMT+2)]

This will be fixed automatically by bug 1238031.

Comment 15

[Jorg K (CEST = GMT+2)]

Fixed by bug 1238031.