1183851 - Changing orientation in editing mode updates URL bar to wrong state

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:
1) Click URL bar.
2) Enter some characters.
3) Rotate phone.

The lock/reader icons appear, and the entered text gets overridden with the page URL. We need to guard on being in editing mode for any URL updates we do.

We might also want to consider going back to a separate display URL view and an editing URL field like we had before since it simplified issues like these (at the cost of layout complexity).

Comment 1

[Mosbah]

Attachment: Pull request

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8634114 [details] [review]
Pull request

Thanks for the PR -- unfortunately, the fix will be a bit more complicated than this.

We still want to update the URL when we're not in editing mode, so we'll still need to update the display URL on rotation. It needs to be a conditional update: ignore if we're in editing mode, but proceed otherwise.

Also, we need similar checks for other parts of the URL bar, such as the lock icon and the reader mode icon.

Comment 3

[Brian Nicholson (:bnicholson)]

Actually, with bug 1182274 landed, we shouldn't need to update the display URL on rotation since the URL bar needs to respond only to the URL updated KVO event. We still need to handle the lock and reader icon as mentioned, though.

Comment 4

[Mosbah]

Would you please further explain what do you mean by "handle the lock and reader icon" ?
With my fix : 
if we are in editing mode : lock and reader icons hidden -> rotation -> icons stays hidden
if not in editing mode : lock and reader icons visible -> rotation -> icons visible
editing -> rotation -> go button : icons visible
I think that's normal behaviour no ?

Comment 5

[Brian Nicholson (:bnicholson)]

(In reply to Mosbah from comment #4)
Steps:
1) Go to google.com, see lock icon.
2) Tap the URL bar, no lock icon (correct behavior).
3) Rotate, lock icon appears (incorrect).

Comment 6

[Mosbah]

Attachment: Bug_1183851.gif : shows the behaviour after rotation

Comment 7

[Brian Nicholson (:bnicholson)]

Fixed by URL bar refactor (bug 1184239).