1192540 - In about:config, make accel+f focus the filter box again instead of invoking the find bar

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Steffen Wilberg]

+++ This bug was initially created as a clone of Bug #382690 +++

In about:config, accel+f should focus the filter box instead of invoking the find bar (which is useless). I fixed this 7 years ago in bug 382690.

This got regressed 4 years ago by bug 502492, which changed the label from "Filter:" to "Search:" and the commandkey from "f" to "r".

Comment 1

[Steffen Wilberg]

Attachment: patch

This just adds a second commandkey "f" (i.e. Ctrl/Cmd+f) in addition to the current Ctrl/Cmd+r.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8645367 [details] [diff] [review]
patch

Review of attachment 8645367 [details] [diff] [review]:
-----------------------------------------------------------------

I wouldn't block the bug on it but it would be good to get an automated test here to make sure we don't regress again.

Comment 3

[Steffen Wilberg]

Filed bug 1194975 for creating tests for about:config.

Comment 4

[Steffen Wilberg]

url:        https://hg.mozilla.org/integration/fx-team/rev/880bb943d65386d56dd84491f82af3f74b4ff8f4
changeset:  880bb943d65386d56dd84491f82af3f74b4ff8f4
user:       Steffen Wilberg <[e-mail]>
date:       Sat Aug 15 12:06:41 2015 +0200
description:
Bug 1192540: In about:config, make accel+f focus the filter box again instead of invoking the find bar. r=mossop

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/880bb943d653