Add tsz and cak locales to bouncer

RESOLVED FIXED

Status

Infrastructure & Operations
WebOps: Other
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: jlund, Assigned: cyliang)

Tracking

Details

(Whiteboard: [kanban:https://webops.kanbanize.com/ctrl_board/2/1774] )

(Reporter)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1129976 +++

apologies if this is not the right place to file

beta fennec builds are failing as these locales are not in https://bounceradmin.mozilla.com/api/product_add/

sledru: looks like you have some commit history in http://viewvc.svn.mozilla.org/vc/libs/product-details/ would you be able to help me or point me to someone who is familiar with this procedure. are there docs?
Flags: needinfo?(sledru)
(Reporter)

Updated

3 years ago
Blocks: 1188493
Jeff is usually the right guy for this :)
Flags: needinfo?(sledru) → needinfo?(jbeatty)
We've used other lang codes sans region codes before. Do we know that adding region codes would fix the problem? 

Additionally, I don't think these locales are ready to be ported up to Beta. It would be fine if we simply removed them from Fennec's all-locales on mozilla-beta until they became ready for it.
Flags: needinfo?(jbeatty)
Summary: Add regions for tsz and cak in bouncer locales → Add tsz and cak locales to bouncer
IIRC, bouncer syncs locales from http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class.php?view=markup. If someone adds those locales there, the issue should be resolved.
These locales are Fennec only and don't need to be added to the product-details library. They're not found in https://hg.mozilla.org/releases/mozilla-aurora/file/bef1e3e26eee/browser/locales/all-locales for desktop.
(Reporter)

Comment 6

3 years ago
(In reply to Jeff Beatty [:gueroJeff] from comment #5)
> These locales are Fennec only and don't need to be added to the
> product-details library. They're not found in
> https://hg.mozilla.org/releases/mozilla-aurora/file/bef1e3e26eee/browser/
> locales/all-locales for desktop.

but it seems like we expect them in bouncer for fennec.

automation error log snippet:
18:53:11     INFO - Downloading https://hg.mozilla.org/releases/mozilla-beta/raw-file/FENNEC_41_0b1_RELEASE/mobile/android/locales/all-locales to /builds/slave/rel-m-beta-bncr_sub-0000000000/build/shipped-locales

18:53:13     INFO - retry: Calling _api_call with args: ('product_add/', {'languages': ['ach', 'af', 'ak', 'ar', 'an', 'as', 'az', 'be', 'bn-IN', 'br', 'ca', 'cak', 'cs', 'cy', 'da', 'de', 'dsb', 'el', 'en-GB', 'en-ZA', 'eo', 'es-AR', 'es-ES', 'es-MX', 'et', 'eu', 'fa', 'ff', 'fi', 'fr', 'fy-NL', 'ga-IE', 'gd', 'gl', 'gu-IN', 'he', 'hi-IN', 'hr', 'hsb', 'hu', 'hy-AM', 'id', 'is', 'it', 'ja-JP-mac', 'ja', 'kk', 'km', 'kn', 'ko', 'lg', 'lij', 'lt', 'lv', 'mai', 'ml', 'mr', 'ms', 'my', 'nb-NO', 'nl', 'nn-NO', 'nso', 'or', 'pa-IN', 'pl', 'pt-BR', 'pt-PT', 'ro', 'ru', 'sk', 'sl', 'son', 'sq', 'sr', 'sv-SE', 'sw', 'ta', 'te', 'th', 'tr', 'tsz', 'uk', 'uz', 'vi', 'wo', 'xh', 'zh-CN', 'zh-TW', 'zu'], 'product': 'Fennec-41.0b1'}), kwargs: {}, attempt #1
18:53:13     INFO - POST data: languages=ach&languages=af&languages=ak&languages=ar&languages=an&languages=as&languages=az&languages=be&languages=bn-IN&languages=br&languages=ca&languages=cak&languages=cs&languages=cy&languages=da&languages=de&languages=dsb&languages=el&languages=en-GB&languages=en-ZA&languages=eo&languages=es-AR&languages=es-ES&languages=es-MX&languages=et&languages=eu&languages=fa&languages=ff&languages=fi&languages=fr&languages=fy-NL&languages=ga-IE&languages=gd&languages=gl&languages=gu-IN&languages=he&languages=hi-IN&languages=hr&languages=hsb&languages=hu&languages=hy-AM&languages=id&languages=is&languages=it&languages=ja-JP-mac&languages=ja&languages=kk&languages=km&languages=kn&languages=ko&languages=lg&languages=lij&languages=lt&languages=lv&languages=mai&languages=ml&languages=mr&languages=ms&languages=my&languages=nb-NO&languages=nl&languages=nn-NO&languages=nso&languages=or&languages=pa-IN&languages=pl&languages=pt-BR&languages=pt-PT&languages=ro&languages=ru&languages=sk&languages=sl&languages=son&languages=sq&languages=sr&languages=sv-SE&languages=sw&languages=ta&languages=te&languages=th&languages=tr&languages=tsz&languages=uk&languages=uz&languages=vi&languages=wo&languages=xh&languages=zh-CN&languages=zh-TW&languages=zu&product=Fennec-41.0b1
18:53:13     INFO - Submitting to https://bounceradmin.mozilla.com/api/product_add/
18:53:13  WARNING - Cannot access https://bounceradmin.mozilla.com/api/product_add/
18:53:13  WARNING - Returned page source:
18:53:13  WARNING - <?xml version="1.0" encoding="utf-8"?><error number="103">invalid language code(s)</error>

bear with me as I am new but it seems like adding them to bouncer will fix fennec. Are you saying though that will break desktop or cause undesired results?
(Reporter)

Comment 7

3 years ago
also relevant some irc discussion on #release-drivers

10:11 <rail> Sylvestre: see https://bugzilla.mozilla.org/show_bug.cgi?id=1193613#c3
10:14 <Sylvestre> so, we could do a build2 without these locales
10:16 <Pike> what is that bug about actually?
10:18 <rail> Pike: 2 things actually: 1) some locales are not supported by bouncer 2) the same locales are not supposed to be in beta
10:19 <Sylvestre> so, we could do a second build and just ship it, if we just update a flat file and remove these locales, it should be safe
10:19 <rail> Sylvestre: yup
10:19 <Pike> what does "region" and "supported by bouncer" have to do with each other?
10:19 <Sylvestre> rail, who should provide the patch ?
10:19 <Sylvestre> jeff ?
10:20 <Pike> note, removing them from all-locales is just going to be painful for ages on merge days
10:21 <Pike> I'd suggest to avoid that
10:21 <Sylvestre> Pike, what is the alternative ?
10:22 <Pike> given I still haven't understood what the bug is on a technical level, I don't know
10:22 <jlund> can we confirm https://bugzilla.mozilla.org/show_bug.cgi?id=1193613#c3 is true? as in, are those locales not supposed to be in fennec beta? <- Pike
10:22 <Pike> at the current level of detail, "fix bouncer"
10:22 <Sylvestre> ok, we would like to ship fennec to users today, so, we need a solution to come fast... 
10:22 <Pike> jlund: I just did
10:25 <jlund> if we "at the current level of detail, "fix bouncer"", then this is easy. just fix bouncer and retrigger submitter factory. no rebuild retag beta.
10:31 <rail> jlund: let's chat after I push the 40.0.1 updates
10:31 <jlund> sgtm
Thanks for the additional context. This is something we haven't encountered before. So here's some info from my end about these two locales, and perhaps that will help guide a solution to this bug:

1) These locales are only enabled for single-locale fennec APKs, not the multilocale build.
2) These locales are not ready to be ported to mozilla-beta and should remain on mozilla-beta.
3) (As far as I know) We've never had to add fennec locales to the product-details library. I'm not sure why it's there, or as Axel has pointed out, what that library has to do with bouncer or why these locales would need to be in either.
(Reporter)

Comment 9

3 years ago
thanks jeff, I'm not knowledgeable enough on locale state to make this decision. 

pike, rail, any thoughts given comment 6-8. Looking for a resolution between us all and afaik, we have two options:

1) add tsz/cak to https://bounceradmin.mozilla.com
2) remove tsz/cak locales from m-b (and config merge scripts to lock these locales on m-a from uplifting)

It sounds like tsz/cak shouldn't be on m-b in all-locales yet. However, I'm wondering what will happen if we add those locales to bouncer. Will it cause us to ship single locale tsz/cak apk builds? Or will it be quietly ignored. If it's a no-op, I vote on just letting bouncer be aware of these locales.

also of note, it seems like these locales on not on m-c, just m-a/m-b

This will break again on the beta2 release with no action.
Flags: needinfo?(rail)
Flags: needinfo?(l10n)
Let's separate the issues here:

1) Add locales to bouncer, regardless we want them to see in beta or not. This can be done by adding locales to http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class.php?view=markup

2) Decide whether we want this locales in beta or not. Do we want to maintain a list of exclusions like in central vs aurora? In this case we will need to change how we do merges and will require explicit promotion locales to beta.
Flags: needinfo?(rail)
(In reply to Rail Aliiev [:rail] from comment #10)
> Let's separate the issues here:
> 
> 1) Add locales to bouncer, regardless we want them to see in beta or not.
> This can be done by adding locales to
> http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class.
> php?view=markup
> 
To my knowledge, this has been unnecessary for fennec all-locales. Has something changed? Could you or Jordan address my questions in item 3, comment 8 to explain this piece please?
> 2) Decide whether we want this locales in beta or not. Do we want to
> maintain a list of exclusions like in central vs aurora? In this case we
> will need to change how we do merges and will require explicit promotion
> locales to beta.
Eventually we will want them in Beta, they're just not ready to be there yet.
Does it hurt to have them in all-locales as long as they're not in shipped-locales? No idea if there's anything actually consuming resources for those on beta, and if so, if that'd be a bug?

I personally would prefer if we could keep the magic mike merge logic to just central->aurora.

And yes, we want bouncer on, at the latest when we expose aurora builds on the web site.
Flags: needinfo?(l10n)
(In reply to Jeff Beatty [:gueroJeff] from comment #11)
> (In reply to Rail Aliiev [:rail] from comment #10)
> > Let's separate the issues here:
> > 
> > 1) Add locales to bouncer, regardless we want them to see in beta or not.
> > This can be done by adding locales to
> > http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class.
> > php?view=markup
> > 
> To my knowledge, this has been unnecessary for fennec all-locales. Has
> something changed?

This is necessary for everything going through bouncer.

(In reply to Axel Hecht [:Pike] from comment #12)
> Does it hurt to have them in all-locales as long as they're not in
> shipped-locales? No idea if there's anything actually consuming resources
> for those on beta, and if so, if that'd be a bug?

I don't think we consume mobile shipped-locales on beta. Multilocale locales come from the dashboard, submited explicitly by release management via ship-it. Single locale builds consume all-locales. Having locales in all-locales won't hurt the build side, it's all about how comfortable we are having the locales on FTP and have possible issues with their builds.

> 
> I personally would prefer if we could keep the magic mike merge logic to
> just central->aurora.

++
(Reporter)

Comment 14

3 years ago
(In reply to Jeff Beatty [:gueroJeff] from comment #11)

> To my knowledge, this has been unnecessary for fennec all-locales. Has
> something changed? Could you or Jordan address my questions in item 3,
> comment 8 to explain this piece please?

sorry, I am not familiar with this piece. is rails reply in comment 13 sufficient?


sounds like it's harmless having those locales in http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class

I'd imagine we would want to eventually anyway. Jeff are you okay with doing that?

if so, now we just need to decide if we want to keep them in all-locales on m-b. rail and pike sound like they would prefer leaving them in there and not messing with merge logic. Jeff, are you comfortable with that given comment 13 remarks about how they would appear on FTP?
(In reply to Rail Aliiev [:rail] from comment #13)
> (In reply to Jeff Beatty [:gueroJeff] from comment #11)
> > (In reply to Rail Aliiev [:rail] from comment #10)
> > > Let's separate the issues here:
> > > 
> > > 1) Add locales to bouncer, regardless we want them to see in beta or not.
> > > This can be done by adding locales to
> > > http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class.
> > > php?view=markup
> > > 
> > To my knowledge, this has been unnecessary for fennec all-locales. Has
> > something changed?
> 
> This is necessary for everything going through bouncer.
> 
I still don't understand why this has to go through bouncer. As stated above, we've not had to add fennec locales to the product-details library before (because we don't distribute single-locale Aurora or Beta APK's on mozilla.org). I'm not sure what the product-details library has to do with bouncer or why these locales would need to be in either.
(In reply to Jeff Beatty [:gueroJeff] from comment #15)
> I still don't understand why this has to go through bouncer. As stated
> above, we've not had to add fennec locales to the product-details library
> before (because we don't distribute single-locale Aurora or Beta APK's on
> mozilla.org).

We submit all beta/release releases through Bouncer. This way we have better stats. I don't know where the single locale APKs are listed though. Maybe we should stop building them if they are not published anywhere?

> I'm not sure what the product-details library has to do with
> bouncer or why these locales would need to be in either.

Bouncer uses that file as a single source of truth. For every product we submit to bouncer, we also list the locales, so bouncer can crawl the mirrors and check all files.
(In reply to Rail Aliiev [:rail] from comment #16)
> (In reply to Jeff Beatty [:gueroJeff] from comment #15)
> > I still don't understand why this has to go through bouncer. As stated
> > above, we've not had to add fennec locales to the product-details library
> > before (because we don't distribute single-locale Aurora or Beta APK's on
> > mozilla.org).
> 
> We submit all beta/release releases through Bouncer. This way we have better
> stats. I don't know where the single locale APKs are listed though. Maybe we
> should stop building them if they are not published anywhere?
> 
They're available from ftp. Localizers use them for testing and we don't add them to maemo-locales (multilocale build) until they've signed off on the localization. They're still vital to the l10n process for Fennec.
> > I'm not sure what the product-details library has to do with
> > bouncer or why these locales would need to be in either.
> 
> Bouncer uses that file as a single source of truth. For every product we
> submit to bouncer, we also list the locales, so bouncer can crawl the
> mirrors and check all files.
Ah, ok. I understand now. Thank you.
(Reporter)

Comment 18

3 years ago
> > > I'm not sure what the product-details library has to do with
> > > bouncer or why these locales would need to be in either.
> > 
> > Bouncer uses that file as a single source of truth. For every product we
> > submit to bouncer, we also list the locales, so bouncer can crawl the
> > mirrors and check all files.
> Ah, ok. I understand now. Thank you.

beta1 and beta2 bouncer submission failed. I think this blocks all single locale apks. are we good to add tsz and cak to bouncer or is there still push back?
(Reporter)

Comment 19

3 years ago
ni: re comment 18
Flags: needinfo?(jbeatty)
Please add.
Flags: needinfo?(jbeatty)
(Reporter)

Comment 21

3 years ago
(In reply to Jeff Beatty [:gueroJeff] from comment #20)
> Please add.

https://bugzilla.mozilla.org/show_bug.cgi?id=1193613#c2 suggests that that you are the person to ask for this. Could you help me or point me to who you think can? I am not familiar with the web app / db.

thanks in advance.
Flags: needinfo?(jbeatty)
Just to be clear. The only actionable item here is adding the locales to http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class.php?view=markup. From the history at http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class.php?view=log sounds like Sylvestre or Pascal can help adding those.

No action is required to add the locales to the bouncer DB, it should be added automatically by some automation.
(Reporter)

Comment 23

3 years ago
(In reply to Rail Aliiev [:rail] from comment #22)
> Just to be clear. The only actionable item here is adding the locales to
> http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class.
> php?view=markup. From the history at
> http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class.
> php?view=log sounds like Sylvestre or Pascal can help adding those.

302'n to Sylvestre in that case.
Flags: needinfo?(jbeatty) → needinfo?(sledru)
Sure. Committed as r145607. As confirmation, I will need the native name of 
"Kaqchikel" (cak)
"Purépecha" (tsz)
For now, it seems that they are also using a Latin alphabet, So, I reused the same words (but this is easy to change)

Jeff, could you confirm with the localizers? Thanks
Flags: needinfo?(sledru) → needinfo?(jbeatty)
cak should be "Maya Kaqchikel" . You have tsz correct.

Thanks :-)
Flags: needinfo?(jbeatty)
Updated, thanks ! r145632
(Reporter)

Comment 27

3 years ago
hrm, even though these were pushed in comment 26, https://bounceradmin.mozilla.com/api/docs/product_add still doesn't seem to know about them. is there needed deployment steps or could this possibly be wedged?
Flags: needinfo?(fwenzel)
Over to rhelmer who has been shepherding Bouncer for a while.
Flags: needinfo?(fwenzel) → needinfo?(rhelmer)
(In reply to Fred Wenzel [:wenzel] from comment #28)
> Over to rhelmer who has been shepherding Bouncer for a while.

Thanks!

(In reply to Jordan Lund (:jlund) from comment #27)
> hrm, even though these were pushed in comment 26,
> https://bounceradmin.mozilla.com/api/docs/product_add still doesn't seem to
> know about them. is there needed deployment steps or could this possibly be
> wedged?

I think the product-details checkout from SVN needs to be updated manually, it should be wherever PROD_DETAILS_DIR is configured to point in the settings file.

:gozer do you still handle bouncer server changes, if so could you please update the product-details checkout to r145632 (per comment 26)? If not please let me know :) We can file a bug if you need.
Flags: needinfo?(rhelmer) → needinfo?(gozer)
(In reply to Robert Helmer [:rhelmer] from comment #29)
> (In reply to Fred Wenzel [:wenzel] from comment #28)
> > Over to rhelmer who has been shepherding Bouncer for a while.
> 
> Thanks!
> 
> (In reply to Jordan Lund (:jlund) from comment #27)
> > hrm, even though these were pushed in comment 26,
> > https://bounceradmin.mozilla.com/api/docs/product_add still doesn't seem to
> > know about them. is there needed deployment steps or could this possibly be
> > wedged?
> 
> I think the product-details checkout from SVN needs to be updated manually,
> it should be wherever PROD_DETAILS_DIR is configured to point in the
> settings file.
> 
> :gozer do you still handle bouncer server changes, if so could you please
> update the product-details checkout to r145632 (per comment 26)? If not
> please let me know :) We can file a bug if you need.

Nope, redirecting to webops's queue
Assignee: nobody → server-ops-webops
Component: Product Details → WebOps: Other
Flags: needinfo?(gozer)
Product: www.mozilla.org → Infrastructure & Operations
QA Contact: smani
Version: Development/Staging → other

Updated

3 years ago
Whiteboard: [kanban:https://webops.kanbanize.com/ctrl_board/2/1774]
(Assignee)

Updated

3 years ago
Assignee: server-ops-webops → cliang
(Assignee)

Comment 31

3 years ago
I *think* I've updated bouncer so that these locales now show up on  https://bounceradmin.mozilla.com/api/docs/product_add.  (These locales appear in the "Optional POST Parameters" section.)  If I've misunderstood and these locales are still missing, please let me know.

[For future bug archaeology: I handled this as a normal update of bouncer as described in the website documentation in mana.]
(Assignee)

Comment 32

3 years ago
@jlund: Are you able to confirm that the lnew tsz and cak locales are correctly showing up?
Flags: needinfo?(jlund)
(Reporter)

Comment 33

3 years ago
(In reply to C. Liang [:cyliang] from comment #32)
> @jlund: Are you able to confirm that the lnew tsz and cak locales are
> correctly showing up?

we have had no issues with single locale jobs on the last few releases. this seems proof enough that we are good here. thank you very much
Flags: needinfo?(jlund)
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 34

2 years ago
Clearing Locale value as it is no longer relevant for this product and component.
Locale: cak / Kaqchikel
You need to log in before you can comment on or make changes to this bug.