Closed Bug 1196414 Opened 9 years ago Closed 9 years ago

[Music][NGA] Add missing overlay dialogs

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S6 (04Sep)

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

Attachments

(2 files)

[gaia] justindarc:bug1196414 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
squib
: review+
Details | Review
[gaia] justindarc:bug1196414-v2 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review 
The Music NGA app needs to display "overlay" dialogs for various statuses such as "No Music", etc.
Assignee: nobody → jdarcangelo
Target Milestone: --- → FxOS-S6 (04Sep)
Blocks: 1196441
Comment on attachment 8650871 [details] [review]
[gaia] justindarc:bug1196414 > mozilla-b2g:master

This patch also integrates your most recent changes to db.js from Music OGA.
Attachment #8650871 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8650871 [details] [review]
[gaia] justindarc:bug1196414 > mozilla-b2g:master

This looks good, but r- because I think you're being a little too conservative in not changing db.js's code. A lot of its contents were just placeholders until we rewrote the app.
Attachment #8650871 - Flags: review?(squibblyflabbetydoo) → review-
Comment on attachment 8650871 [details] [review]
[gaia] justindarc:bug1196414 > mozilla-b2g:master

Edited db.js to no longer be dependent upon `App` global and it now directly broadcasts `service` events and internally waits for `ready` and `enumerable` promises to resolve before allowing DB operations to continue.
Attachment #8650871 - Flags: review- → review?(squibblyflabbetydoo)
Comment on attachment 8650871 [details] [review]
[gaia] justindarc:bug1196414 > mozilla-b2g:master

Land it!
Attachment #8650871 - Flags: review?(squibblyflabbetydoo) → review+
Landed on master:

https://github.com/mozilla-b2g/gaia/commit/c74e69d85e0f6a18afe3fa27a8eeceae70a2ff18
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Backed out along with bug 1196425.

https://github.com/mozilla-b2g/gaia/commit/e95a7f36fbaac719d218691a08f5333bc0988337
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 1197873
Depends on: 1196425
Comment on attachment 8655100 [details] [review]
[gaia] justindarc:bug1196414-v2 > mozilla-b2g:master

Carrying over R+
Attachment #8655100 - Flags: review+
Landed on master:

https://github.com/mozilla-b2g/gaia/commit/3f53a3aebf6d0fc4538d7f1e1f0bab0a07eccc89
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: