[Music][NGA] Add missing overlay dialogs

RESOLVED FIXED in FxOS-S6 (04Sep)

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: justindarc, Assigned: justindarc)

Tracking

unspecified
FxOS-S6 (04Sep)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

The Music NGA app needs to display "overlay" dialogs for various statuses such as "No Music", etc.
(Assignee)

Updated

3 years ago
Assignee: nobody → jdarcangelo
Target Milestone: --- → FxOS-S6 (04Sep)
Blocks: 1196441
Created attachment 8650871 [details] [review]
[gaia] justindarc:bug1196414 > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8650871 [details] [review]
[gaia] justindarc:bug1196414 > mozilla-b2g:master

This patch also integrates your most recent changes to db.js from Music OGA.
Attachment #8650871 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8650871 [details] [review]
[gaia] justindarc:bug1196414 > mozilla-b2g:master

This looks good, but r- because I think you're being a little too conservative in not changing db.js's code. A lot of its contents were just placeholders until we rewrote the app.
Attachment #8650871 - Flags: review?(squibblyflabbetydoo) → review-
(Assignee)

Comment 4

3 years ago
Comment on attachment 8650871 [details] [review]
[gaia] justindarc:bug1196414 > mozilla-b2g:master

Edited db.js to no longer be dependent upon `App` global and it now directly broadcasts `service` events and internally waits for `ready` and `enumerable` promises to resolve before allowing DB operations to continue.
Attachment #8650871 - Flags: review- → review?(squibblyflabbetydoo)
Comment on attachment 8650871 [details] [review]
[gaia] justindarc:bug1196414 > mozilla-b2g:master

Land it!
Attachment #8650871 - Flags: review?(squibblyflabbetydoo) → review+
(Assignee)

Comment 6

3 years ago
Landed on master:

https://github.com/mozilla-b2g/gaia/commit/c74e69d85e0f6a18afe3fa27a8eeceae70a2ff18
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Backed out along with bug 1196425.

https://github.com/mozilla-b2g/gaia/commit/e95a7f36fbaac719d218691a08f5333bc0988337
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

3 years ago
Blocks: 1197873
(Assignee)

Updated

3 years ago
Depends on: 1196425
Created attachment 8655100 [details] [review]
[gaia] justindarc:bug1196414-v2 > mozilla-b2g:master
(Assignee)

Comment 9

3 years ago
Comment on attachment 8655100 [details] [review]
[gaia] justindarc:bug1196414-v2 > mozilla-b2g:master

Carrying over R+
Attachment #8655100 - Flags: review+
(Assignee)

Comment 10

3 years ago
Landed on master:

https://github.com/mozilla-b2g/gaia/commit/3f53a3aebf6d0fc4538d7f1e1f0bab0a07eccc89
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.