1197569 - Can't unmute tab audio indicator after change to a complete theme which is not support tab-audio

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[magicp]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20150822004009

Steps to reproduce:

1. Mute tab audio indicator in the default theme.
2. Enable a complete theme which is not support tab-audio. (e.g. LavaFox V2 version 2.3.8)
3. After restart, confirm tab audio indicator.


Actual results:

Can't unmute tab audio indicator after enable a complete theme which is not support tab-audio.


Expected results:

Tab context menu should have the following menu items for complete themes.
- Mute Tab
- Mute All Tabs
- Unmute Tab
- Unmute All Tabs

Comment 1

[(no longer active)]

Attachment: Add a tab context menu entry for toggling the tab's muted state

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f65705f6dc2a

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f65705f6dc2a

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Note that the current patch cannot be uplifted due to the strings that it introduces.

Comment 5

[(no longer active)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> Note that the current patch cannot be uplifted due to the strings that it
> introduces.

Yeah, I think it's fine to ship this in 43.

Comment 6

[tabmix.onemen]

Why you leave the new menu item visible on tabs don't play sound and not mute ?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to tabmix.onemen from comment #6)
> Why you leave the new menu item visible on tabs don't play sound and not
> mute ?

This is to allow people to mute a tab before it starts playing sound.

Comment 8

[magicp]

This menuitem doesn't have a identifier attribute for state. Label will be changed each language. How can I identify mute or unmute state for adding context menu icons?

Comment 9

[magicp]

(In reply to magicp from comment #8)
> This menuitem doesn't have a identifier attribute for state. Label will be
> changed each language. How can I identify mute or unmute state for adding
> context menu icons?

Filed Bug 1200381

Comment 10

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on latest Aurora 43.0a2 (buildID: 20151011004016).