119992 - Address Book Import -Can't go back

Status: RESOLVED FIXED

(MailNews Core :: Import, defect)

Description

[timeless]

cvs build, now, freebsd

Steps
tasks>tools>import utility

select addressbook and click next.

The back button is disabled, contrast with bug 119991.

Comment 1

[Ninoschka Baca]

What build are you using?

Commercial Trunk build 2002-01-15-03:WinMe, ok.
Mozilla build 2002-01-15: Linux RH 7.1, ok.
After select Tasks|Tools|Import Utility, Address Book Radio button, Next and the
Back button appears enabled. I select the Back button and it works as expected.

Comment 2

[timeless]

apparently i actually have to answer that question.  i thought it was clear from the first line. it was a cvs build from the time of the report.

please note that commercial builds tend to include features not included as part of mozilla so the fact that i get an empty set and you get a non empty set shouldn't be surprising.  please test with a mozilla build.

Comment 3

[Ninoschka Baca]

Mozilla build 2002-01-15: Linux RH 7.1, as stated in Comment #1.

These are the steps to reproduce the problem:

1. Select tasks>tools>import utility
2. Select the Address Book radio button, Next
3. Select the text option, Next
4. Cancel out of the 'Select address book file'dialog

Actual Results: The Back button is disabled
Expected Results: The Back button should be enabled.

Comment 4

[Ninoschka Baca]

Marking nsbeta1 to get this on a list to be fixed, eventually.

Comment 5

[Michael Buckland]

Discussed in 2/28/02 Mail & News bug meeting.  Decisions was to minus and Future
this bug.

Comment 6

[Cavin Song]

Attachment: Proposed patch, v1

The Back button is enabled if you cancel out of the *.lid file selection
dialog. Similar fix applies to importing mail from Comm 4.x when you cancel out
of the 4.x profile list dialog.

Comment 7

[Navin Gupta]

Comment on attachment 89144 [details] [diff] [review]
Proposed patch, v1

looks ok, r=naving

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 89144 [details] [diff] [review]
Proposed patch, v1

looks good.  sr=sspitzer

are we already able to go back from settings and mail import?

make sure to check that nothing funky happens if we go way down the ab import
path, and then go back and choose something else.  I don't know enough about
how the import wizard keeps track of state to know if this would cause a
problem or not.

Comment 9

[Cavin Song]

Yes, before you commit the import operation you can always go back (ie, before 
you, for example, select Eudora and hit Next) and switch from AddressBook import 
to Mail import for example. The patch does work fine with switching back and 
forth among various options before committing the operation.

Comment 10

[Cavin Song]

Taking the bug.

Comment 11

[Cavin Song]

Fix checked in to the trunk.

Comment 12

[Cavin Song]

Reopen the bug since when we finish the import the Back button (in the last 
"finish" dialog) should be always disabled in case it was enabled by the patch.

Comment 13

[Cavin Song]

Attachment: Always disable the Back button in the last dialog

Comment 14

[Jean-Francois Ducarroz]

Comment on attachment 89635 [details] [diff] [review]
Always disable the Back button in the last dialog

R=ducarroz

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 89635 [details] [diff] [review]
Always disable the Back button in the last dialog

sr=sspitzer

Comment 16

[Cavin Song]

Comment on attachment 89635 [details] [diff] [review]
Always disable the Back button in the last dialog

adding r=Ducarroz from the edit box.

Comment 17

[Cavin Song]

Second fix checked in to the trunk.

Comment 18

[Ninoschka Baca]

Trunk build 2002-07-16: WinMe, Linux RH 7.1 - ok
In all cases the Back button was enabled except after the import was
successful/complete. Then the Finish button is enabled.

Trunk build 2002-07-16: Mac 10.1.3, Reopening due to problem after selecting
Tools|Import|Address Book|Eudora, Next, Cancel the dialog and notice that the
Back button is disabled.

Comment 19

[Wayne Mery (:wsmwk)]

Bug 217930 summarizes *for windows* what might be several duplicates (for windows)

Comment 20

[Samuel Sidler (old account; do not CC)]

Mind if I call this a "Mac" bug? ;)

Comment 22

[:aceman]

Eudora is no more in the list. Better close this with the work done here. If anything crops up yet, please open new bug.