216155 - tools/import/mail/application back button will not respond if error (e.g. comm4x/outlook)

Status: RESOLVED FIXED

(MailNews Core :: Import, defect)

Description

[Dmitry Borisovets]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1

Going to tools/import/mail/, choose Outlook (not x-press). Outlook is not
installed, so TB says: 'unable to find mail to import'. 'Back' button will not
respond on this form.

Reproducible: Always

Steps to Reproduce:
1. Going to tools/import/mail.
2. Choose Outlook (not x-press). outlook is not installed!
3. Press Back button.

Actual Results:  
nothing happened.

Expected Results:  
TB should go to previous form.

Comment 1

[Bronson C. Elliott]

Confirmed

Comment 2

[Thomas Delrue]

*** Bug 227351 has been marked as a duplicate of this bug. ***

Comment 3

[Doug Wright]

Not a TB auto-migration bug -> Core:MailNews:Import

Comment 4

[Mark Banner (:standard8)]

This seems a little more generic, so widening the scope a little.

Comment 7

[Mark Banner (:standard8)]

Attachment: The fix

This fixes the case where we do Tools -> Import -> Mail -> Comm 4x and it fails because comm4x isn't installed, but the back button is enabled - it is still enabled, and we go back to the mail app selection dialog properly.

I've also fixed some instances where we're doing .createInstace() followed by .QueryInterface(...).

Comment 8

[Mark Banner (:standard8)]

Patch checked in: http://hg.mozilla.org/comm-central/rev/932d18a63d15