1200078 - [browser] Remove deprecated mozL10n.get

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[yifan [:yifan][:yliao]]

There are 40 deprecated mozL10n.get calls in the TV browser. We should use

    node.setAttribute('data-l10n-id', l10nId) or
    navigator.mozL10n.setAttributes(node, l10nId, l10nArgs);    

to replace them. Thanks to Zibi for the detailed comments. Please refer to the comments in https://github.com/mozilla-b2g/gaia/pull/31371 .

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Hi Dan, any ETA for this?

Comment 2

[Dan Huang[:danhuang]]

Hi Zibi, sorry for late update. Currently I am working on gaia-tv 2.5 feature, and the deadline is in the middle of October. So I would start fixing this bug in the end of October.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1200078-refactor-l10n-in-browser > mozilla-b2g:master

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8712319 [details] [review]
[gaia] zbraniecki:1200078-refactor-l10n-in-browser > mozilla-b2g:master

This quarter I'm moving System and TV to l20n, so I need this patch.

It was actually fairly trivial to write because the code is clean and easy to transition! :)

:yifan - can you review this for me?

Comment 5

[yifan [:yifan][:yliao]]

Comment on attachment 8712319 [details] [review]
[gaia] zbraniecki:1200078-refactor-l10n-in-browser > mozilla-b2g:master

Thank you for the help! Just a nit on Github.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thanks! Great catch!

Commit: https://github.com/mozilla-b2g/gaia/commit/62f6b41b8775fde10ef832fdf8c08154601ece98