Update Google search plugin favicon

VERIFIED FIXED in Firefox 45

Status

()

defect
P2
normal
Rank:
25
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: ntim, Assigned: Gijs)

Tracking

unspecified
Firefox 46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41+ wontfix, firefox42- wontfix, firefox43- wontfix, firefox44 wontfix, firefox45 verified, firefox46 verified)

Details

(Whiteboard: [fxsearch])

Attachments

(3 attachments)

Comment hidden (empty)
Duplicate of this bug: 1201216
Kev, can you get official copies from Google?

[Tracking Requested - why for this release]:
We should expedite this to stay up-to-date with the branding guidelines of Google. If we get this fixed soon we should be able to uplift this to Beta41 with no issues.
Flags: needinfo?(kev)
Note that google.xml includes multiple logo sizes. And even the 16x16 is a multi-image icon (for hidpi, bug 795495), although the icon in comment 1 is too.

And then there are the localized google.xmls in the L10N repos...
Priority: -- → P2
Whiteboard: [fxsearch]
(In reply to Justin Dolske [:Dolske] from comment #4)
> Note that google.xml includes multiple logo sizes. And even the 16x16 is a
> multi-image icon (for hidpi, bug 795495), although the icon in comment 1 is
> too.
Do we even use the bigger horizontal images anywhere with the new search UI? 

> And then there are the localized google.xmls in the L10N repos...
That's easy. We only have a localized Google in Japanese (ja, ja-JP-mac) and Kurdish (ku), and we should probably file a bug to get rid of the latter from repos (we don't ship ku anyway these days).
(In reply to Francesco Lodolo [:flod] PTO-BACK ON SEP 7 from comment #5)

> > And then there are the localized google.xmls in the L10N repos...
> That's easy. We only have a localized Google in Japanese (ja, ja-JP-mac) and
> Kurdish (ku), and we should probably file a bug to get rid of the latter
> from repos (we don't ship ku anyway these days).

Great -- I hadn't checked, I just (incorrectly?) remembered this being a pain last time we did this.
Sorry, missed this. Adding Joanne, who manages that relationship, and should be able to get the official favicons. What sizes do we need for Desktop, Fennec, iOS, and FxOS? We should knock them all off at once.
Flags: needinfo?(kev) → needinfo?(jnagel)
A few searchplugin are nice to update, since we rely on the en-US file (Bing, DuckDuckGo, Google, Twitter). Japanese is usually the only exception shipping a localized version.

Amazon, eBay, Wikipedia, Yahoo have localized domains and params, so they're still a pain that require weeks to fix in l10n repositories.

Updated

4 years ago
Depends on: 1201770
Tracked for 41+. As mentioned in comment 3, we are a week away from building 41 RC so this needs to land soon if we want it in 41.
(In reply to Kev Needham [:kev] from comment #7)
> What sizes do we need for Desktop,
> Fennec, iOS, and FxOS? We should knock them all off at once.

google.xml for Desktop has 16w x 16h, 65w x 26h, 130w x 52h. As comment #5 mentions, we may not be using the latter two versions anymore.

Richard and Chenxia, can you post the sizes that you need for iOS and Android, respectively? Ben, can you post the sizes needed for FxOS?
Flags: needinfo?(rnewman)
Flags: needinfo?(liuche)
Flags: needinfo?(bfrancis)

Comment 11

4 years ago
(In reply to Ritu Kothari (:ritu) from comment #9)
> Tracked for 41+. As mentioned in comment 3, we are a week away from building
> 41 RC so this needs to land soon if we want it in 41.

Folks, I need all the sizes  and preferred file type asap to make the request, if you want me to get these in time.
Flags: needinfo?(jnagel)
The asset we have right now on iOS:

google.png PNG 90x90 90x90+0+0 8-bit sRGB 2.77KB 0.000u 0:00.000

I don't think all of our engines are that size, but presumably it'll do!
Flags: needinfo?(rnewman)
Firefox OS currently just has a 16x16 pixel icon in the codebase https://github.com/mozilla-b2g/gaia/tree/master/customization/search but as far as I can tell it isn't actually used in the current design.

It might be useful to have something larger to use in future, but we have no immediate requirements.

Thanks
Flags: needinfo?(bfrancis)
Depends on: 1202642
For fennec: 16x16, 32x32, 48x48, 64x64, 96x96 pixel icons in png

(Our google.xml just uses a 16x16, but we also use the search icon elsewhere, see bug 1156917.)
Flags: needinfo?(liuche)
(In reply to Chenxia Liu [:liuche] from comment #14)
> (Our google.xml just uses a 16x16, but we also use the search icon
> elsewhere, see bug 1156917.)

I'm confused: isn't Fennec using a single 96px PNG icon these days?
http://hg.mozilla.org/mozilla-central/file/b23b2fa33a9d/mobile/locales/en-US/searchplugins/google.xml#l8
hey guys,

Chiming in here from Mobile UX. 

We'll likely handle this separately in bug 1201770 (for scope) since our UI calls for a little bit more than just their favicon. 

Essentially, we need to get a logo from them that is designed to be on an icon of solid color. Our icon that I'm referring to is indeed 96 x 96 but it was specific rounded corners and specs that keep it consistent with the rest of our other providers in our UI. You can imagine that this might look a bit weird if there's suddenly one that's a circle. So it's a bit more finicky.
It is getting too late to fix this in FF41 given that we don't have a patch ready or in the works. This does not seem to be a release blocker.

Comment 18

4 years ago
I see details for iOS, Fennec and FxOS, but I do not have list of sizes required for Desktop.  Can someone help me out so I can reach out to Google for the assets?  thanks!
(In reply to (Mostly away 9/11-9/23) Jared Wein [:jaws] (please needinfo? me) from comment #10)
> (In reply to Kev Needham [:kev] from comment #7)
> > What sizes do we need for Desktop,
> > Fennec, iOS, and FxOS? We should knock them all off at once.
> 
> google.xml for Desktop has 16w x 16h, 65w x 26h, 130w x 52h. As comment #5
> mentions, we may not be using the latter two versions anymore.

The image that's in the <Image width="16" height="16"> line is an ico file that contains at least a 16x16 and a 32x32 variant. The latter is used for retina screens.
Mike, do you care about that?

As we haven't made any progress on this for a month, I don't think this is a priority. I am going to untrack it but happy to take a patch in 42.
Flags: needinfo?(mconnor)

Comment 22

4 years ago
Update - I have been trying to obtain the files since last month and have been unsuccessful.  I have sent another email today - asking that they send the files directly to me.  Initially I was provided access to their branding server, but this favicon was not included in the files.  Now I can no longer access that site, after trying 10+ times over the past week or so..I'm doing my best here.

Updated

4 years ago
Rank: 25

Comment 23

4 years ago
I was able to obtain the attached file, please let me know if there are any issues with it.  Anthony was able to use it for the mobile bug...
Stephen, are you able to use this Illustrator file to create the icons for desktop Firefox?

> google.xml for Desktop has 16w x 16h, 65w x 26h, 130w x 52h. As comment #5
> mentions, we may not be using the latter two versions anymore.

> The image that's in the <Image width="16" height="16"> line is an ico file
> that contains at least a 16x16 and a 32x32 variant. The latter is used for
> retina screens.
Flags: needinfo?(mconnor) → needinfo?(shorlander)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #24)
> Stephen, are you able to use this Illustrator file to create the icons for
> desktop Firefox?
> 
> > google.xml for Desktop has 16w x 16h, 65w x 26h, 130w x 52h. As comment #5
> > mentions, we may not be using the latter two versions anymore.
> 
> > The image that's in the <Image width="16" height="16"> line is an ico file
> > that contains at least a 16x16 and a 32x32 variant. The latter is used for
> > retina screens.

I can, but the favicon linked in comment #1 seems to be exactly what we want. Is there a reason we can't insert that as base64 here? http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/google.xml#9
Flags: needinfo?(shorlander)
(In reply to Stephen Horlander [:shorlander] from comment #25)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #24)
> > Stephen, are you able to use this Illustrator file to create the icons for
> > desktop Firefox?
> > 
> > > google.xml for Desktop has 16w x 16h, 65w x 26h, 130w x 52h. As comment #5
> > > mentions, we may not be using the latter two versions anymore.
> > 
> > > The image that's in the <Image width="16" height="16"> line is an ico file
> > > that contains at least a 16x16 and a 32x32 variant. The latter is used for
> > > retina screens.
> 
> I can, but the favicon linked in comment #1 seems to be exactly what we
> want. Is there a reason we can't insert that as base64 here?
> http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/
> searchplugins/google.xml#9

Yeah, we can probably drop the two wide format images since I don't think they're being used anywhere. The image linked there is 32x32, we would probably want a 16x16 one so we don't have to always downscale it.
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #26)
> (In reply to Stephen Horlander [:shorlander] from comment #25)
> > (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #24)
> > > Stephen, are you able to use this Illustrator file to create the icons for
> > > desktop Firefox?
> > > 
> > > > google.xml for Desktop has 16w x 16h, 65w x 26h, 130w x 52h. As comment #5
> > > > mentions, we may not be using the latter two versions anymore.
> > > 
> > > > The image that's in the <Image width="16" height="16"> line is an ico file
> > > > that contains at least a 16x16 and a 32x32 variant. The latter is used for
> > > > retina screens.
> > 
> > I can, but the favicon linked in comment #1 seems to be exactly what we
> > want. Is there a reason we can't insert that as base64 here?
> > http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/
> > searchplugins/google.xml#9
> 
> Yeah, we can probably drop the two wide format images since I don't think
> they're being used anywhere. The image linked there is 32x32, we would
> probably want a 16x16 one so we don't have to always downscale it.

The linked favicon contains a 16 x 16 and 32 x 32 image.
As I understand it, data URI doesn't allow including multiple formats. The tools that I know about that will take an image and provide the data URI will only provide it for the 32x32 version. Can you provide the one for the 16x16?
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #28)
> As I understand it, data URI doesn't allow including multiple formats. The
> tools that I know about that will take an image and provide the data URI
> will only provide it for the 32x32 version. Can you provide the one for the
> 16x16?

Take 2 PNG and create one .ico file including both sizes (there are web services that do that, e.g. http://icoconvert.com/Multi_Image_to_one_icon/).

Then convert the .ico file to a data URI (again, some web services accept .ico, e.g. http://freeonlinetools24.com/base64-image).
Comment hidden (advocacy)
(Assignee)

Updated

3 years ago
Flags: needinfo?(gijskruitbosch+bugs)
(Assignee)

Updated

3 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8709943 - Flags: review?(florian) → review+
Comment on attachment 8709943 [details]
MozReview Request: Bug 1200726 - part 0: remove all large icons, r?florian

https://reviewboard.mozilla.org/r/31607/#review28309

Thanks for cleaning this up. I suspect these icons were not just wasting disk space, but also memory, as the search service loads everything during initialization and doesn't touch the XML files after that.
Attachment #8709944 - Flags: review?(florian) → review+
Comment on attachment 8709944 [details]
MozReview Request: Bug 1200726 - part 1: change google icon, r?florian

https://reviewboard.mozilla.org/r/31609/#review28311

Looks OK to me. Is this something we want to uplift?
(Assignee)

Comment 36

3 years ago
Comment on attachment 8709944 [details]
MozReview Request: Bug 1200726 - part 1: change google icon, r?florian

(In reply to Florian Quèze [:florian] [:flo] from comment #34)
> Comment on attachment 8709944 [details]
> MozReview Request: Bug 1200726 - part 1: change google icon, r?florian
> 
> https://reviewboard.mozilla.org/r/31609/#review28311
> 
> Looks OK to me. Is this something we want to uplift?

Yeah, probably.

Approval Request Comment
[Feature/regressing bug #]: Google changed their logo!
[User impact if declined]: old logo makes us look sadface and outdated
[Describe test coverage new/current, TreeHerder]: limited
[Risks and why]: low risk, we're just changing a logo
[String/UUID change made/needed]: nope

Beta uplift request is for 45. I guess if this hits aurora soon enough it won't need it.

Note that the remainder of the large icon removals are probably safe for uplift too, and might make a small performance difference, but are otherwise not necessary. Uplifting just the logo change for google will have conflicts with the patch as-is, but it's a trivial patch (one-line change!) so should be OK for uplift either way.
Attachment #8709944 - Flags: approval-mozilla-beta?
Attachment #8709944 - Flags: approval-mozilla-aurora?

Comment 38

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cca4dbb52c8d
https://hg.mozilla.org/mozilla-central/rev/d1b0d8428d6d
https://hg.mozilla.org/mozilla-central/rev/b60cae69c6fd
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment on attachment 8709944 [details]
MozReview Request: Bug 1200726 - part 1: change google icon, r?florian

thanks
Attachment #8709944 - Flags: approval-mozilla-beta?
Attachment #8709944 - Flags: approval-mozilla-beta-
Attachment #8709944 - Flags: approval-mozilla-aurora?
Attachment #8709944 - Flags: approval-mozilla-aurora+
Reproduced this bug with Firefox Nightly 43.0a1 (2015-09-01);(Build ID: 20150901030226) on Linux, 64 Bit

This Bug's fix is now verified on Latest Firefox Beta 45.0b7 (Build ID: 20160218171844)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 and

Latest Firefox Developer Edition 46.0a2 (2016-02-20) ; (Build ID: 20160220004011)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0
QA Whiteboard: [testday-20160219]
(Reporter)

Updated

3 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.