1201211 - test_add_new_contact.py: AssertionError: u'' != 'gaia387364'

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Nicholas Nelson [:NicholasN]]

Description: When this test fails it appears that after information is entered into all of the fields, the contact attempts to save, but fails. There are no contacts present after the test is finished.

Repro steps:

1. Update flame device to 20150902030203.
2. Open contacts, add new contact, and fill in all the fields.
3. Tap done to save contact.

Actual Result:
Contact is not saved.

Expected Result:
Contact is successfully saved.

Environmental Variables:
Device: Flame 2.5
BuildID: 20150902030203
Gaia: b75979ec8862bd5799a7c42e938d3f67be38d6ae
Gecko: fb720c90eb49590ba55bf52a8a4826ffff9f528b
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Repro Rate: 3/5 via adhoc tests, not reproduced manually.

Comment 1

[Nicholas Nelson [:NicholasN]]

Traceback (most recent call last):
File "/var/lib/jenkins/jobs/flame-kk.ui.adhoc.bitbar/workspace/.env/lib/python2.7/site-packages/marionette_client-0.17-py2.7.egg/marionette/marionette_test.py", line 296, in run
testMethod()
File "/var/lib/jenkins/jobs/flame-kk.ui.adhoc.bitbar/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_add_new_contact.py", line 40, in test_add_new_contact
self.assertEqual(contacts_app.contacts[0].name, self.contact['givenName'])
AssertionError: u'' != 'gaia274108'

Comment 2

[Martijn Wargers (dead)]

This looks like a real bug to me, somehow triggered by automation.
What I see happening is that the contacts is not shown after it's saved, but afterwards, when you close and reopen the contacts app, the contact does appear.

Comment 3

[Martijn Wargers (dead)]

I can see the contact item in the list, but it's invisible and instead the "No contacts" thing is shown when this bug occurs:
<li data-cache="true" data-order="GAIA899351TEST" data-search="gaia899351 test 55513899351" data-rendered="true" data-updated="1441193000254" class="contact-item" data-group="G" role="option" data-uuid="d7eb17f14ffc43fe8f24010e482b8171"><aside class="pack-end" aria-hidden="true"><span data-group="G" style="background-position: left center;" data-background-position="" data-type="img"></span></aside><label class="contact-checkbox pack-checkbox"><input value="d7eb17f14ffc43fe8f24010e482b8171" name="selectIds[]" type="checkbox"><span></span></label><p class="contact-text"><bdi><strong>gaia899351</strong> test</bdi></p></li>

Comment 4

[Martijn Wargers (dead)]

Fernando, could this be a regression from bug 1198180?

Comment 5

[Martijn Wargers (dead)]

I suspect that bug 1197750 could fix this perhaps.

Comment 6

[Martijn Wargers (dead)]

Ok, not fixed by bug 1197750.

I can stil reproduce, using:
Build ID               20150905150219
Gaia Revision          03be7d8918bed58c92a40bba211bbbc97a0e516a
Gaia Date              2015-09-04 11:56:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/139446daedab3d00b9f0faba25e1e82191c8c8d1
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150727.063909
Firmware Date          Mon Jul 27 06:39:20 EDT 2015
Bootloader             L1TC000118D0

Comment 7

[Martijn Wargers (dead)]

Perhaps this is a regression from bug 1183727 somehow?

Comment 8

[Borja Salguero [:borjasalguero]]

Could you try with latests version of master? This is supposed to be fixed with https://bugzilla.mozilla.org/show_bug.cgi?id=1197750. Thanks!

Comment 9

[Martijn Wargers (dead)]

(In reply to Borja Salguero [:borjasalguero] from comment #8)
> Could you try with latests version of master? This is supposed to be fixed
> with https://bugzilla.mozilla.org/show_bug.cgi?id=1197750. Thanks!

Yes, that's what I thought too, that it would be fixed with bug 1197750, but it's still happening with:
Build ID               20150910030223
Gaia Revision          47459eead04385e22f967012b824f5abdddcfb7c
Gaia Date              2015-09-09 10:37:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dd2a1d737a64d9a3f23714ec5cc623ec8933b51f
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150906.183003
Firmware Date          Sun Sep  6 18:30:19 EDT 2015
Bootloader             L1TC000118D0

Comment 10

[Pi Wei Cheng [:piwei] (inactive)]

I'll try to get the window here. I believe comment 9 answered the question so removing NI.

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1201211 > mozilla-b2g:master

Comment 12

[Martijn Wargers (dead)]

Comment on attachment 8659592 [details] [review]
[gaia] mwargers:1201211 > mozilla-b2g:master

This makes the test pass. As you can see, it's a workaround, but I'm fine with it to get this test working again.

Perhaps this also gives a clue on how to fix this really?

Comment 13

[Pi Wei Cheng [:piwei] (inactive)]

Uh, window-wanted tag was removed but since I got the central window I might as well post it here in case anyone's curious what might have caused it.

Last Working
Device: Flame
BuildID: 20150819170238
Gaia: 89e0096a3de0378e3eda77e6a2a0bb5ca03eb8bb
Gecko: 0d5a08e1619be257cfe9fbda2024011cfca691f8
Version: 43.0a1 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

First Broken
Device: Flame
BuildID: 20150820122238
Gaia: c6705f739fb605031eb2a0b943ba55c64bee5a03
Gecko: 6c9cd390c157040b28ed8e4b8509f72ee5c14e2b
Version: 43.0a1
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/89e0096a3de0378e3eda77e6a2a0bb5ca03eb8bb...c6705f739fb605031eb2a0b943ba55c64bee5a03

Gecko pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0d5a08e1619be257cfe9fbda2024011cfca691f8&tochange=6c9cd390c157040b28ed8e4b8509f72ee5c14e2b

Comment 14

[Martijn Wargers (dead)]

Sorry, a regression-window didn't seem so necessary anymore, because there is a workaround and this bug can only be reproduced in automation anyway.
I don't see anything in the regression window that most definitely would have caused it.

Comment 15

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8659592 [details] [review]
[gaia] mwargers:1201211 > mozilla-b2g:master

I'm okay with this temporary workaround, while we find the fix. I don't know on which event we could wait to make sure the contact app is loaded fully.

Comment 16

[Maria Angeles Oteo (:oteo)]

Assigning to Martijn, as it seems he has already provided a patch/workaround. Thanks a lot!

Comment 17

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/cb1fbc82310c37beaab31aeb4e1c2a2e237dc72d

I'm leaving this open, because I think there is a real app issue here, although I guess this is not something that normal users will encounter.

Comment 18

[Martijn Wargers (dead)]

I've moved the workaround in contacts app.py, because it then also fixes automatically bug 1201281.

Comment 19

[Borja Salguero [:borjasalguero]]

Francisco, I think this one must be fixed after last changes in Contacts. Could you confirm it?

Comment 20

[Martijn Wargers (dead)]

You mean the changes in bug 1183727?

Comment 21

[Francisco Jordano [:arcturus] [:francisco]]

I think Borja comments that we backed out the code on bug 1183727, hence, we expect the problem is no longer existing.

Comment 22

[Martijn Wargers (dead)]

Francisco, I just tried again with the time.sleep() call removed, but then I get failures again, so I can't remove the workaround. So this is still an issue.

Comment 23

[Francisco Jordano [:arcturus] [:francisco]]

:mwargers, then we need to fix it :(

Comment 24

[Martijn Wargers (dead)]

Not working on this anymore. It seems to me that bugs related to Gaia UI tests can all be closed, since they aren't being run anymore, afaik.

Comment 25

[BMO Automation]

Firefox OS is not being worked on