1203513 - No such file libgtk-3.so.0 in Emulator build

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[John Dai[:jdai]]

According to bug 1146713 comment 118, we got an error show /builds/slave/b2g_try_emu_dep-00000000000000/build/gaia/b2g_sdk/43.0a1-2015-08-17-15-02-06/b2g/xpcshell: error while loading shared libraries: libgtk-3.so.0: cannot open shared object file: No such file or directory in buildbot Emulator ICS build.

Comment 1

[John Dai[:jdai]]

Attachment: Add LD_LIBRARY_PATH in ICS Emulator build script.

I applied Bug 1203144 and Bug 1146713 patches to verify ICS emulator build is work.
Try link:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a03487a48b35

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8659240 [details] [diff] [review]
Add LD_LIBRARY_PATH in ICS Emulator build script.

Review of attachment 8659240 [details] [diff] [review]:
-----------------------------------------------------------------

I like this patch a lot better than the one in bug 1203460 :)  Do they accomplish the same thing?

Comment 3

[Ricky Chien [:rickychien] (inactive)]

John, I think we're doing same as dustin said. Look into emulator-kk log, LD_LIBRARY_PATH is already exported correctly along with gtk3. So we should close bug 1203460 if there are no other concerns :)

Comment 4

[Greg Arndt [:garndt]]

Comment on attachment 8659240 [details] [diff] [review]
Add LD_LIBRARY_PATH in ICS Emulator build script.

I'm not as familiar with mozharness, but this seems to accomplish what you're looking for.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Please ignore comment 3

Comment 6

[John Dai[:jdai]]

(In reply to Dustin J. Mitchell [:dustin] from comment #2)
> Comment on attachment 8659240 [details] [diff] [review]
> Add LD_LIBRARY_PATH in ICS Emulator build script.
> 
> Review of attachment 8659240 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I like this patch a lot better than the one in bug 1203460 :)  Do they
> accomplish the same thing?

Yes, they are trying to accomplish the same thing. I will merge them into one patch. Thanks for your suggestion.

Comment 8

[John Dai[:jdai]]

Attachment: Add LD_LIBRARY_PATH in Emulator build script. v2

Try link:
https://treeherder.allizom.org/#/jobs?repo=try&revision=68a25b0265eb

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8659788 [details] [diff] [review]
Add LD_LIBRARY_PATH in Emulator build script. v2

Review of attachment 8659788 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozharness/scripts/b2g_build.py
@@ +539,5 @@
>                  cmd.append('-j{0}'.format(multiprocessing.cpu_count()))
>              cmd.append(target)
>          return cmd
>  
> +    def link_gtk3(self):

It might be worth calling this "symlink_gtk3" -- we're talking about linker configuration, so "link" is ambiguous.

Comment 10

[John Dai[:jdai]]

Attachment: Add LD_LIBRARY_PATH in Emulator build script. r=dustin

Address comment 9.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d60ded826635

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d60ded826635

Comment 13

[Julien Wajsberg [:julienw]]

Hey,

I don't follow why we're not simply forwarding LD_LIBRARY_PATH ? I see the patch also tries to find another path for gtk3, but indeed it should already be in LD_LIBRARY_PATH set by the tooltool tool, right ?

Comment 14

[Dustin J. Mitchell [:dustin] (he/him)]

tooltool doesn't set LD_LIBRARY_PATH.  Tooltool is a tool for downloading (and unpacking) tarballs.

Comment 15

[Ricky Chien [:rickychien] (inactive)]

That case is a little bit different since we found that there are three kinds of machine envs.

env LD_LIBRARY_PATH=/tools/gcc-4.7.3-0moz1/lib64:/tools/gcc-4.7.3-0moz1/lib

it's hardcoded inside dockerfile for taskcluster machine (b2g-desktop, emulator-kk, emulator-jb and emaulator-l...etc. However, we're still use old machine for emulator-ics.

So instead of hardcode it in dockerfile, the final solution was that set LD_LIBRARY_PATH in testing/mozharness/scripts/b2g_build.py