120616 - [PATCH]Scaling in print preview shouldn't scale the scrollbars

Status: VERIFIED FIXED

(Core :: Print Preview, defect)

Description

[Samir Gehani]

Steps to reproduce:
-------------------
(1) Navigate to a long page.
(2) Preview the page: ``File | Print Preview''.  
    Notice that  the scrollbars are normal size.
(3) Reload the page to exit preview mode.
(4) Open the page setup dialog: ``File | Page Setup...''.
(5) Set the scale to say 50.
(6) Preview the document again: ``File | Preview''.

Actual results:
---------------
The scrollbars have scaled to 50% width along with the contents of the page
(affects both horizontal and vertical scrollbars).

Expected results:
-----------------
The scrollbars should remain normal size and not scale with the document contents.

Comment 1

[rods (gone)]

Don, we talked about this. I will assign this to you for now. You said you would
take a look at this.

Comment 2

[Samir Gehani]

I think Rod meant to reassign.

Comment 3

[Kevin McCluskey (gone)]

Changing severity form minor to normal. This is a very visible defect for anyone
using scaling.

Comment 4

[Kevin McCluskey (gone)]

Marking nsbeta1+

Comment 5

[Kevin McCluskey (gone)]

Really marking nsbeta1+ this time.

Comment 6

[Samir Gehani]

*** Bug 126809 has been marked as a duplicate of this bug. ***

Comment 7

[Andrew Hagen]

Changing component from printing to print preview.

Comment 8

[Kevin McCluskey (gone)]

Moving to 1.0 this is not a stopper for 0.9.9

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 129309 has been marked as a duplicate of this bug. ***

Comment 10

[sujay]

cc: jimmylee, he sees this also...

Comment 11

[jlarsen]

I also noticed something strange after significantly scalling the page, and
grabbitn the scroll bar and putting it all the way to the bottom and dropping it
there. When you goto pick it back up you have the move the mouse for a good
distance before it starts to move the scroll bar back up.

Comment 12

[rods (gone)]

taking

Comment 13

[rods (gone)]

Attachment: patch

Overview
There are several problems when trying to scale the UI and document 
scrollbars differently:
1) They currently share the same style context resolution
2) It can be difficult to determine whether you are creating/reflowing a UI or 

   doc scrollbar (SB)
3) They share the same PresContext which has a single scale value that UI SBs
   need to ignore, but the doc SBs need to use.

This patch does the following:
1) Enables the PrintPreviewContext to turn on and of the scaling of twips
2) When creating a new scrollbar, it checks to see if the frame parent is 
   is a viewportframe that way it knows if it is in the UI or in the document
   then for UI scrollbars it turns off the saling, and for doc scrollbars it 
   turns it on. This needs to be done at creation time as well as, reflow 
   because it GetScaledPixelsToTwips get called during both.
3) The nsSimpleSequenceFrame turns on scaling during its children reflow
   then turns it off.
4) When PrintPreview "setup" is done it turns off the scaling in the 
   PrintPreviewContext because any reflowing other usages for
   GetScaledPixelsToTwips will be for UI scrollbars
5) A copy of all the style rules for scrollbars is made and placed inside of 
   a media type "print" This way the style resultion for the scaled scrollbars 

   in the document are not shared with the UI.

Comment 14

[Syd Logan]

adt3 per adt triage

Comment 15

[Kevin McCluskey (gone)]

I disagree with the [adt3] marking. I'm bumping it up to [adt2]. This bug is
*very visible* to a large number of users. Every person who uses print preview
will notice this bug, since it affects the scrollbar and it has a negative
impact on the perceived quality of print preview.

Comment 16

[R.K.Aa.]

in bug 137897 reporter writes "Scrollbar keps halving (sp?) it's own width until
it is 1 pixel wide, then Mozilla crashes" (TB5285847Z)

Comment 17

[rods (gone)]

Attachment: patch

This patch is the same as the previous one except that it sets the DC's
CanonicalPixelScale back to it's orignal value.

Comment 18

[dcone (gone)]

Comment on attachment 80065 [details] [diff] [review]
patch

r=dcone

Comment 19

[R.K.Aa.]

*** Bug 138722 has been marked as a duplicate of this bug. ***

Comment 20

[rods (gone)]

Attachment: patch with gfx changes

We need to have the native scrollbars scale also (for listboxes)

Comment 21

[dcone (gone)]

Comment on attachment 80238 [details] [diff] [review]
patch with gfx changes

r=dcone

Comment 22

[Marc Attinasi]

Comment on attachment 80238 [details] [diff] [review]
patch with gfx changes

sr=attinasi

Comment 23

[rods (gone)]

fixed

Comment 24

[sujay]

verified in 4/24 trunk build.

Comment 25

[Scott Collins]

Comment on attachment 80238 [details] [diff] [review]
patch with gfx changes

a=scc (on behalf of drivers) for checkin to the mozilla 1.0 branch

Comment 26

[Jaime Rodriguez, Jr.]

Let's get this one in, right after we certify for MachV beta adt1.0.0-/[adt2 rtm].

Comment 27

[Gustav]

*** Bug 137085 has been marked as a duplicate of this bug. ***

Comment 28

[R.K.Aa.]

*** Bug 140699 has been marked as a duplicate of this bug. ***

Comment 29

[R.K.Aa.]

*** Bug 142859 has been marked as a duplicate of this bug. ***

Comment 30

[scottputterman]

adding adt1.0.0+.  Please get drivers approval since the previous approval is
more than 3 days old and then checkin to the 1.0 branch.

Comment 31

[R.K.Aa.]

*** Bug 144497 has been marked as a duplicate of this bug. ***

Comment 32

[chris hofmann]

re-a=chofmann for the 1.0 branch.

Comment 33

[sujay]

verified in 5/17 branch build.

Comment 34

[Pete Boyd]

*** Bug 145990 has been marked as a duplicate of this bug. ***

Comment 35

[Bill Mason]

*** Bug 137897 has been marked as a duplicate of this bug. ***