Closed
Bug 120616
Opened 22 years ago
Closed 22 years ago
[PATCH]Scaling in print preview shouldn't scale the scrollbars
Categories
(Core :: Print Preview, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.0
People
(Reporter: samir_bugzilla, Assigned: rods)
References
Details
(Whiteboard: [adt2 RTM])
Attachments
(1 file, 2 obsolete files)
23.67 KB,
patch
|
dcone
:
review+
attinasi
:
superreview+
scc
:
approval+
|
Details | Diff | Splinter Review |
Steps to reproduce: ------------------- (1) Navigate to a long page. (2) Preview the page: ``File | Print Preview''. Notice that the scrollbars are normal size. (3) Reload the page to exit preview mode. (4) Open the page setup dialog: ``File | Page Setup...''. (5) Set the scale to say 50. (6) Preview the document again: ``File | Preview''. Actual results: --------------- The scrollbars have scaled to 50% width along with the contents of the page (affects both horizontal and vertical scrollbars). Expected results: ----------------- The scrollbars should remain normal size and not scale with the document contents.
Assignee | ||
Comment 1•22 years ago
|
||
Don, we talked about this. I will assign this to you for now. You said you would take a look at this.
Target Milestone: --- → mozilla0.9.9
Comment 3•22 years ago
|
||
Changing severity form minor to normal. This is a very visible defect for anyone using scaling.
Severity: minor → normal
Comment 4•22 years ago
|
||
Marking nsbeta1+
Reporter | ||
Comment 6•22 years ago
|
||
*** Bug 126809 has been marked as a duplicate of this bug. ***
Comment 7•22 years ago
|
||
Changing component from printing to print preview.
Component: Printing → Print Preview
Comment 8•22 years ago
|
||
Moving to 1.0 this is not a stopper for 0.9.9
Target Milestone: mozilla0.9.9 → mozilla1.0
![]() |
||
Comment 9•22 years ago
|
||
*** Bug 129309 has been marked as a duplicate of this bug. ***
Comment 10•22 years ago
|
||
cc: jimmylee, he sees this also...
Comment 11•22 years ago
|
||
I also noticed something strange after significantly scalling the page, and grabbitn the scroll bar and putting it all the way to the bottom and dropping it there. When you goto pick it back up you have the move the mouse for a good distance before it starts to move the scroll bar back up.
Assignee | ||
Comment 13•22 years ago
|
||
Overview There are several problems when trying to scale the UI and document scrollbars differently: 1) They currently share the same style context resolution 2) It can be difficult to determine whether you are creating/reflowing a UI or doc scrollbar (SB) 3) They share the same PresContext which has a single scale value that UI SBs need to ignore, but the doc SBs need to use. This patch does the following: 1) Enables the PrintPreviewContext to turn on and of the scaling of twips 2) When creating a new scrollbar, it checks to see if the frame parent is is a viewportframe that way it knows if it is in the UI or in the document then for UI scrollbars it turns off the saling, and for doc scrollbars it turns it on. This needs to be done at creation time as well as, reflow because it GetScaledPixelsToTwips get called during both. 3) The nsSimpleSequenceFrame turns on scaling during its children reflow then turns it off. 4) When PrintPreview "setup" is done it turns off the scaling in the PrintPreviewContext because any reflowing other usages for GetScaledPixelsToTwips will be for UI scrollbars 5) A copy of all the style rules for scrollbars is made and placed inside of a media type "print" This way the style resultion for the scaled scrollbars in the document are not shared with the UI.
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Keywords: review
Summary: Scaling in print preview shouldn't scale the scrollbars → [FIX]Scaling in print preview shouldn't scale the scrollbars
Assignee | ||
Updated•22 years ago
|
Summary: [FIX]Scaling in print preview shouldn't scale the scrollbars → [PARTIAL-FIX]Scaling in print preview shouldn't scale the scrollbars
Updated•22 years ago
|
Summary: [PARTIAL-FIX]Scaling in print preview shouldn't scale the scrollbars → [PATCH][PARTIAL-FIX]Scaling in print preview shouldn't scale the scrollbars
Comment 15•22 years ago
|
||
I disagree with the [adt3] marking. I'm bumping it up to [adt2]. This bug is *very visible* to a large number of users. Every person who uses print preview will notice this bug, since it affects the scrollbar and it has a negative impact on the perceived quality of print preview.
Whiteboard: [adt3] → [adt2]
Comment 16•22 years ago
|
||
in bug 137897 reporter writes "Scrollbar keps halving (sp?) it's own width until it is 1 pixel wide, then Mozilla crashes" (TB5285847Z)
Assignee | ||
Comment 17•22 years ago
|
||
This patch is the same as the previous one except that it sets the DC's CanonicalPixelScale back to it's orignal value.
Attachment #74722 -
Attachment is obsolete: true
Comment 18•22 years ago
|
||
Comment on attachment 80065 [details] [diff] [review] patch r=dcone
Attachment #80065 -
Flags: review+
Assignee | ||
Updated•22 years ago
|
Summary: [PATCH][PARTIAL-FIX]Scaling in print preview shouldn't scale the scrollbars → [PATCH]Scaling in print preview shouldn't scale the scrollbars
Comment 19•22 years ago
|
||
*** Bug 138722 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 20•22 years ago
|
||
We need to have the native scrollbars scale also (for listboxes)
Attachment #80065 -
Attachment is obsolete: true
Updated•22 years ago
|
Attachment #80238 -
Flags: review+
Comment 21•22 years ago
|
||
Comment on attachment 80238 [details] [diff] [review] patch with gfx changes r=dcone
Comment 22•22 years ago
|
||
Comment on attachment 80238 [details] [diff] [review] patch with gfx changes sr=attinasi
Attachment #80238 -
Flags: superreview+
Assignee | ||
Comment 23•22 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 25•22 years ago
|
||
Comment on attachment 80238 [details] [diff] [review] patch with gfx changes a=scc (on behalf of drivers) for checkin to the mozilla 1.0 branch
Attachment #80238 -
Flags: approval+
Comment 26•22 years ago
|
||
Let's get this one in, right after we certify for MachV beta adt1.0.0-/[adt2 rtm].
Comment 27•22 years ago
|
||
*** Bug 137085 has been marked as a duplicate of this bug. ***
Comment 28•22 years ago
|
||
*** Bug 140699 has been marked as a duplicate of this bug. ***
Comment 29•22 years ago
|
||
*** Bug 142859 has been marked as a duplicate of this bug. ***
Comment 30•22 years ago
|
||
adding adt1.0.0+. Please get drivers approval since the previous approval is more than 3 days old and then checkin to the 1.0 branch.
Comment 31•22 years ago
|
||
*** Bug 144497 has been marked as a duplicate of this bug. ***
Comment 32•22 years ago
|
||
re-a=chofmann for the 1.0 branch.
Assignee | ||
Updated•22 years ago
|
Keywords: fixed1.0.0
Comment 34•22 years ago
|
||
*** Bug 145990 has been marked as a duplicate of this bug. ***
Comment 35•22 years ago
|
||
*** Bug 137897 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•