1207422 - Remove Apps link from about:home

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Wil Clouser [:clouserw]]

If you load about:home you'll see an Apps link going to marketplace.firefox.com.  Please remove that link.  Thanks.

Comment 1

[Wil Clouser [:clouserw]]

These three bugs are friends:  bug 1207422, bug 1207423, bug 1207424

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Not yet tested (had to clobber), but seems trivial enough that I'm already requesting review.

Comment 3

[:Gijs (he/him)]

Comment on attachment 8704553 [details] [diff] [review]
patch

Review of attachment 8704553 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Also, interesting that this never had any tests...

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/861971c670e1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/861971c670e1

Comment 7

[Dão Gottwald [:dao]]

Attachment: patch for uplift

This is without they string removal since we don't need that for uplift.

Approval Request Comment
[Feature/regressing bug #]: deprecation of marketplace.firefox.com for desktop
[User impact if declined]: marketplace.firefox.com is being advertised when we don't want that
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: straightforward code removal, no risk
[String/UUID change made/needed]:

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Dao, could you please fill out the test coverage section? Without that I cannot take this to Beta.

Comment 9

[Dão Gottwald [:dao]]

This is a feature removal. There's no test coverage.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to Dão Gottwald [:dao] from comment #9)
> This is a feature removal. There's no test coverage.

Thanks Dao! Did you get a chance to manually verify that your patch works as expected? In most cases that is assumed but given that 44 release is at risk, I have to ask you that explicitly rather than assuming it.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8705093 [details] [diff] [review]
patch for uplift

Taking this fix as I consider this critical to get our story right given the recent changes to FxOS. Beta44+, Aurora45+

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Requesting QE team to do focused testing on all three bugs that were uplifted this week to remove apps from toolbar and about:home.

Comment 13

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c40fffa43126

Comment 14

[Dão Gottwald [:dao]]

(In reply to Ritu Kothari (:ritu) from comment #10)
> (In reply to Dão Gottwald [:dao] from comment #9)
> > This is a feature removal. There's no test coverage.
> 
> Thanks Dao! Did you get a chance to manually verify that your patch works as
> expected? In most cases that is assumed but given that 44 release is at
> risk, I have to ask you that explicitly rather than assuming it.

yeah.

https://hg.mozilla.org/releases/mozilla-beta/rev/7734ce11e073

Comment 15

[Petruta Horea [:phorea]]

Verified as fixed using Firefox 44 beta 8, latest Aurora 45.0a2 and latest Nightly 46.0a1 2015-01-12 under Win 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.10.5.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/7734ce11e073