1207485 - [Input mgmt] Switch from mozChromeEvent/mozContentEvent to API methods

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

See bug 1201407.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] timdream:input-mgmt-chrome-event > mozilla-b2g:master

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8664767 [details] [review]
[gaia] timdream:input-mgmt-chrome-event > mozilla-b2g:master

Alberto,

Would you mind review one more patch related to this work? This patch grep the System app and transform the event listeners and the internal/external events into proper named events. There is one little syntax change at |evt.detail.choices| for <select> elements -- we no longer flatten that into a JSON string when sending that from Gecko to System.

Event now expects preventDefault() to be called when the request event is handled too.

I've changed TrustedUiValueSelector too but I suspect no one is actually using it. We can deal with it in bug 1210715.

Thanks!

Comment 3

[Alberto Pastor [:albertopq]]

Comment on attachment 8664767 [details] [review]
[gaia] timdream:input-mgmt-chrome-event > mozilla-b2g:master

I'm not too familiar with this code, but the changes make sense to me, and the tests are happy, so am I then :)

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] timdream:input-mgmt-chrome-event2 > mozilla-b2g:master

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/043b7c9231335e2257588005ab9c13dcdb7fc3c4

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v2.5 revert due to bug 1222245:

https://github.com/timdream/gaia/commit/cf646c52bb947af28329b0a100df91d1b1f2a907