Closed Bug 1207485 Opened 5 years ago Closed 4 years ago

[Input mgmt] Switch from mozChromeEvent/mozContentEvent to API methods

Categories

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(b2g-v2.5 wontfix, b2g-master fixed)

RESOLVED FIXED
Tracking Status
b2g-v2.5 --- wontfix
b2g-master --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

Details

Attachments

(2 files)

Comment on attachment 8664767 [details] [review]
[gaia] timdream:input-mgmt-chrome-event > mozilla-b2g:master

Alberto,

Would you mind review one more patch related to this work? This patch grep the System app and transform the event listeners and the internal/external events into proper named events. There is one little syntax change at |evt.detail.choices| for <select> elements -- we no longer flatten that into a JSON string when sending that from Gecko to System.

Event now expects preventDefault() to be called when the request event is handled too.

I've changed TrustedUiValueSelector too but I suspect no one is actually using it. We can deal with it in bug 1210715.

Thanks!
Attachment #8664767 - Flags: review?(apastor)
Comment on attachment 8664767 [details] [review]
[gaia] timdream:input-mgmt-chrome-event > mozilla-b2g:master

I'm not too familiar with this code, but the changes make sense to me, and the tests are happy, so am I then :)
Attachment #8664767 - Flags: review?(apastor) → review+
master: https://github.com/mozilla-b2g/gaia/commit/043b7c9231335e2257588005ab9c13dcdb7fc3c4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1227354
You need to log in before you can comment on or make changes to this bug.