1210086 - using bookmarks toolbar spews many warnings about "unsupported/unknown widget type" and seems slow and badly formatted

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[David A. Madore]

Using a freshly compiled Firefox 42.0b2 (compiled from http://hg.mozilla.org/releases/mozilla-beta/rev/cab2bec68d53 on Debian GNU/Linux 8.2 (stable/jessie) x86_64 with a new blank profile and no addons installed:

If the bookmarks toolbar is displayed, every time the mouse is moved over it or every time it is interacted with in any way, Firefox displays tons of warnings like:

** (firefox:17877): WARNING **: Unsupported widget type: 1

** (firefox:17877): WARNING **: Unknown widget type: 1

(the number always seems to be 1 but the adjective is randomly "unknown" or "unsupported").

This did not occur with Firefox 41.

This is fairly minor because the toolbar still seems to work well.  However, it seems slow in comparison to previous version, and the spacing between bookmarks is visibly wrong (reduced to zero).

In case this is relevant, the version of Gtk+ involved (from Debian stable) is libgtk2.0-0 version 2.24.25-3.

Comment 1

[:Gijs (away/busy until Mar 10)]

Did you manually configure this to use gtk2 instead of gtk3? Does this happen on an official mozilla build?

Comment 2

[:Gijs (away/busy until Mar 10)]

(can you do a before/after screenshot of the buttons you're talking about?)

Comment 3

[jmb74]

Attachment: Lack of padding between personal toolbar bookmark items

Same here on both official mozilla builds, and ubuntu firefox-next ppa ones.

Screenshot attached

Presumably fallout from reverting back to gtk2 for beta for the time being?

http://hg.mozilla.org/releases/mozilla-beta/rev/2ad882095986

Perhaps related to fix for this in gtk3? 

https://bugzilla.mozilla.org/show_bug.cgi?id=1160154

Comment 4

[:Gijs (away/busy until Mar 10)]

(In reply to johnmbryant from comment #3)
> Created attachment 8668062 [details]
> Lack of padding between personal toolbar bookmark items
> 
> Same here on both official mozilla builds, and ubuntu firefox-next ppa ones.
> 
> Screenshot attached
> 
> Presumably fallout from reverting back to gtk2 for beta for the time being?
> 
> http://hg.mozilla.org/releases/mozilla-beta/rev/2ad882095986
> 
> Perhaps related to fix for this in gtk3? 
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=1160154

That sounds likely. Should we back that out of beta? Martin?

Comment 5

[David A. Madore]

* The same occurs with the official build of Firefox 42.0b2 - no difference with my home build as far as I can tell.

* I don't remember doing anything special to use Gtk2 instead of Gtk3.  According to about:buildconfig the configure arguments I used were "--enable-application=browser --prefix=/opt/firefox-42.0b2 '--enable-optimize=-march=nocona -O3' --enable-official-branding --enable-startup-notification --disable-tests --disable-mochitest"

* I do have the libgtk-3-0 and libgtk-3-dev packages installed.

* Screenshots are here:
<URL: http://www.madore.org/~david/.tmp/bug1210086-firefox-41-screenshot.png >
<URL: http://www.madore.org/~david/.tmp/bug1210086-firefox-42-screenshot.png >
(taken with a blank profile - all I did was enable the bookmarks toolbar and add one bookmark there for visibility).  The first has correct spacing, the second (taken with the official 42.0b2 build) does not.

Comment 6

[Karl Tomlinson (:karlt)]

Need a couple of "case MOZ_GTK_TOOLBAR_BUTTON:" labels in gtk2drawing.h

Comment 7

[Karl Tomlinson (:karlt)]

Need a couple of "case MOZ_GTK_TOOLBAR_BUTTON:" labels in gtk2drawing.c

Comment 8

[Karl Tomlinson (:karlt)]

[Tracking Requested - why for this release]:
Recent regression.

Comment 9

[Petr Jašíček]

Attachment: 001_gtk2_toolbar_compat.patch

Added missing MOZ_GTK_TOOLBAR_BUTTON cases in gtk2drawing.c

try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bc884b96b9f

Comment 10

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

(In reply to :Gijs Kruitbosch from comment #4)
> That sounds likely. Should we back that out of beta? Martin?

No need to back out, this patch should fix it.

Comment 11

[Karl Tomlinson (:karlt)]

Comment on attachment 8668377 [details] [diff] [review]
001_gtk2_toolbar_compat.patch

Thanks!

Comment 13

[Sylvestre Ledru [:Sylvestre]]

visual regression, tracking.

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/36cd98d7f222

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/36cd98d7f222

Comment 17

[jmb74]

Issue with no spacing between bookmark toolbar items still present in 42 beta 4. Fix needs to be applied to that, as at present that is the only release channel being built for GTK2 by default, and so shows up the bug in mozilla releases.

Comment 18

[jmb74]

Attachment: no spacing in 42b4

Comment 19

[:Gijs (away/busy until Mar 10)]

Petr or Karl, can you please request uplift on this patch assuming we're happy with baking etc.?

Comment 20

[Petr Jašíček]

Comment on attachment 8668377 [details] [diff] [review]
001_gtk2_toolbar_compat.patch

[Feature/regressing bug #]:
[User impact if declined]: Toolbar buttons zero space between them

Steps to reproduce:

1) Launch firefox from console
2) Warnings are displayed: ** (firefox:17877): WARNING **: Unsupported widget type: 1
3) Toolbar buttons have no spaces between them

[Describe test coverage new/current, TBPL]: Manual testing

TreeHerder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bc884b96b9f

[Risks and why]: Low, added a new widget which affects only drawing of toolbar buttons
[String/UUID change made/needed]: none

Comment 22

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8668377 [details] [diff] [review]
001_gtk2_toolbar_compat.patch

Remove a warning, taking it. Should be in 42 beta 5.

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8b99dcd48e69

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4a2f3b0849b5

Comment 25

[Sylvestre Ledru [:Sylvestre]]

Confirmed fixed in 42 beta 5.
Thanks!