1210731 - (Gaia RTL 2.5) CSS refactoring: SMS app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Augustin Trancart [:autra]]

This bug is for the CSS refactoring of the SMS application, following the new guidelines.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1210731-sms-rtl_refactoring > mozilla-b2g:master

Comment 2

[Augustin Trancart [:autra]]

Comment on attachment 8673118 [details] [review]
[gaia] Phoxygen:bug1210731-sms-rtl_refactoring > mozilla-b2g:master

Hey Julien, please r? this CSS refactoring for SMS.

On overall, apart from the refactoring, there wasn't a lot of things to fix. Pretty clean!

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8673118 [details] [review]
[gaia] Phoxygen:bug1210731-sms-rtl_refactoring > mozilla-b2g:master

This is really a great job, I couldn't find a lot of issues.

More information on github.

Please put your changes in a separate commit before asking another review !
Thanks again :)

Comment 4

[Augustin Trancart [:autra]]

Comment on attachment 8673118 [details] [review]
[gaia] Phoxygen:bug1210731-sms-rtl_refactoring > mozilla-b2g:master

Hey Julien, 

PR updated, please R? :-)

Comment 5

[Julien Wajsberg [:julienw]]

Comment on attachment 8673118 [details] [review]
[gaia] Phoxygen:bug1210731-sms-rtl_refactoring > mozilla-b2g:master

r=me
let's land this.

Can you file a separate bug to investigate where we can use margin-inline-end/margin-inline-start instead of selecting parent's rtl mode ?

Comment 6

[Augustin Trancart [:autra]]

Thanks ! Investigating that now.

Comment 7

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/2489eb702cb79e3dc5ce0c7b0d085d0d1b4c6426