Closed Bug 1210815 Opened 4 years ago Closed 4 years ago

Disable v2 data upload in Firefox 43+

Categories

(Toolkit :: Telemetry, defect, P1)

defect
Points:
1

Tracking

()

VERIFIED FIXED
mozilla45
Tracking Status
firefox41 --- wontfix
firefox42 --- wontfix
firefox43 --- verified
firefox44 --- verified
firefox45 --- verified
b2g-v2.5 --- fixed

People

(Reporter: Dexter, Assigned: Dexter)

References

Details

(Whiteboard: [measurement:client])

Attachments

(1 file)

Bug 1208376 landed the code to disable FHR v2 submission by flipping the "datareporting.policy.dataSubmissionEnabled.v2".

This bug is about flipping the preference to disable FHR v2 data submission.
Blocks: 1122482
Points: --- → 1
Depends on: 1208376
Priority: -- → P1
Whiteboard: [unifiedTelemetry][measurement:client]
Summary: Disable v2 data upload in Firefox 42+ → Disable v2 data upload in Firefox 43+
When do we want to disable v2 data upload in 43 (and go to further steps like bug 1209088 for 44+)?

Is the current plan to wait on Metrics & others to approve the 100% v2 & 100% v4 behavior on 42 release first?
Or could we go ahead with these steps?
Flags: needinfo?(thuelbert)
Flags: needinfo?(kparlante)
I'm going to defer to Katie on this one, but my feeling is its too early to do this yet and we should wait for validation/continuity project to end.
Flags: needinfo?(thuelbert)
Flags: needinfo?(kparlante)
Priority: P1 → P3
Priority: P3 → P1
Whiteboard: [unifiedTelemetry][measurement:client] → [measurement:client]
Attached patch bug1210815.patchSplinter Review
I've manually tested this:

- v4 still works, pings are still being submitted.
- v2 is not sending anything. Enabling the log results in "Services.DataReporting.Policy   DEBUG   Data submission is disabled. Doing nothing." prints.
- No crashes on shutdown or hangs happened locally.
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Attachment #8690027 - Flags: review?(gfritzsche)
Comment on attachment 8690027 [details] [diff] [review]
bug1210815.patch

Review of attachment 8690027 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but lets not land this yet.
Attachment #8690027 - Flags: review?(gfritzsche) → review+
Katie, please let us know when we can land this on Nightly and if/when we should go to Beta.
Flags: needinfo?(kparlante)
We have the go ahead. We can land this on Nightly now, and we should go to Beta as soon as is practical.
Flags: needinfo?(kparlante)
https://hg.mozilla.org/mozilla-central/rev/0bfe3ec74b60
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Alexandra, can you have a look over this?
Flags: needinfo?(alexandra.lucinet)
QA Contact: alexandra.lucinet
Comment on attachment 8690027 [details] [diff] [review]
bug1210815.patch

Background:
We already have Unified Telemetry collecting 100% of the release population data in Firefox 42.
Now we have a go decision for turning off the old FHR reporting and can stop duplicating data upload / storage / infrastructure.
For risk migitation we already implemented a pref a while ago to just disable the old FHRs data upload (bug 1208376); now we are just flipping it.

Approval Request Comment
[Feature/regressing bug #]: Switching off old FHR upload in favor of Unified Telemetry
[User impact if declined]: Duplicated client data uploads as well as storage & infrastructure maintenance budget costs.
[Describe test coverage new/current, TreeHerder]: We are fairly confident in uplifting this - QA has been done on bug 1208376, this just flips the pref to a value that was tested there already.
[Risks and why]: Low-risk... This just disabled the old FHR upload, the riskier full disabling/removal of that system will not jump to beta.
[String/UUID change made/needed]: None.
Attachment #8690027 - Flags: approval-mozilla-beta?
Attachment #8690027 - Flags: approval-mozilla-aurora?
Heads-up needinfo for you Liz.
Flags: needinfo?(lhenry)
Verified that on today's Nightly 45.0a1 (2015-11-23) with ‘datareporting.policy.dataSubmissionEnabled.v2’ pref set to false by default, both main and saved-session v4 pings are still being sent, under Mac OS X 10.11 and Ubuntu 14.04 32-bit (will verify on Windows too as soon as builds are available). In the meantime, could you please confirm if this verification is enough?
Flags: needinfo?(alexandra.lucinet) → needinfo?(gfritzsche)
The functionality of FHR & Telemetry sending should behave as expected after the pref flip, but i see that this was confirmed in bug 1208376 already.
It would be good to confirm the correct behavior on an official build once this goes to Beta, just to be safe.
Flags: needinfo?(gfritzsche)
Comment on attachment 8690027 [details] [diff] [review]
bug1210815.patch

Verified on Nightly. OK to uplift to aurora and beta.
Flags: needinfo?(lhenry)
Attachment #8690027 - Flags: approval-mozilla-beta?
Attachment #8690027 - Flags: approval-mozilla-beta+
Attachment #8690027 - Flags: approval-mozilla-aurora?
Attachment #8690027 - Flags: approval-mozilla-aurora+
Verified fixed with 43.0b6 (Build ID: 20151123113812) and latest 45.0a1, across platforms [1]. Only one issue encountered - bug 1222054 (already fixed and verified on 45 branch). Marking here accordingly.

[1] Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.5
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Setting back the [qe-verify+] flag for verification on Beta 44.
Flags: qe-verify+
This was verified, along with some additional exploratory testing, in bug 1227579 comment 16 with 44.0b2, across platforms. Therefore, dropping qe-verify flag.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.