1210815 - Disable v2 data upload in Firefox 43+

Status: VERIFIED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

Bug 1208376 landed the code to disable FHR v2 submission by flipping the "datareporting.policy.dataSubmissionEnabled.v2".

This bug is about flipping the preference to disable FHR v2 data submission.

Comment 1

[Georg Fritzsche [:gfritzsche]]

When do we want to disable v2 data upload in 43 (and go to further steps like bug 1209088 for 44+)?

Is the current plan to wait on Metrics & others to approve the 100% v2 & 100% v4 behavior on 42 release first?
Or could we go ahead with these steps?

Comment 2

[Thomas Huelbert]

I'm going to defer to Katie on this one, but my feeling is its too early to do this yet and we should wait for validation/continuity project to end.

Comment 3

[Alessio Placitelli [:Dexter]]

Attachment: bug1210815.patch

I've manually tested this:

- v4 still works, pings are still being submitted.
- v2 is not sending anything. Enabling the log results in "Services.DataReporting.Policy   DEBUG   Data submission is disabled. Doing nothing." prints.
- No crashes on shutdown or hangs happened locally.

Comment 4

[Alessio Placitelli [:Dexter]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c08f2545c15f

Comment 5

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8690027 [details] [diff] [review]
bug1210815.patch

Review of attachment 8690027 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but lets not land this yet.

Comment 6

[Georg Fritzsche [:gfritzsche]]

Katie, please let us know when we can land this on Nightly and if/when we should go to Beta.

Comment 7

[Katie Parlante]

We have the go ahead. We can land this on Nightly now, and we should go to Beta as soon as is practical.

Comment 8

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/fx-team/rev/0bfe3ec74b6063d996cb400e5a9ead2689efb669
Bug 1210815 - Disable FHR v2 data upload. r=gfritzsche

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0bfe3ec74b60

Comment 10

[Georg Fritzsche [:gfritzsche]]

Alexandra, can you have a look over this?

Comment 11

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8690027 [details] [diff] [review]
bug1210815.patch

Background:
We already have Unified Telemetry collecting 100% of the release population data in Firefox 42.
Now we have a go decision for turning off the old FHR reporting and can stop duplicating data upload / storage / infrastructure.
For risk migitation we already implemented a pref a while ago to just disable the old FHRs data upload (bug 1208376); now we are just flipping it.

Approval Request Comment
[Feature/regressing bug #]: Switching off old FHR upload in favor of Unified Telemetry
[User impact if declined]: Duplicated client data uploads as well as storage & infrastructure maintenance budget costs.
[Describe test coverage new/current, TreeHerder]: We are fairly confident in uplifting this - QA has been done on bug 1208376, this just flips the pref to a value that was tested there already.
[Risks and why]: Low-risk... This just disabled the old FHR upload, the riskier full disabling/removal of that system will not jump to beta.
[String/UUID change made/needed]: None.

Comment 12

[Georg Fritzsche [:gfritzsche]]

Heads-up needinfo for you Liz.

Comment 13

[Ada [:adalucinet]]

Verified that on today's Nightly 45.0a1 (2015-11-23) with ‘datareporting.policy.dataSubmissionEnabled.v2’ pref set to false by default, both main and saved-session v4 pings are still being sent, under Mac OS X 10.11 and Ubuntu 14.04 32-bit (will verify on Windows too as soon as builds are available). In the meantime, could you please confirm if this verification is enough?

Comment 14

[Georg Fritzsche [:gfritzsche]]

The functionality of FHR & Telemetry sending should behave as expected after the pref flip, but i see that this was confirmed in bug 1208376 already.
It would be good to confirm the correct behavior on an official build once this goes to Beta, just to be safe.

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8690027 [details] [diff] [review]
bug1210815.patch

Verified on Nightly. OK to uplift to aurora and beta.

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f7274ff3425c

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/fce49b044354

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f7274ff3425c

Comment 19

[Ada [:adalucinet]]

Verified fixed with 43.0b6 (Build ID: 20151123113812) and latest 45.0a1, across platforms [1]. Only one issue encountered - bug 1222054 (already fixed and verified on 45 branch). Marking here accordingly.

[1] Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.5

Comment 20

[Andrei Vaida [:avaida]]

Setting back the [qe-verify+] flag for verification on Beta 44.

Comment 21

[Ada [:adalucinet]]

This was verified, along with some additional exploratory testing, in bug 1227579 comment 16 with 44.0b2, across platforms. Therefore, dropping qe-verify flag.