121278 - Okay & Cancel buttons missing from various dialogs

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Tracy Walker [:tracy]]

seen on Mac only, commercial build 2002-01-22-08-trunk

-open Tasks | Privacy and Security | Password Manager
or
-open composer and the choose the color picker from the toolbar

in both cases, the dialog is missing the Okay and Cancel buttons.
since on mac these type of dialogs don't have a close box for the window, the 
user is stuck in the dialog. Force quit is the only way out.

Comment 1

[Daniel (Leaf) Nunes]

a lot of the dialogs? or just one or two? some specific examples will make it
easier to track for those of us without the benefit of a mac.

also, this *could* be a problem with the build machine (which was crashed when
the clobber build should have started, so the build this morning could have been
depend from whenever the last clobber build happened, which was yesterday
morning, 3am)

Comment 2

[Christopher Blizzard (:blizzard)]

I'm not seeing this on my linux build.

Comment 3

[Tracy Walker [:tracy]]

I didn't see this on windows or linux.  

Leaf, are the examples I gave in the initial comment not specific enough to try?

Comment 4

[Brian Nesse (gone)]

I see this on my Mozilla MacOS 9 debug build as well. Password Manager, Cookie
Manager, and color picker dialogs all exibit this behavior. Hitting the return
key or the esc key does exit the dialog as expected.

Comment 5

[Tracy Walker [:tracy]]

ah...guess I need to know my accessibilty keyboard shortcuts better.

reducing severity because of the available workarounds

Comment 6

[Simon Fraser [no longer active]]

Screenshot? Are the dialogs sized too small, or are the buttons just not drawing? 
Are there large white areas?

Comment 7

[Mike Pinkerton (not reading bugmail)]

someone said something last week about this. there is some problem with the xul
i think. it's not a nsITheme bug or anything to do with simon's recent painting
changes (happens in all skins, on osx and os9). I think it happens on win32 as
well to some extent.

Comment 8

[Brian Nesse (gone)]

For a while now there have been some dialogs where only the top couple of pixels
of the buttons were available (not these however.) In this case, the buttons
seem to be "off the bottom" of the dialogs. The problem is that if you drag the
window larger, they are still off the bottom. It seems that the central area of
the dialog is filling all of the content area of the window.

Comment 9

[Tracy Walker [:tracy]]

this is different from bug 117112, which cutoff the buttons. and it is different 
from 120341 in that bug the buttons don't appear until moused over.  in this bug 
the buttons expected below the horizontal line near the bottom of the dialogue 
just aren't there.  I suppose they could be completely cut off, but resizing 
(when possible) doesn't help. I'm  sorry but I don't know how to get a screen 
shot.

Comment 10

[Simon Fraser [no longer active]]

Command-shift-4 and select the area you want to get a screenshot on Mac OS 9 and 
X. Attach the file that shows up on your desktop.

Comment 11

[Brian Nesse (gone)]

Attachment: Normal size window

Comment 12

[Brian Nesse (gone)]

Attachment: Expanded window

Comment 13

[Joe Hewitt (gone)]

On friday I landed a change to dialog.xml which fixed bug 117112.  This could
likely be related - try backing out that change and see if it helps.  Also,
check the js console to see if there are any errors coming from dialog.xml and
paste em here if you see em.

Comment 14

[Brian Nesse (gone)]

Yes. Backing out your checkin does fix the problem.

Comment 15

[Brian Nesse (gone)]

There are no (additional) errors being generated as a result of your checkin.

Comment 16

[Brian Nesse (gone)]

As this fix was apparently desired for the 0.9.8 branch (see bug 114580), I
expect it is better to fix it than to back it out. ->hewitt

Comment 17

[Yuying Long]

I saw it on Composer | Save As Charset dialog as well.

Comment 18

[Joe Hewitt (gone)]

Sorry I haven't fixed this yet, spent a few hours waiting for my mac to update
and build, but then it failed, and now I just pulled a fresh tree and so I have
to wait a few hours for that to finish.  I guess if you branch tomorrow I can
land this fix on the branch later on.

Comment 19

[J.J. Enser]

What's the status on this ? Any progress since 11pm ? This blocker bug (together
with another one) prevents us from cutting the branch today, so don't postpone
its fix!

Comment 20

[J.J. Enser]

this was reported yesterday AND today as a smoketest blocker. however, the
current severity is "only" critical, and no smoketest keyword.
I need clarification

Comment 21

[Tracy Walker [:tracy]]

sorry jj, this was reduced to critical because of the available keyboard
shortcuts....I made a mistake in the smoketest email this morning...forgot to
change the status relate dto this bug

Comment 22

[Kathleen :Brade]

How does this bug differ from bug 117112?  Bug 117112 was never fixed on my Mac
build.

This bug has been around WAY too long to not be considered a blocker of some
type.  We should NOT ship 0.9.8 with so many dialogs broken.  Users shouldn't be
expected to know to press return/cancel as a work-around.  Also, that
work-around doesn't work until you click in the window (in some cases).

I see this on my Mac mozilla build from today in lots of places including:
  Bookmark properties
  Composer's hrule properties
  Composer's insert table dialog
  Composer's named anchor dialog
  Composer's page colors and background dialog
  Composer's page title and properties
  Composer's Insert Characters and Symbols
  Composer's Insert HTML dialog
  Composer's List properties
  Composer's Create Table from Selection dialog
  Addressbook's New List dialog
  Addressbook's Properties dialog
  Bookmarks' choose folder dialog
  Cookie Manager
  Image Manager
  Password Manager
  Form Manager > Managed Sites
  Search Messages dialog
  Find (in Mail/Browser/Composer)
  Open Web Location (in Browser/Composer)
  Composer's Save as Charset dialog
  Character Encoding Customize dialog
  ...

Comment 23

[Mike Schiraldi]

This sounds a lot like bug 89255.

Comment 24

[Kathleen :Brade]

I don't think this bug is the same as 89255.  Apparently the security dialog
covered in 89255 never had buttons.  This bug is for the huge regression which
occurred recently and affects almost every dialog in the product.

Comment 25

[Joe Hewitt (gone)]

Attachment: DUH! can I just check this in so we can branch?

Comment 26

[Brian Ryner (not reading)]

Comment on attachment 66180 [details] [diff] [review]
DUH!  can I just check this in so we can branch?

r=bryner

Comment 27

[andreww]

r=andreww

Comment 28

[Simon Fraser [no longer active]]

sr=sfraser

Comment 29

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to the 0.9.8 branch (which should be
available later this afternoon)

Comment 30

[Joe Hewitt (gone)]

fix landed on trunk

Comment 31

[Joe Hewitt (gone)]

fixed on branch too

Comment 32

[Tracy Walker [:tracy]]

I haven't seen this on daily builds since the end of January when the fix was 
checked in.
marking verified