1213883 - Tapping browser icon doesn't re-use browser windows

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Ben Francis [:benfrancis]]

[Blocking Requested - why for this release]:

Tapping the browser icon should re-use the last used browser window rather than open a new one. Currently the window manager appears to switch to an existing window, then create a new one.

STR:
* Tap browser icon
* Navigate to web page
* Tap home
* Tap browser icon

Expected:
* First window re-used

Actual:
* First window opens, then a new window with the browser start page immediately appears

Comment 1

[Chris Lord [:cwiiis]]

I think I've fixed this in gaia-app-icon and gaia-site-icon already. This will get updated in either bug 1196809 or bug 1191745.

I'll assign it myself to at least check up on it when either of those bugs are checked in.

Comment 2

[Chris Lord [:cwiiis]]

Fixed by gaia-site-icon update in bug 1196809.

Comment 5

[Chris Lord [:cwiiis]]

According to bug 1216046, this is still an issue.

Comment 7

[Etienne Segonzac (:etienne)]

We're getting 2 |webapps-launch| events at 40ms of interval.
The window manager can handle it and opens 1 window (from the homescreen) then the other (from the first window). So we get one "zoom" transition and then one "slide" transition.

It's cool that it works, but can the homescreen avoid calling |.launch()| twice for each tap? :)

Comment 8

[Chris Lord [:cwiiis]]

Thanks for that Etienne, fix incoming. Caused by gaia-container not properly counteracting the awful mouse-event synthesis that touch events trigger :(

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1213883-homescreen-multiple-launch > mozilla-b2g:master

Comment 10

[Guillaume Marty [:gmarty]]

Comment on attachment 8675723 [details] [review]
[gaia] Cwiiis:bug1213883-homescreen-multiple-launch > mozilla-b2g:master

r+!

Comment 11

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/32b9d5e6a92f5c7037325697048f5c75c89bf3d4

Comment 12

[Alison Shiue]

Verified on

[Flame]
Build ID               20151020150236
Gaia Revision          11eb5d4cb2675d359d277ae17772bc75f7ccedbc
Gaia Date              2015-10-20 16:22:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f397034950304b845175f8dab8fccbdd0e8bf995
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151020.182846
Firmware Date          Tue Oct 20 18:28:58 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151021013240
Gaia Revision          11eb5d4cb2675d359d277ae17772bc75f7ccedbc
Gaia Date              2015-10-20 16:22:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/605de27d4e7f530159842649c02075c578d7a4a5
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151021.005126
Firmware Date          Wed Oct 21 00:51:34 UTC 2015
Bootloader             s1