Closed
Bug 1217340
Opened 9 years ago
Closed 9 years ago
Handle an empty visits array of history record as a valid case
Categories
(Firefox OS Graveyard :: Sync, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S10 (30Oct)
People
(Reporter: selee, Assigned: selee)
References
Details
(Whiteboard: [partner-cherry-pick])
Attachments
(1 file)
It is possible that we will have a history record with empty visits property if the records is deleted from Desktop:
Incorrect payload? Object {
id: "OjzL_IsBqFme",
histUri: "http://www.ea.com/",
title: "http://www.ea.com/",
visits: Array[0] <<<<< !!!!!
}
It's excluded at the code:
https://github.com/mozilla-b2g/gaia/blob/master/apps/sync/js/adapters/history.js#L248
It should be recognized as a valid case.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → selee
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → FxOS-S10 (30Oct)
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8677915 [details] [review]
[gaia] weilonge:seanlee/DataSync/master/Bug1217340 > mozilla-b2g:master
Hey Michiel, Could you help to review the patch? Thank you!
Attachment #8677915 -
Flags: review?(mbdejong)
|
||
Updated•9 years ago
|
Attachment #8677915 -
Flags: review?(mbdejong) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
landed on master: https://github.com/mozilla-b2g/gaia/commit/3859ab4dfba2d2dd14ea7234254118809e8343cd
gaia-test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b31ef622cea317bbc0c703fc53c38ced2460acfb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•9 years ago
|
||
Found out that the delete that it was doing here was for url null, not for the actual histUri. Fix underway.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 5•9 years ago
|
||
See https://github.com/michielbdejong/gaia/commit/d380c08882df930e11dc090565ab38aba7d61075 (included in PR for bug 1214193)
|
||
Comment 6•9 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
You need to log in
before you can comment on or make changes to this bug.
Description
•