1217771 - [TV][2.5] Add Website to the apps folder

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Josh Cheng [:josh]]

As a user, I want to have the option to pin Content to the home screen / apps folder

Comment 1

[Josh Cheng [:josh]]

Hi Rex,
Here is what we need to do:
1. When user press option key in an app in marketplace which is a website, he should be able to add the webpage to apps folder just like bug 1225085.

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Take it by now, but this supposed to be a relatively complex work.
I need to do some survey to make it clean how much time needed.

Comment 3

[Josh Cheng [:josh]]

Move to P2 as this will not be in CES 2016

Comment 4

[Evelyn Hung]

Josh, from the new timeline we discuss in the work week, we need everything done before 1/8. This item should be start earlier given we haven't had a clue of implementation.

Rex, please treat it as your first priority, and let me know if you meet any problems. Thanks.

Comment 5

[Evelyn Hung]

Hi Maria and Tori,

How do we display websites and apps all together in app folder? Technically, websites and apps are from different sources(database) and we didn't record the time being added (since some of them are pre-built). Given the tight timeline I will suggest we do it easier by showing apps first and followed by websites in added order. What do you think?

Comment 6

[Evelyn Hung]

Moreover, how do we open a pined website? Do we want to open it in Browser app which means it leaves a record in browser history/cookie? Or we want it be independent?

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I can't found from spec of Marketplace describing that we have 2 types of contents, app and website, both on the same list. This is pretty confusing since the implementation is totally different. Please describe it somewhere.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] rexboy7:1217771-website > mozilla-b2g:master

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8698880 [details] [review]
[gaia] rexboy7:1217771-website > mozilla-b2g:master

Luke:
You may want to check this patch to gain ability on adding/removing bookmarks within datastore.

Please take a look and see if it mets your requirement.
On AppDeck, It lists all bookmarks.

** for testing:
If the bookmark is empty, it automatically adds 2 dummy bookmarks. But you can see them only at the second time launch (because of some timing issue I don't want to fix).

Comment 10

[Maria Sandberg [:mushi]]

Hi Evelyn,

I'm not sure I understand the question - can't we just show apps and websites mixed together in the order they were added? The user should not need to know that there is a difference. Thanks!

Comment 11

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Apps and bookmarks come from different data source. If we need to sort them mixed, additional calculation and refactoring to current implementation are needed. Insertion and deletion would become more complex because we need to do additional search.

Per the patch we are implementing now, bookmarks are shown right after the last installed app.

If we really want them to be shown mixed, just open another bug and put additional engineering work on it. I'd suggest to show them separately to decrease code complexity.

Comment 12

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8698880 [details] [review]
[gaia] rexboy7:1217771-website > mozilla-b2g:master

Patch updated.
Change from f? to r?.

Comment 13

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8698880 [details] [review]
[gaia] rexboy7:1217771-website > mozilla-b2g:master

Oops. ignore my miss please.

Comment 14

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: smart-button patch

This updates bookmark app-type style.

Comment 15

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8698880 [details] [review]
[gaia] rexboy7:1217771-website > mozilla-b2g:master

I've done my first round review. Please take a look at my comments on GitHub. Thanks.

Comment 16

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8699943 [details] [review]
smart-button patch

I found we need a one-line css patch for smart-button too. Luke may you review it?

Comment 17

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8698880 [details] [review]
[gaia] rexboy7:1217771-website > mozilla-b2g:master

And here are changes by last comments.
Would you mind review them again? Thank you!

Comment 18

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8698880 [details] [review]
[gaia] rexboy7:1217771-website > mozilla-b2g:master

Nice work! Thanks.

Comment 19

[KM Lee [:rexboy] (inactivate after Sep. 22)]

TEST-UNEXPECTED-FAIL | null | [sharedtest-test/unit/sticky_header_test.js] "before each" hook

Found a GU test before landing. Seems it's unrelated but I'm not 100% sure.

Comment 20

[KM Lee [:rexboy] (inactivate after Sep. 22)]

merged in master:

https://github.com/mozilla-b2g/gaia/commit/fee2b474b73df1433141caf73bdb0dc840933a73

Comment 21

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8698880 [details] [review]
[gaia] rexboy7:1217771-website > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):feature
[User impact] if declined: unable to ping bookmarks to app deck
[Testing completed]: done in local
[Risk to taking this patch] (and alternatives if risky): small-medium
[String changes made]: none

Comment 22

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/615a7b6ceb1afd3b5f23af9ba6ff31247a65020f