1211400 - [TV][2.5] Preview an app on Marketplace

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Comment 1

[Evelyn Hung]

Here are engineering works we try to do without any gecko API changes. It's a bit hacky to TV System app, but worth trying to see if it's a feasible workaround in this tight schedule.

1. bypass installation prompt and open the app once it installed, so the user "feel" it opens immediately. Note: for packaged app, we still need to download the whole package. If it's big or network bandwidth is limited, a "loading" progress indicator is needed.

2. Overlay the opened app on top of Marketplace app (i.e. a child window of Marketplace's app window) so both windows are kept in the foreground and their life cycle are managed together.

3. [Need UX confirm] While previewing the app, press Back key on the remote controller to close the preview app window

4. [Need UX confirm] While previewing the app, press Option button on the remote controller to show options like "install this app".

5. Uninstall the app automatically if the user closes the window without saying install it.

Comment 2

[Evelyn Hung]

I'm happy to have Ricky help out here!!! Big thank-you, Ricky. (and Tim. :)

Comment 3

[Evelyn Hung]

(In reply to Evelyn Hung [:evelyn] from comment #1)
> Here are engineering works we try to do without any gecko API changes. It's
> a bit hacky to TV System app, but worth trying to see if it's a feasible
> workaround in this tight schedule.
> 
> 1. bypass installation prompt and open the app once it installed, so the
> user "feel" it opens immediately. Note: for packaged app, we still need to
> download the whole package. If it's big or network bandwidth is limited, a
> "loading" progress indicator is needed.
> 
> 5. Uninstall the app automatically if the user closes the window without
> saying install it.

Paul, does it make sense to you?

Comment 4

[Evelyn Hung]

Also need Fabrice and Jonas input here. 

Could you check my comment 1 especially on point #1 and #5? Not sure if it makes more sense to invent new API for this, but due to tight schedule I prefer to hack from Gaia. :(

Comment 5

[[:fabrice] Fabrice Desré]

Evelyn, that's very similar to what we used to call "instant apps". I'm fine with that.

Comment 6

[Paul Theriault [:pauljt] (no longer reading bugmail)]

(In reply to Evelyn Hung [:evelyn] from comment #3)
> (In reply to Evelyn Hung [:evelyn] from comment #1)
> > Here are engineering works we try to do without any gecko API changes. It's
> > a bit hacky to TV System app, but worth trying to see if it's a feasible
> > workaround in this tight schedule.
> > 
> > 1. bypass installation prompt and open the app once it installed, so the
> > user "feel" it opens immediately. Note: for packaged app, we still need to
> > download the whole package. If it's big or network bandwidth is limited, a
> > "loading" progress indicator is needed.
> > 
> > 5. Uninstall the app automatically if the user closes the window without
> > saying install it.
> 
> Paul, does it make sense to you?

Makes sense. I assume the trust here comes from the fact that there will be a curated list of apps shown in a marketplace or something that the user can click on. My main concern would be that a user could accidentally load(and as above, install) an app that they don't won't. But I presume the app screen or marketplace would be incontrol here, and it wouldn;t be possible for a random web page (or app) to install any other content.

To say this another way: I think we need to make sure that:
- only the authorised list of apps can be launched
- apps can be 'installed' like this only by our authorised app (marketplace I assume)

I think this will just mean adding some checks to the process outlined in comment 1 to ensure that the 'installation' is happening from an authorised site.

Comment 7

[Evelyn Hung]

Thanks Paul, yes we will make sure the trick only plays on Marketplace website.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

What Paul said :)

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:tv-marketplace > mozilla-b2g:master

Comment 10

[Ricky Chien [:rickychien] (inactive)]

WIP patch is submitted please see comment 9.

For better app window management, a feasible solution is to open up a child window in marketplace for preview app. As a result, experience of preview package app can get the same effect as click "open web site" in marketplace, child window can be managed by its parent window and make it possible to be killed when OOM or be able to keep browsing history.

WIP patch can preview app (packaged app / hosted app), kill marketplace app will kill preview app too. (as above mentioned, it works because we preview an app with a child window)

Comment 11

[Ricky Chien [:rickychien] (inactive)]

WIP patch has been updated and it's able to cover functionalities of bug 1225081, bug 1225085 and bug 1225090. However, it still remain a bunch of bugs and that's pretty unstable statue now.

I'm going to integrate it with marketplace tomorrow (bug 1225086) to enable "option" key installation from marketplace.

Comment 12

[Ricky Chien [:rickychien] (inactive)]

WIP patch updated!

Almost features are done in this WIP patch and ready to land by separate eng bugs soon.

In addition to features it also include with newer marketplace app (not the latest version) in order to test preview behavior on local environment.

Comment 13

[Michael Ellis]

Bug has been confirmed as working for Cosmin.  Closing this bug as WFM accordingly.

Comment 14

[Michael Ellis]

@ Michael to test on TV and verify

Comment 15

[Michael Ellis]

I am unable to test this bug, as I do not have access to the 2.5 build.