Closed Bug 1218303 Opened 9 years ago Closed 9 years ago

Check history records by time and export maximum size argument to SyncBrowserDB.getHistory

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Browser
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S10 (30Oct)

People

(Reporter: selee, Assigned: selee)

References

Details

(Whiteboard: [partner-cherry-picked<2015/11/10>])

Attachments

(1 file)

[gaia] weilonge:seanlee/TVBrowser/master/Bug1218303 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yifan
: review+
Details | Review 
This issue tries to provide two improvements for history:
* Check the existences by the timestamp.
* Export the maximum size argument to SyncBrowserDB.getHistory
Assignee: nobody → selee
Status: NEW → ASSIGNED
Target Milestone: --- → FxOS-S10 (30Oct)
Comment on attachment 8678711 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1218303 > mozilla-b2g:master

Hi Yifan, Could you help to review the patch? Thank you!
Attachment #8678711 - Flags: review?(yliao)
Comment on attachment 8678711 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1218303 > mozilla-b2g:master

Thanks! r+ with a couple nits.
Attachment #8678711 - Flags: review?(yliao) → review+
Thanks for reviewing this! :)
landed on master: https://github.com/mozilla-b2g/gaia/commit/86d4341173c391eaad6de90b51691a6e8387a1be
gaia-test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b24df87830eb348ff54f6d7202d9b681609757bc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 1219108
Whiteboard: [partner-cherry-pick] → [partner-cherry-picked<2015/11/10>]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: