Closed Bug 1194092 Opened 9 years ago Closed 9 years ago

[browser] Firefox Account sync history

Categories

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(feature-b2g:2.5+)

Status:
RESOLVED FIXED
Milestone:
FxOS-S10 (30Oct)
Project Flags:
feature-b2g 2.5+

People

(Reporter: yifan, Assigned: danhuang)

References

Details

(Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick])

Attachments

(1 file)

[gaia] danhuang1202:1194092_fx_sync_history > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yifan
: review+
Details | Review 
Implement Firefox Account sync all data in TV browser.
No longer blocks: 1194091
Summary: [browser] Firefox Account sync all → [browser] Firefox Account sync history
Depends on: 1194094
No longer depends on: 1194094
Depends on: 1194096
No longer depends on: 1194096
Depends on: 1194097
Depends on: 1194098
No longer depends on: 1194098
Depends on: TV_FxAccount
Blocks: TV_FxAccount
No longer depends on: TV_FxAccount
No longer blocks: 1187830
No longer blocks: 1187840
No longer blocks: 1187838
Blocks: TV_Pocket
No longer blocks: TV_Pocket
feature-b2g: --- → 2.5+
Whiteboard: [ft:conndevices][partner-blocker]
Blocks: 1202376
Depends on: 1203898
No longer depends on: 1203898
Assignee: nobody → dhuang
Depends on: 1207481
No longer depends on: 1207481
Depends on: 1207483
No longer depends on: 1207483
Depends on: 1207488
No longer depends on: 1207488
Depends on: 1207521
Hi Dan,
Could you provide some feedback about the status of this bug?
Thanks!
Flags: needinfo?(dhuang)
Hi Josh, 
I am working on the other bug(Bug 1202376), and just send for review.
These bug would use the same render logic which implement in bug 1202376.
I would start working on this bug after bug 1202376 resolved.
Flags: needinfo?(dhuang)
Depends on: 1210697
Depends on: 1212187
Target Milestone: --- → FxOS-S10 (30Oct)
Depends on: 1212716
Assignee: dhuang → nobody
Depends on: 1215436
Priority: -- → P1
Assignee: nobody → yliao
Depends on: 1217349
Depends on: 1217352
Assignee: yliao → dhuang
Depends on: 1218303
Depends on: 1219108
Comment on attachment 8679826 [details] [review]
[gaia] danhuang1202:1194092_fx_sync_history > mozilla-b2g:master

Please me to review. This patch add historyStore.js for maintain history cache, and delete un-use code for list-dialog. Thanks.
Attachment #8679826 - Flags: review?(yliao)
No longer blocks: 1202376
Comment on attachment 8679826 [details] [review]
[gaia] danhuang1202:1194092_fx_sync_history > mozilla-b2g:master

The cursor for bookmark and history list is missing. Please file a follow up bug for it. Please see the comments on Github, thanks!
Attachment #8679826 - Flags: review?(yliao) → review-
Depends on: 1219162
Comment on attachment 8679826 [details] [review]
[gaia] danhuang1202:1194092_fx_sync_history > mozilla-b2g:master

Please help to review again. This patch fix the comments you mentioned. Thanks.
Attachment #8679826 - Flags: review- → review?(yliao)
(In reply to yifan [:yifan][:yliao] from comment #5)
> Comment on attachment 8679826 [details] [review]
> [gaia] danhuang1202:1194092_fx_sync_history > mozilla-b2g:master
> 
> The cursor for bookmark and history list is missing. Please file a follow up
> bug for it. Please see the comments on Github, thanks!

The follow up bug 1219564
Attachment #8679826 - Flags: review?(yliao) → review+
Thanks for the review !
merge in master:
https://github.com/mozilla-b2g/gaia/commit/fd0cc6855bd6da560ae48989fb207f76394a74c7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [ft:conndevices][partner-blocker] → [ft:conndevices][partner-blocker][partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: