1218805 - Implement 'edit mode'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Lord [:cwiiis]]

UX have highlighted issues with the current drop-tray in new home screen and we've discussed and worked on an 'edit mode' implementation that is somewhat similar to what we have in verticalhome to replace it.

Home screen retains the ability to quickly re-order apps that people have expressed a liking of.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:new-homescreen-edit-mode > mozilla-b2g:master

Comment 4

[Chris Lord [:cwiiis]]

[Blocking Requested - why for this release]: Fixes serious UX issues that have been identified.

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 8679462 [details] [review]
[gaia] Cwiiis:new-homescreen-edit-mode > mozilla-b2g:master

Flagging for review early, changes now should just be small tweaks, nothing major.

All unit tests fixed, lots of unit tests added and all marionette tests fixed, at least locally. For some reason tests aren't being triggered, but hopefully when that's resolved, they'll be green...

Comment 6

[Chris Lord [:cwiiis]]

Ah, just looks like the PR isn't being commented on, treeherder for the last push here: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=4a06e2885e15

Comment 7

[Chris Lord [:cwiiis]]

Made a small mistake in a last-second fix before push, maybe just look at the latest push on https://treeherder.mozilla.org/#/jobs?repo=gaia&author=[e-mail] :)

Comment 8

[[:fabrice] Fabrice Desré]

Are there any specs or meeting minutes describing these changes?

Comment 9

[Gregor Wagner [:gwagner]]

(In reply to [:fabrice] Fabrice Desré from comment #8)
> Are there any specs or meeting minutes describing these changes?

The UX feedback is tracked here:
https://docs.google.com/spreadsheets/d/1848sJuQbpRggfT709ltRj4ochhhxq4QRUTdMAp6UxAk/edit#gid=0

Comment 10

[Guillaume Marty [:gmarty]]

Comment on attachment 8679462 [details] [review]
[gaia] Cwiiis:new-homescreen-edit-mode > mozilla-b2g:master

Great! I love the no-delay drag and drop in edit mode.
I left some comments on Github. The main issue is the ambiguous wordings of "edit mode" (= mode in which you can update and remove apps) and "edit" (= update/rename a bookmark). I'd change the latter edit to update or rename in all properties/methods/variables concerned.
Also it's a big batch of changes and we need another pair of eyes to review it. Alberto, can you take a look? Feel free to redirect the review.

Comment 11

[Alberto Pastor [:albertopq]]

Comment on attachment 8679462 [details] [review]
[gaia] Cwiiis:new-homescreen-edit-mode > mozilla-b2g:master

Not very familiar with this code, but I don't see anything wrong. Also, testing it works great. Left a nit comment, but nothing important. Thanks!

Comment 12

[Chris Lord [:cwiiis]]

Merged :s https://github.com/mozilla-b2g/gaia/commit/6088dd9cb7c2657b989dbe7fdea8dd2bf8b4cca4

Comment 14

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1218805-homescreen-edit-mode-fixup > mozilla-b2g:master

Comment 15

[Chris Lord [:cwiiis]]

Comment on attachment 8681282 [details] [review]
[gaia] Cwiiis:bug1218805-homescreen-edit-mode-fixup > mozilla-b2g:master

Oh man, just noticed all the animations in 4-column mode on icons are a bit off :( Let's restructure so that this can't happen in the future, but for now, the let's get in the easy fix before 2.5.

Comment 16

[Guillaume Marty [:gmarty]]

Comment on attachment 8681282 [details] [review]
[gaia] Cwiiis:bug1218805-homescreen-edit-mode-fixup > mozilla-b2g:master

Looks good. Hopefully in the future, using CSS transform scale to display 3 or 4 columns will give us more flexibility and avoid this type of bugs.

Comment 17

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/2b8d8448920e2d723462e536e0bb5f634d1a700f