1220961 - Escape key in the refresh auth screen in the fx account flow doesn't work

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect, P2)

Description

[yifan [:yifan][:yliao]]

When the escape key is pressed:

JavaScript error: app://smart-system.gaiamobile.org/fxa/js/fxam_navigation.js, line 40: SyntaxError: An invalid or illegal string was specified

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] begeeben:1220961_escape_key > mozilla-b2g:master

Comment 2

[yifan [:yifan][:yliao]]

Comment on attachment 8684134 [details] [review]
[gaia] begeeben:1220961_escape_key > mozilla-b2g:master

The root cause is that the FxaModuleNavigation module tried to query DOM with '#refresh_auth?email=xxx@xxx'.

Comment 3

[yifan [:yifan][:yliao]]

https://github.com/mozilla-b2g/gaia/commit/156842861d776b57cf899989ecb445fea3c14fe8

Comment 4

[yifan [:yifan][:yliao]]

Comment on attachment 8684134 [details] [review]
[gaia] begeeben:1220961_escape_key > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1194108
[User impact] if declined: A user can not leave refresh auth page if he or she forgets the password.
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=c3bf6f8e5f3fc0d839ef74ff87ce1a89847f9d5d
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 5

[Josh Cheng [:josh]]

Comment on attachment 8684134 [details] [review]
[gaia] begeeben:1220961_escape_key > mozilla-b2g:master

Approved as this is required for TV 2.5 datasync

Comment 6

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/0d9eab3e364b52731d55d30ab83e658faef0a8d9 for 2.5