1225090 - [TV][2.5] Remind user to add content to Apps if webapp has been opened over X times

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P3)

Description

[Ricky Chien [:rickychien] (inactive)]

If the webapp content has been opened over X times and the user hasn’t added it to Apps yet the system shows a dialogue.

If the user presses “cancel” or the “back” button on the remote the dialogue is dismissed and the user is returned to the Marketplace. 

If user presses “add”, the dialogue is dismissed and the user is returned to the Marketplace. A banner is displayed informing the user that the content has been added to Apps.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:RemindToAddToApps > mozilla-b2g:master

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8696768 [details] [review]
[gaia] rickychien:RemindToAddToApps > mozilla-b2g:master

Luke, it's a P3 follow-up patch for bug 1225085.

Please take a look and review it after bug 1225085 is landed :)

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8696768 [details] [review]
[gaia] rickychien:RemindToAddToApps > mozilla-b2g:master

I've finished my first round review. Please take a look. Thanks.

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8696768 [details] [review]
[gaia] rickychien:RemindToAddToApps > mozilla-b2g:master

Good job! Thanks.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/43339d3f90dcc532887ed75888c738d87db358e6

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8696768 [details] [review]
[gaia] rickychien:RemindToAddToApps > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1211400
[User impact] if declined: impact system app but all test cases are passed
[Testing completed]: verified locally and remote CI
[Risk to taking this patch] (and alternatives if risky):
[String changes made]: none

Comment 7

[Josh Cheng [:josh]]

Comment on attachment 8696768 [details] [review]
[gaia] rickychien:RemindToAddToApps > mozilla-b2g:master

Approved for TV 2.5

Comment 8

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/65deec04b138641f7b6cb01a5cf894ac63e75323

Comment 10

[Rid Pan]

Verify this issue on the latest build.
After launching the same webapp content for three times, the dialog "Add [webapp's name] to Apps?" will pop up. And then pressing the Add button can add the content to Apps.
[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/435a9320454ccc3ffdebff4d5d680f1254a15e26
gecko:
https://hg.mozilla.org/mozilla-central/rev/a9e33d8c48b5ca93ca1937eba4220f681a0f05ec

Comment 11

[Rid Pan]

The result of v2.5 is also passed.

[Build Info]
Environment: Simulator 2.5.20160215231509
gaia:
https://github.com/mozilla-b2g/gaia/commit/b059a19c4cb615e16174735662199e6769cee393
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/227c6d4926c154167a2214e123253f2c937e4106
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3