1226048 - "Save View as Folder" and "File->New->Saved Search": missing folder

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Edmund Wong (:ewong)]

1) In the 3pane message view, select a message.
2) go to View->Messages->Save View as Folder
3) Regardless of what you choose in the dropdown box, the chosen folder isn't
   shown.

Furthermore, doing that will throw the following errors in Error Console:


Timestamp: 11/19/2015 8:36:22 AM
Error: TypeError: redeclaration of var nsMsgSearchScope
Source File: chrome://messenger/content/virtualFolderProperties.js
Line: 13

Timestamp: 11/19/2015 8:36:22 AM
Error: ReferenceError: onLoad is not defined
Source File: chrome://messenger/content/virtualFolderProperties.xul
Line: 1


And clicking on the "Choose" button produces the following error:

Timestamp: 11/19/2015 8:38:31 AM
Error: ReferenceError: chooseFoldersToSearch is not defined
Source File: chrome://messenger/content/virtualFolderProperties.xul
Line: 1

Comment 1

[lemon_juice]

I can confirm this. The same error is happening when choosing File->New->Saved Search...

This is a regression after SM 2.38, which didn't have this bug.

Comment 2

[lemon_juice]

This seems to be fixed in SM 2.41a2 aurora and 2.42a1 nightly. I don't know about 2.40 since I was not able to find windows builds.

Comment 3

[Rainer Bielefeld]

a) WORKSEORME with  SeaMonkey 2.42a1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0 
   from public download area)  Gecko/20100101  Firefox/ 45.0  
   Build 20151111021032, (Classic Theme) on German WIN7 64bit
b) Still REPRODUCIBLE with  
b1) German SeaMonkey 2.41a1 Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:44.0 
   from akalla download area)  Gecko/20100101  Firefox/ 44.0  
   Build 20150926114543,  (Classic Theme) on German WIN7 64bit
b2) German SeaMonkey 2.40a2 Mozilla/5.0 (Windows NT 6.1; 
   x64; rv:43.0 from akalla download area)  Gecko/20100101  Firefox/ 43.0  
   Build 20151010043152, (Classic Theme) on German WIN7 64bit 
c) Already broken with  SeaMonkey German 2.39b1 Mozilla/5.0 (Windows NT 6.1; 
   WOW64; rv:42.0 from official download area)  Gecko/20100101  Firefox/42.0  
   Build 20151028234211  (Classic Theme) on German WIN7 64bit
d) Was still ok with  SeaMonkey German 2.39a1 Mozilla/5.0 (Windows NT 6.1; WOW64;
   rv:42.0 from official download area)  Gecko/20100101  Firefox/42.0  
   Build 20150806070100  (Classic Theme) on German WIN7 64bit

Comment 4

[Rainer Bielefeld]

e) Probably "OS = ALL?

Comment 5

[Philip Chee]

> Timestamp: 11/19/2015 8:36:22 AM
> Error: TypeError: redeclaration of var nsMsgSearchScope
> Source File: chrome://messenger/content/virtualFolderProperties.js
> Line: 13

Looks like this is a regression caused by Bug 843320

Comment 6

[Philip Chee]

And accidentally fixed in Bug 1209777

Comment 7

[:aceman]

So what is the theory here?

Comment 8

[:aceman]

The const worked at the time of landing 843320, then m-c changes broke consts and lets tree wide and got fixed everywhere. Why would this be a problem here now?

Comment 9

[Philip Chee]

Attachment: Patch v1 use var instead of const

Simple one line fix. Can Lemon Juice or Rainer help test this patch?

Comment 10

[Philip Chee]

(In reply to :aceman from comment #8)
> The const worked at the time of landing 843320, then m-c changes broke
> consts and lets tree wide and got fixed everywhere. Why would this be a
> problem here now?
There appears to be a brief time gap between Bug 843320 and Bug 1209777 Whereby this bug managed to slip through.

Comment 11

[lemon_juice]

The patch works fine for me, thanks!

Comment 12

[Rainer Bielefeld]

Comment on attachment 8698597 [details] [diff] [review]
Patch v1 use var instead of const

Unfortunately I have no skills to test a patch.

Comment 13

[Philip Chee]

Comment on attachment 8698597 [details] [diff] [review]
Patch v1 use var instead of const

[Approval Request Comment]
Regression caused by (bug #): Bug 843320 + Bug 1209777
User impact if declined: Save View as Folder
Testing completed (on m-c, etc.): comm-central, comm-aurora, comm-beta (we missed uplift to comm-release
Risk to taking this patch (and alternatives if risky): no risk bustage fix.
String changes made by this patch: None

Comment 14

[Philip Chee]

Comment on attachment 8698597 [details] [diff] [review]
Patch v1 use var instead of const

Thunderbird uses comm-esr to do releases. So comm-release is used only by SeaMonkey.

Comment 15

[:aceman]

Comment on attachment 8698597 [details] [diff] [review]
Patch v1 use var instead of const

Review of attachment 8698597 [details] [diff] [review]:
-----------------------------------------------------------------

This is what the code is on trunk, so if it is needed on branch for some reason, it should not hurt.

Comment 16

[Philip Chee]

Comment on attachment 8698597 [details] [diff] [review]
Patch v1 use var instead of const

> This is what the code is on trunk, so if it is needed on branch for some
> reason, it should not hurt.
Thanks.

Comment 17

[Rainer Bielefeld]

I think really folder is missing, not only folder name

Comment 19

[Philip Chee]

Pushed to comm-release:
https://hg.mozilla.org/releases/comm-release/rev/de0b95699f22

Comment 20

[Rainer Bielefeld]

(In reply to Rainer Bielefeld from comment #4)
> e) Probably "OS = ALL?

No objections, so ALL

Comment 23

[Woi]

Works again with 2.40 under Linux. Thanks guys

Comment 24

[Rainer Bielefeld]

Verified with  en-US SeaMonkey 2.40 final Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0)from official download page,  Gecko/20100101  Firefox/ 43.0  Build 20160120202951, (Classic Theme) on German WIN7 64bit