122626 - New mail notification icon does not come up on win98

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[Sheela Ravindran]

Commercial Build: 2002-01-30-06 win98

On win98 machine new mail notification icon in the system tray cannot be seen.

Steps:
Start browser
Start mail
Perfs: check new messages every [] minutes checked. 
compose a new message
send message
wait for biff to go off
Actual result: No mail notification icon on system tray.  

Expected Result: Should bring up the mail notification icon in the system tray

Comment 1

[Scott MacGregor]

I believe this is a dup of 122351. 

*** This bug has been marked as a duplicate of 122351 ***

Comment 2

[Sheela Ravindran]

Reopening this bug because fixing bug 122351 did not fix this bug. I still don't
see the mail notification working on win98 and winME. The recent build I have is
2002-02-04-06.  

Comment 3

[[not reading bugmail]]

awhh.. yes. another bug that works on every other win platform is a bug specific
to the win98 OS changes over w95. :) adding platform parity keyword.

Comment 4

[[e-mail]]

On those platforms that have it, does anyone bother checking the return value of
Shell_NotifyIconW?

Comment 5

[Alfonso Martinez]

FWIW:
I'm using win98 and I don't see the new mail icon in the systray, but the icon
for quicklaunch shows correctly, so it seems to me that this work has been coded
twice, and that at least for me the correct implementation is the one used to
display the quicklaunch icon.

Comment 6

[Peter Lairo]

Shouldn't this bug block bug 18729?

Comment 7

[Scott MacGregor]

why? as i said before, 18729 is a "nice idea" bug...i.e. developing a cross
platform framework for maniuplating icons in an operating system's system tray.
It's not specific to biff. It's a framework bug. 

119344 was the bug I used to implement biff notification in the system tray. It
is working on all windows platforms except for win98. From that bug, I filed
this bug citing the fact that win98 isn't happy with the methods on the windows
shell API that I'm using. I haven't figured out why yet. 

Comment 8

[Felix Miata]

Not all platforms have a systray equivalent. Compare to bug 129052.

Comment 9

[Ere Maijala (slow)]

mscott: I believe it's not correct to check the availability of a function via
GetProcAddress. I think that Shell_NotifyIconW is there in later win95 and win98
versions of shell32.dll (it will fail, but anyway). At least it seems to be
present  (by a visual examination, can't confirm as I only have win2k) in
shell32.dll shipped with IE4 w/ Desktop Update for win98. 

Comment 10

[Matthias Versen [:Matti]]

*** Bug 132007 has been marked as a duplicate of this bug. ***

Comment 11

[Michael Buckland]

Discussed in Mail News bug mtg with Engineering QA Mktng PjM.  Decided to ADT2
this bug. 

Comment 12

[grylchan]

removing stephend & adding myself as qa

Comment 13

[Scott MacGregor]

Attachment: the fix...fall back to non unicode versions if we get an error

Apparently on Win98, the Shell_NotifyIconW (the unicode version) is defined;
however it isn't actually implemented. So if you call it, it returns FALSE
signaling an error. 

My fix is to revert back to the ascii version of the routine if we get an error
back from Shell_NotifyIconW. We do this by releasing our handle to the icon in
the unicode shell struct. We then copy any tooltip data over to the ascii shell
struct and we then call the ascii version of Shell_NotifyIcon

Comment 14

[racham]

Comment on attachment 76000 [details] [diff] [review]
the fix...fall back to non unicode versions if we get an error

r=bhuvan

Comment 15

[Peter Lairo]

What if additional e-mails arrive *after* the icon is already being displayed in
the system tray; will the tooltip update to reflect the *new* number of messages?

Comment 16

[grylchan]

Peter, I believe the bug about updating new number of mesgs
if the icon is already displayed is bug 123104

Comment 17

[David :Bienvenu]

Comment on attachment 76000 [details] [diff] [review]
the fix...fall back to non unicode versions if we get an error

yeah, Microsoft's unicode support on win98 sucks. sr=bienvenu

Comment 18

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 76000 [details] [diff] [review]
the fix...fall back to non unicode versions if we get an error

a=dbaron for trunk checkin 

(Stylistically I'd much rather see

if (res)
  return;
...

than

if (!res)
  ...
else
  return;

but it doesn't really matter.)

Comment 19

[Scott MacGregor]

fix checked in.

Comment 20

[laurel]

Working for me with mar28 commercial trunk, win98.

Comment 21

[grylchan]

Using 2002032803 on 3 Win98 machines (i believe 1st edition)
and 1 WinME machine, I may have to reopen this bug.

When a new mesg arrives, instead of the white envelope
icon w/red flag up signaling new mail has arrived.
I'm seeing a yellow triangle w/exclamation mark in the middle
in the system tray.

Scott, Stephen mentioned that Kerz saw this on his machine,
but I couldn't find the bug number on this.

Comment 22

[Chris Nelson]

I get the same yellow alert triangle. I thought it was what I was supposed to be
seeing!

Comment 23

[Scott MacGregor]

re-closing. The icon is working on win98 now.

About the yellow icon, apparently there were some bad bits yesterday. People who
were seeing the yellow icon told me they aren't seeing it on todays build. In
either case that should be filed as a new bug since it is unrelated to this one. 

Comment 24

[John Fredlund]

I am very happy to see this working in time for 1.0. Using build 2002032708 on
Win98, I see yellow exclamation triangle, but that's fine with me. Sorry for
spam, but had to cheer somehow!

Comment 25

[[e-mail] (gone - use [e-mail] instead)]

Yes, on Windows 98 using build 2002-04-01-03, with the 'Show an Alert' and with 
biff set on the account, I am able to see the new mail notification icon - 
although it is yellow, that is covered by Gary's bug 134754.

Verified FIXED.

Comment 26

[[e-mail] (gone - use [e-mail] instead)]

Sorry - bug 134745, rather.