Sync engine shared lib

RESOLVED FIXED in 2.6 S2 - 12/4

Status

Firefox OS
Sync
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ferjm, Assigned: ferjm)

Tracking

(Blocks: 1 bug)

unspecified
2.6 S2 - 12/4
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Sync app adapters must be written inside the Sync app which force them to use DataStore to share the synchronized collection data with the original local collection source. We want to avoid this and allow any app to implement the Sync app Adapter API. We will likely use IAC for this.
(Assignee)

Updated

2 years ago
Blocks: 824026
Priority: -- → P3
Target Milestone: --- → 2.6 S2 - 12/4
(Assignee)

Updated

2 years ago
Summary: Sync app plugin adapters → Sync engine shared lib
(Assignee)

Updated

2 years ago
Assignee: nobody → ferjmoreno
(Assignee)

Updated

2 years ago
Priority: P3 → P2

Comment 1

2 years ago
Created attachment 8693495 [details] [review]
[gaia] ferjm:bug1227593.syncengine.shared > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8693495 [details] [review]
[gaia] ferjm:bug1227593.syncengine.shared > mozilla-b2g:master

This is just a first step. I filed bug 1227593 and bug 1228966 as follow-ups.
Attachment #8693495 - Flags: review?(mbdejong)
(Assignee)

Comment 3

2 years ago
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #2)
> Comment on attachment 8693495 [details] [review]
> [gaia] ferjm:bug1227593.syncengine.shared > mozilla-b2g:master
> 
> This is just a first step. I filed bug 1227593 and bug 1228966 as follow-ups.

I meant to say: bug 1228964 and bug 1228966
Comment on attachment 8693495 [details] [review]
[gaia] ferjm:bug1227593.syncengine.shared > mozilla-b2g:master

Great! Just please also move apps/sync/test/unit/* (except for apps/sync/test/unit/adapters/*) to shared/test/unit/sync/, right?
Attachment #8693495 - Flags: review?(mbdejong) → review+
(Assignee)

Comment 5

2 years ago
Unfortunately we don't run tests in shared, only in the apps folder.
(Assignee)

Comment 6

2 years ago
Actually, it seems that we have apps/sharedtests for that.
(Assignee)

Comment 7

2 years ago
https://github.com/mozilla-b2g/gaia/commit/76c2dacbcff176563bfdf8068655bb438f49fe55
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.