1227593 - Sync engine shared lib

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P2)

Description

[Fernando Jiménez Moreno [:ferjm]]

Sync app adapters must be written inside the Sync app which force them to use DataStore to share the synchronized collection data with the original local collection source. We want to avoid this and allow any app to implement the Sync app Adapter API. We will likely use IAC for this.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1227593.syncengine.shared > mozilla-b2g:master

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8693495 [details] [review]
[gaia] ferjm:bug1227593.syncengine.shared > mozilla-b2g:master

This is just a first step. I filed bug 1227593 and bug 1228966 as follow-ups.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #2)
> Comment on attachment 8693495 [details] [review]
> [gaia] ferjm:bug1227593.syncengine.shared > mozilla-b2g:master
> 
> This is just a first step. I filed bug 1227593 and bug 1228966 as follow-ups.

I meant to say: bug 1228964 and bug 1228966

Comment 4

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8693495 [details] [review]
[gaia] ferjm:bug1227593.syncengine.shared > mozilla-b2g:master

Great! Just please also move apps/sync/test/unit/* (except for apps/sync/test/unit/adapters/*) to shared/test/unit/sync/, right?

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Unfortunately we don't run tests in shared, only in the apps folder.

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Actually, it seems that we have apps/sharedtests for that.

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/76c2dacbcff176563bfdf8068655bb438f49fe55