1227974 - ZoomedView appears to be enabled on all channels

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

ZoomedView is supposed to be on by default in Nightly, but the change in bug 1165128 enabled it on all branches[0] (there is no Nightly guard).

[0] https://hg.mozilla.org/releases/mozilla-release/rev/12df4e64ecc3

Comment 1

[:Margaret Leibovic]

We should write a patch to actually disable this, and uplift it.

Comment 2

[:Margaret Leibovic]

Attachment: Disabled zoomed view on release

Patch for release (the pref name changed on other channels).

Comment 3

[:Margaret Leibovic]

Attachment: Disable zoomed view on aurora/beta

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8691983 [details] [diff] [review]
Disabled zoomed view on release

If we want to land this everywhere, you could use 

#ifdef NIGHTLY_BUILD
pref("ui.zoomedview.disabled", false);
#else
pref("ui.zoomedview.disabled", true);
#endif

(changing the pref on channels where "ui.zoomedview.enabled" is still used)

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

OK, I see these are already channel-specific patches. Onward!

Comment 6

[:Margaret Leibovic]

Comment on attachment 8691983 [details] [diff] [review]
Disabled zoomed view on release

Approval Request Comment
[Feature/regressing bug #]: bug 1165128

[User impact if declined]: shipping a broken feature, which can lead to webpage bustage (e.g. bug 1224888)

[Describe test coverage new/current, TreeHerder]: no tests

[Risks and why]: low-risk, flipping a pref to disable a feature

[String/UUID change made/needed]: none

Comment 7

[:Margaret Leibovic]

Comment on attachment 8691984 [details] [diff] [review]
Disable zoomed view on aurora/beta

Approval Request Comment
[Feature/regressing bug #]: bug 1165128

[User impact if declined]: shipping a broken feature, which can lead to webpage bustage (e.g. bug 1224888)

[Describe test coverage new/current, TreeHerder]: no tests

[Risks and why]: low-risk, flipping a pref to disable a feature

[String/UUID change made/needed]: none

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Looks like Margaret took care of this (thanks!). The patches seem reasonable.

To be explicit, this is intentionally shipping in 45 (bug 1196146).

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

NI to Sylvestre to try to get these patches approved for the Beta 7 build and the likely Fx42.0.2 release

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8691984 [details] [diff] [review]
Disable zoomed view on aurora/beta

Sure, taking it to have it in beta 7!

Comment 11

[Carsten Book [:Tomcat]]

this does not apply to mozilla-aurora cleanly:
(eg '1-3,5', or 's' to toggle the sort order between id & patch description) 2
adding 1227974 to series file
renamed 1227974 -> disable-beta.diff
applying disable-beta.diff
patching file mobile/android/app/mobile.js
Hunk #1 FAILED at 405
1 out of 1 hunks FAILED -- saving rejects to file mobile/android/app/mobile.js.rej

can you take a look, thanks!

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-release/rev/8ecdea9cf234
https://hg.mozilla.org/releases/mozilla-beta/rev/b6c77146e02a

Comment 13

[:Margaret Leibovic]

(In reply to Carsten Book [:Tomcat] from comment #11)
> this does not apply to mozilla-aurora cleanly:
> (eg '1-3,5', or 's' to toggle the sort order between id & patch description)
> 2
> adding 1227974 to series file
> renamed 1227974 -> disable-beta.diff
> applying disable-beta.diff
> patching file mobile/android/app/mobile.js
> Hunk #1 FAILED at 405
> 1 out of 1 hunks FAILED -- saving rejects to file
> mobile/android/app/mobile.js.rej
> 
> can you take a look, thanks!

Fixed and landed on aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/089460329f5f

Comment 14

[Teodora Vermesan (:TeoVermesan)]

"ui.zoomedview.enabled=false" on Firefox for Android 43 Beta 7, so marking status-firefox43 as verified

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/089460329f5f

Comment 16

[:Margaret Leibovic]

Closing this as fixed, since nothing needs to land on m-c here.

Comment 17

[Teodora Vermesan (:TeoVermesan)]

"ui.zoomedview.disabled=true" on Firefox for Android 42.0.2, so marking status-firefox42 as verified

Comment 19

[Flaviu Cos]

"ui.zoomedview.enabled=false"
Verified as fixed in Firefox 44  Beta 8;
Device: Asus ZenPad 8 (Android 5.0.2).