Closed Bug 1232780 Opened 4 years ago Closed 3 years ago

Schedule mochitest-plain on e10s on Windows 7

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(e10s+)

RESOLVED FIXED
Tracking Status
e10s + ---

People

(Reporter: jgriffin, Assigned: jgriffin)

References

(Blocks 3 open bugs)

Details

Attachments

(2 files, 2 obsolete files)

We should get mochitest-plain running in e10s mode on Windows 7, disabling to get to a green state, while mrbkap continues to work on greening tests.
Oops, that was a bad try syntax for this. Here's a better one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=57953d6975fb
new try run with more tests disabled and some assertions marked as expected: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed0c4866a016

Note that even for passing runs, there are lots of IPC errors in the logs; not sure how important these are.
So these tests be scheduled to run in parallel with the non-e10s tests?  Enabled on a single branch to start?
Flags: needinfo?(jgriffin)
(In reply to Kim Moir [:kmoir] from comment #4)
> So these tests be scheduled to run in parallel with the non-e10s tests? 
> Enabled on a single branch to start?

We're not quite ready to enable them, but when we are, they will be run in parallel with non-e10s and scheduled on all trunk branches, including try.
Flags: needinfo?(jgriffin)
Vlad or Alin: You could get the patches ready for this bug so the tests could be scheduled as soon as ateam team greens them up
Flags: needinfo?(vlad.ciobancai)
Flags: needinfo?(alin.selagea)
Flags: needinfo?(vlad.ciobancai)
Flags: needinfo?(alin.selagea)
Attached patch bug1232780_config.py.patch (obsolete) — Splinter Review
Attached you can find the patch
Attached file bug1232780_config.py.output (obsolete) —
Attached you can find the difference
Comment on attachment 8702283 [details] [diff] [review]
bug1232780_config.py.patch

Review of attachment 8702283 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/config.py
@@ +598,4 @@
>      }),
>  ]
>  
> +MOCHITEST_PLAIN = [

We shouldn't define a new suite here; we can use the existing MOCHITEST_E10S suite.

@@ +2404,4 @@
>                      BRANCHES[name]['platforms'][platform][slave_platform]['opt_unittest_suites'] += MOCHITEST_PUSH
>                      BRANCHES[name]['platforms'][platform][slave_platform]['debug_unittest_suites']+= MOCHITEST_PUSH
>  
> +# Bug 1232780 - Schedule mochitest-plain on e10s on Windows 7

This block should be incorporated into the block at http://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla-tests/config.py#l2469, which automatically omits the twig branches.
Attachment #8702283 - Flags: review-
latest try run for test greening, only a few debug failures left: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a7b3f4af1ca
Updated the patch by using the suggestion received from :jgriffin
Attachment #8702283 - Attachment is obsolete: true
Attached the difference
Attachment #8702285 - Attachment is obsolete: true
Attachment #8702483 - Flags: review?(jgriffin)
Attachment #8702483 - Flags: review?(coop)
Comment on attachment 8702483 [details] [diff] [review]
bug1232780_config.py.patch

Review of attachment 8702483 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!
Attachment #8702483 - Flags: review?(jgriffin) → review+
Attachment #8702483 - Flags: review?(coop) → review+
(In reply to Jonathan Griffin (:jgriffin) from comment #13)
> Looks great, thanks!

Please tell us when we can push the patches
latest try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9230600672c

We're pretty green, although debug chunk 1 seems to suffer from a really high rate of unrelated intermittents. I'm going to retrigger a bunch of times to see if it's green enough to enable.
Blocks: 1236257
Keywords: leave-open
(In reply to Pulsebot from comment #16)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/e51048013b92

This greens up mochitest-plain on opt; I'll land the scheduling changes for this after this is merged to m-c. More work is needed still on debug, which is quite crashy.
Comment on attachment 8702483 [details] [diff] [review]
bug1232780_config.py.patch

I landed just the opt part of this as https://hg.mozilla.org/build/buildbot-configs/rev/ea429699060a; the debug part can't land as the tests still need more work there.
Blocks: 1237470
Blocks: 1238702
Blocks: 1238707
Depends on: 1233774
Depends on: 1238542
The two failures in the blocking bugs right now seem to each be confined to specific directories, so we could just disable those for Windows e10s debug runs, to get the rest of the tests going.
(In reply to Pulsebot from comment #16)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/e51048013b92

In the future, it would be good to get some kind of rubber stamp review from somebody responsible for the relevant code when you mass disable tests, so that people working in the area are aware their tests don't work. Thanks!
Blocks: 1245574
This is long done.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.