1235513 - Remove SelectionHandler.js and optional use of original Java selection carets

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Mark Capella [:capella]]

While m-c builds now default to the new AccessibleCaret selection handlers that core provides, mobile users can currently opt to revert to the original Java carets by setting |layout.accessiblecaret.enabled| to false.

We should remove that as an option, and it's attendant code, SelectionHandler.js.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

More code deletion, sign me up!

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb52b873826715b0fc92e4b88f44fbb9e1dd00c1

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Ship it.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1235513 - Remove the old Fennec SelectionHandler now that it has been replaced by the AccessibleCaret code in platform.

Review commit: https://reviewboard.mozilla.org/r/83904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83904/

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8798388 [details]
Bug 1235513 - Remove the old Fennec SelectionHandler now that it has been replaced by the AccessibleCaret code in platform.

https://reviewboard.mozilla.org/r/83904/#review82450

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00c81c0c177b
Remove the old Fennec SelectionHandler now that it has been replaced by the AccessibleCaret code in platform. r=snorp

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/00c81c0c177b