1237731 - Sync doesn't work and jumps back to welcome screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P1)

Description

[Mihai Barbat]

Hi

I am using a Flame phone running OTA 20160107030227 and when I try Firefox Sync after a few seconds it jumps back to the welcome screen and the sync is not done.

Please see the youtube link with the issue: https://www.youtube.com/watch?v=UKhgS73dqtc

Comment 1

[Mihai Barbat]

Attachment: 2016-01-10-21-14-40.zip

I have added an attachment with all the logs after the issue happens on my Flame

Comment 2

[Mihai Barbat]

Can any dev check the logs I attached? I tried Sync on an android phone and also on my desktop and it works. It has this behaviour only on the Flame!

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

This is a known issue already solved in master. Unfortunately the OTA 20160107030227 does not contain many Sync related fixes including this one, so you'll have to wait for the next OTA. Sorry for the inconveniences.

Comment 4

[Mihai Barbat]

I have the recent V5 Gonk layer running OTA 20160114150226 and still have the issue. Is the fix still not in this one?

Comment 5

[Michiel de Jong [:michielbdejong]]

Hi Mihai,

(In reply to Mihai Barbat from comment #4)
> I have the recent V5 Gonk layer running OTA 20160114150226 and still have
> the issue. Is the fix still not in this one?

In Settings -> Device Information -> More Information -> Git Commit Info, what data/time and commit hash do you see?

Comment 6

[Mihai Barbat]

(In reply to Michiel de Jong [:michielbdejong] from comment #5)
> Hi Mihai,
> 
> (In reply to Mihai Barbat from comment #4)
> > I have the recent V5 Gonk layer running OTA 20160114150226 and still have
> > the issue. Is the fix still not in this one?
> 
> In Settings -> Device Information -> More Information -> Git Commit Info,
> what data/time and commit hash do you see?

2016-01-14 03:25:40
2d6c11a1

Comment 7

[Mihai Barbat]

So I just tried it again with OTA 20160115030207 Git commit 2016-01-15 07:52:10 44cc5dfe and I have the same behaviour! This issue is definitely not solved!

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Could you try adding this setting via WebIDE, please?

'sync.collections.history.limit': '50'

Comment 9

[Mihai Barbat]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #8)
> Could you try adding this setting via WebIDE, please?
> 
> 'sync.collections.history.limit': '50'

Haha! It worked! :D thank you

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

That's because of bug 1223781 then :\ We need to reland that one or bump the DB version again before the next OTA.

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Gregor, I'm afraid that I don't have much time to spend investigating the emulator tests failures from bug 1223781, so until I am able to reland that patch we need to bump the DB version again.

Comment 12

[Mihai Barbat]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #8)
> Could you try adding this setting via WebIDE, please?
> 
> 'sync.collections.history.limit': '50'

what is the max value of this limit?

Comment 13

[Fernando Jiménez Moreno [:ferjm]]

For now, 50 is all that you need. On the phone we only show 50 entries in the browser history and we don't query the synced data from the awesomebar (bug 1231933).

We are in the process of removing these limitations at bug 1232276.

Comment 14

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d51e6f478f9cbaecdf9c1149eb0ba3b4b0728c10
Bug 1237731 - Sync doesn't work and jumps back to welcome screen. r=gwagner

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d51e6f478f9c

Comment 16

[Fernando Jiménez Moreno [:ferjm]]

[Blocking Requested - why for this release]: According to [1] the TV is shipping with a 2.1 version and then updating to 2.5 via OTA. If that is the case, we need this uplifted to 2.5 so all the setting changes are applied.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1239546#c16

Comment 17

[Maria Angeles Oteo (:oteo)]

Setting ni to Josh due to Fernando 2.5 uplift request in comment 16

Comment 18

[Josh Cheng [:josh]]

Hi Fernando,
Please raise 2.5 Uplift request. Thanks!

Comment 19

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8708492 [details] [diff] [review]
v1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): The Settings API does not apply settings.json changes on OTAs unless the DB version is bump manually.
[User impact] if declined: The user won't be able to use Sync.
[Testing completed]: Local testing.
[Risk to taking this patch] (and alternatives if risky): Low risk. We are just bumping the Settings DB version.
[String changes made]: None

Comment 20

[Josh Cheng [:josh]]

Comment on attachment 8708492 [details] [diff] [review]
v1

Approve for Tv 2.5

Comment 21

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d911ee3b695c