Closed Bug 1240836 Opened 6 years ago Closed 4 years ago
Add worker threads to gecko profiler
If we have the worker names from bug 1240835, and notifications when a new worker thread is created, if we had the ability to add threads to profile when the profiler is already recording, we wouldn't need to stop/start and add a new thread to watch, which would mean losing a non-negligible chunk of samples.  https://github.com/mozilla/gecko-dev/blob/ed88e1670ccd2f123c744792ece9bf6961455e74/devtools/server/performance/profiler.js#L37
Has there been any progress here? This seems to be one of the most important bugs to fix for worker profiling.
Priority: -- → P1
Via bug 1132525, apparently this should "just work", but that sounds too good to be true.
Summary: Add threads to profile while Gecko Profiler is already running → Add worker threads to gecko profiler
After trying out the profiler with "DOM" as a thread name, I wasn't able to get any new threads in the returned profile. In e10s, the profiler runs in the content process, and does not get any new threads (trying on http://html5demos.com/worker) -- is there anything I'm missing?
ni? for the above question
All I did was give you the answer that BenWa gave me (assuming I didn't misinterpret what he said). I don't actually know anything about how the profiler is implemented, so this question is probably best left to him.
I'd suggest trying with something like 'GeckoMain,Compositor,DOM' so you don't get empty threads. I can't get this to work either. I'm not overly surprised TBH since no one was using this feature.
Filed bug 1248640
Was this fixed by bug 1297773?
This is not relevant anymore for the upcoming recording panel work.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.