Closed Bug 1243089 Opened 4 years ago Closed 4 years ago

Remove provisional Desktop identity UI for website sign-in with BrowserID (SignInToWebsite)

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

(Whiteboard: [killthem])

Attachments

(1 file)

I got approval last year to remove this provisional UI on mozilla.dev.identity and since then Persona announced its shutdown later this year.

This only removes the code in browser/ since the dom/toolkit code is trickier since B2G uses some of it. I'll file a separate bug to remove unused code there.
Duplicate of this bug: 1063404
Duplicate of this bug: 1147060
Comment on attachment 8712328 [details]
MozReview Request: Bug 1243089 - Remove provisional Desktop identity UI for website sign-in with BrowserID (SignInToWebsite). r=felipe

https://reviewboard.mozilla.org/r/32507/#review29797

yay, code removal!

::: browser/base/content/urlbarBindings.xml
(Diff revision 1)
> -            <xul:label class="text-link custom-link small-margin" anonid="chooseemail" hidden="true"/>

digging the history, `small-margin` looks like something from a distant past, but it looks like it's not used by anything else. Should we remove it?
Attachment #8712328 - Flags: review?(felipc) → review+
https://reviewboard.mozilla.org/r/32507/#review29797

> digging the history, `small-margin` looks like something from a distant past, but it looks like it's not used by anything else. Should we remove it?

No, comm-central uses it: https://mxr.mozilla.org/comm-central/search?string=small-margin
https://hg.mozilla.org/mozilla-central/rev/6d05298779b2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.