1244284 - Drag events don't get untransformed by the resolution, if there is one

Status: RESOLVED DUPLICATE of bug 1556556

(Core :: Panning and Zooming, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1242690 +++

This is a follow-up for bug 1242690. There are still cases where having a resolution on desktop results in weird effects, presumably from input events not getting the callback transform applied properly. One example is with dragging text as described at https://bugzilla.mozilla.org/show_bug.cgi?id=1242690#c7

Comment 1

[Josh Cheng [:josh]]

Hi :kats,
Thanks for helping this issue. 
As it's approaching code complete for Panasonic 2016 model TV.
Do you mind estimate how long would you able to fix it? 
Thank you!

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I'm not sure. Bug 1242690 had to be backed out because it caused regressions on desktop, I'm trying to figure that out and get it relanded. Unfortunately I don't have an ETA - when is the code complete date?

Comment 3

[Josh Cheng [:josh]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> I'm not sure. Bug 1242690 had to be backed out because it caused regressions
> on desktop, I'm trying to figure that out and get it relanded. Unfortunately
> I don't have an ETA - when is the code complete date?

We already passed CC date. However partner still like to see whether we can fix this before their shipment date which is around end of March.
Thanks

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Ok, thanks. It's possible (but no guarantees) that we'll get this landed before the end of March but it is still a risky change so if possible I would look for other options as well.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

We can probably land bug 1242690 behind an #ifdef for the TV platform, because the TV platform shouldn't be affected by the scrollbar-dragging issue. That will let us continue and work on this bug (again #ifdef'd for the TV platform). Can you tell me what #ifdef I can use to isolate the TV platform? MOZ_WIDGET_GONK doesn't work for that, as we discussed previously.

Comment 6

[Kilik Kuo [:kikuo] (inactive)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> We can probably land bug 1242690 behind an #ifdef for the TV platform,
> because the TV platform shouldn't be affected by the scrollbar-dragging

On partner's TV, they're using classic scrollbar by cursor-mode operation, so it seems not a good idea to exclude TV here.

> issue. That will let us continue and work on this bug (again #ifdef'd for
> the TV platform). Can you tell me what #ifdef I can use to isolate the TV
> platform? MOZ_WIDGET_GONK doesn't work for that, as we discussed previously.

Currently there's no #ifdef for TV platform, there were serverl discussion about this but no conclusion yet. Because now there seems still no specific TV functionality requiring such a #ifdef, and there's still unclear to treat TV as a specific platform for FxOS. (Although partner has its own #ifdef to distinguish the code for their specific platform capability)

Though

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Ok so then it sounds like there isn't much we can do except try to fix the bug. Unfortunately we have limited resources here so it's unclear if we'll get to the bottom of it soon. Randall is working on the problem in bug 1242690.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

My understanding is that we don't actually need this for the TV work since the interface doesn't allow dragging text around, only dragging the scrollbar. Quote from an email thread:

"In short, scrollbar dragging & hit-testing on mouse move/hover are important for TV.
The misplaced text pop-up effect is not, because currently it's forbidden on Pana's TV to select text."

We'll still want this for desktop zooming, but it's not a priority.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Bumping based on comment 8.

Comment 10

[Botond Ballo [:botond]]

I can't tell what the exact STR is here. The bug description points to bug 1242690 comment 7, which points to a Google Drive video, which has since been taken down.

Based on the bug title, I would expect the bug to be fixed by bug 1556556, and based on some brief testing, dragging text and hover effects seem to be working fine, including when zoomed in, so I'm going to close this.

Comment 11

[Botond Ballo [:botond]]

(Bug 1254030 comment 1 suggests this is also about drag previews, which also seem to be working fine.)