[ja, ja-JP-mac] Update icon for Google searchplugin on desktop

RESOLVED FIXED

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: flod, Assigned: marsf)

Tracking

unspecified

Firefox Tracking Flags

(firefox44 wontfix, firefox45 fixed, firefox46 fixed)

Details

(Whiteboard: webdashboard)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
The icon was updated for en-US in bug 1201770, Japanese needs to update its icon on desktop (Fennec uses the same .xml file as en-US).

More in general: what is blocking us from using the en-US searchplugin also on desktop?
(Reporter)

Updated

3 years ago
Whiteboard: webdashboard
(Assignee)

Comment 1

3 years ago
I was watching bug 1200726, and didn't notified update progress.
I'll take it, thanks.

(In reply to Francesco Lodolo [:flod] from comment #0)
> More in general: what is blocking us from using the en-US searchplugin also
> on desktop?

The official url of Google in Japan is "google.co.jp", not "google.com".
Assignee: nobody → chimantaea_mirabilis
(Reporter)

Comment 2

3 years ago
(In reply to Masahiko Imanaka [:marsf] from comment #1)
> The official url of Google in Japan is "google.co.jp", not "google.com".

It's google.it for Italy (or google.fr, google.de, etc.), but that doesn't stop the en-US searchplugin from working.
(Assignee)

Comment 3

3 years ago
At this moment, google.com works on desktop in Japan, and we have no affiliate code for google.co.jp.

Asai-san, how do you think about keeping the "google.co.jp" searchplugin on desktop?
Can we remove it (google-jp.xml) and using the en-US searchplugin for ja locales?
Flags: needinfo?(bugzilla)
(In reply to Masahiko Imanaka [:marsf] from comment #3)
> At this moment, google.com works on desktop in Japan, and we have no
> affiliate code for google.co.jp.
> 
> Asai-san, how do you think about keeping the "google.co.jp" searchplugin on
> desktop?
> Can we remove it (google-jp.xml) and using the en-US searchplugin for ja
> locales?

google.co.jp and google.com are different.  After searching a word via .com searchplugin, we will hit several UX issues (ex. bug 1217296).  So I don't think that we can remove it.
(Reporter)

Comment 5

3 years ago
(In reply to Makoto Kato [:m_kato] from comment #4)
> google.co.jp and google.com are different.  After searching a word via .com
> searchplugin, we will hit several UX issues (ex. bug 1217296).  So I don't
> think that we can remove it.

That would definitely be a good reason. Having said that, bug 1217296 seems to be a problem with the language setting on Google, not the domain itself.

If I open a Private window and browse to google.co.jp, I would still get Italian as language because of my accept-languages header, even if the banner and domain say Google Japan. It's relatively easy to create a searchplugin for google.com (harder to install it) and check if everything works on your side.
(Assignee)

Comment 6

3 years ago
This can be applied to both ja and ja-JP-mac.
We want to commit to Firefox 45.0 beta, too.
Attachment #8716749 - Flags: review?(francesco.lodolo)
(Reporter)

Comment 7

3 years ago
Comment on attachment 8716749 [details] [diff] [review]
update google search engine icon

Review of attachment 8716749 [details] [diff] [review]:
-----------------------------------------------------------------

Please use the same the same icon en-US is using (16+32px .ico). 
http://hg.mozilla.org/mozilla-central/file/tip/browser/locales/en-US/searchplugins/google.xml#l9

The one you used as the one for Fennec (96px, rounded corners).

Note: since you're touching searchplugins, you might want to fix also bug 1244419 (that doesn't require review).
Attachment #8716749 - Flags: review?(francesco.lodolo) → review-
(Assignee)

Comment 8

3 years ago
Oops, this is same with en-US.
Attachment #8716749 - Attachment is obsolete: true
Attachment #8716757 - Flags: review?(francesco.lodolo)
(Reporter)

Comment 9

3 years ago
Comment on attachment 8716757 [details] [diff] [review]
update google search engine icon for /browser

Review of attachment 8716757 [details] [diff] [review]:
-----------------------------------------------------------------

This one looks good, thanks.

I'd be still interested in finding out about dropping the searchplugin entirely. Maybe split into a new bug for discussion and let this one be closed?
Attachment #8716757 - Flags: review?(francesco.lodolo) → review+
(Assignee)

Comment 11

3 years ago
(In reply to Francesco Lodolo [:flod] from comment #7)
> Note: since you're touching searchplugins, you might want to fix also bug
> 1244419 (that doesn't require review).

OK, I will fix it tommorow or later.


(In reply to Francesco Lodolo [:flod] from comment #9)
> I'd be still interested in finding out about dropping the searchplugin
> entirely. Maybe split into a new bug for discussion and let this one be
> closed?

Yes, please.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(bugzilla)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.