1244506 - [ja, ja-JP-mac] Update icon for Google searchplugin on desktop

Status: RESOLVED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[Francesco Lodolo [:flod]]

The icon was updated for en-US in bug 1201770, Japanese needs to update its icon on desktop (Fennec uses the same .xml file as en-US).

More in general: what is blocking us from using the en-US searchplugin also on desktop?

Comment 1

[Masahiko Imanaka [:marsf]]

I was watching bug 1200726, and didn't notified update progress.
I'll take it, thanks.

(In reply to Francesco Lodolo [:flod] from comment #0)
> More in general: what is blocking us from using the en-US searchplugin also
> on desktop?

The official url of Google in Japan is "google.co.jp", not "google.com".

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Masahiko Imanaka [:marsf] from comment #1)
> The official url of Google in Japan is "google.co.jp", not "google.com".

It's google.it for Italy (or google.fr, google.de, etc.), but that doesn't stop the en-US searchplugin from working.

Comment 3

[Masahiko Imanaka [:marsf]]

At this moment, google.com works on desktop in Japan, and we have no affiliate code for google.co.jp.

Asai-san, how do you think about keeping the "google.co.jp" searchplugin on desktop?
Can we remove it (google-jp.xml) and using the en-US searchplugin for ja locales?

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Masahiko Imanaka [:marsf] from comment #3)
> At this moment, google.com works on desktop in Japan, and we have no
> affiliate code for google.co.jp.
> 
> Asai-san, how do you think about keeping the "google.co.jp" searchplugin on
> desktop?
> Can we remove it (google-jp.xml) and using the en-US searchplugin for ja
> locales?

google.co.jp and google.com are different.  After searching a word via .com searchplugin, we will hit several UX issues (ex. bug 1217296).  So I don't think that we can remove it.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Makoto Kato [:m_kato] from comment #4)
> google.co.jp and google.com are different.  After searching a word via .com
> searchplugin, we will hit several UX issues (ex. bug 1217296).  So I don't
> think that we can remove it.

That would definitely be a good reason. Having said that, bug 1217296 seems to be a problem with the language setting on Google, not the domain itself.

If I open a Private window and browse to google.co.jp, I would still get Italian as language because of my accept-languages header, even if the banner and domain say Google Japan. It's relatively easy to create a searchplugin for google.com (harder to install it) and check if everything works on your side.

Comment 6

[Masahiko Imanaka [:marsf]]

Attachment: update google search engine icon

This can be applied to both ja and ja-JP-mac.
We want to commit to Firefox 45.0 beta, too.

Comment 7

[Francesco Lodolo [:flod]]

Comment on attachment 8716749 [details] [diff] [review]
update google search engine icon

Review of attachment 8716749 [details] [diff] [review]:
-----------------------------------------------------------------

Please use the same the same icon en-US is using (16+32px .ico). 
http://hg.mozilla.org/mozilla-central/file/tip/browser/locales/en-US/searchplugins/google.xml#l9

The one you used as the one for Fennec (96px, rounded corners).

Note: since you're touching searchplugins, you might want to fix also bug 1244419 (that doesn't require review).

Comment 8

[Masahiko Imanaka [:marsf]]

Attachment: update google search engine icon for /browser

Oops, this is same with en-US.

Comment 9

[Francesco Lodolo [:flod]]

Comment on attachment 8716757 [details] [diff] [review]
update google search engine icon for /browser

Review of attachment 8716757 [details] [diff] [review]:
-----------------------------------------------------------------

This one looks good, thanks.

I'd be still interested in finding out about dropping the searchplugin entirely. Maybe split into a new bug for discussion and let this one be closed?

Comment 10

[Masahiko Imanaka [:marsf]]

aurora:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/c8b5f385ab22
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/5a743dc7077a

beta:
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/aeb5953f175f
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja-JP-mac/rev/26054ec002f1

Comment 11

[Masahiko Imanaka [:marsf]]

(In reply to Francesco Lodolo [:flod] from comment #7)
> Note: since you're touching searchplugins, you might want to fix also bug
> 1244419 (that doesn't require review).

OK, I will fix it tommorow or later.


(In reply to Francesco Lodolo [:flod] from comment #9)
> I'd be still interested in finding out about dropping the searchplugin
> entirely. Maybe split into a new bug for discussion and let this one be
> closed?

Yes, please.