Closed
Bug 1256313
Opened 8 years ago
Closed 8 years ago
[e10s] <select> preserves active state when I release mouse over the list of options
Categories
(Core :: Layout: Form Controls, defect, P1)
Core
Layout: Form Controls
Tracking
()
VERIFIED
FIXED
mozilla50
People
(Reporter: arni2033, Assigned: enndeakin)
References
(Blocks 1 open bug)
Details
(Whiteboard: e10st?)
Attachments
(2 files)
testcase 1 - [e10s] select preserves active state when I release mouse over the list of options.html
1.42 KB,
text/html
|
Details | |
1.78 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
>>> My Info: Win7_64, Nightly 48, 32bit, ID 20160313030418. DEFAULT THEME STR (A),(B): 1. Open attached "testcase 1" 2. Hover mouse over the <select>'s dropmarker, hold left mouse button [drop-down list will open] 3.A) Hover mouse over any visible option 3.B) Hover mouse over option the upper scroll button in scrollbar 4. Release left mouse button 5. Move mouse to urlbar and click in urlbar STR (C),(D): 1. Open attached "testcase 1" 2. Click the <select>'s dropmarker [drop-down list will open] 3.C) Hover mouse over any visible option. Click left mouse button. 3.D) Hover mouse over option the upper scroll button in scrollbar. 4. Do nothing 5. Move mouse to urlbar and click in urlbar AR: (A,B) Select has :active pseudoclass (C,D) Select doesn't have :active pseudoclass ER: Scenarios (A) and (C) should result in the same dropmarker state (e.g. not :active) Scenarios (B) and (D) should result in the same dropmarker state (e.g. not :active) Note: I filed this bug separately from bug 1253979 just in case, because in bug 1253977 it became obvious that appearance of <select> may have nothing in common with pseudoclasses
Comment hidden (spam) |
Updated•8 years ago
|
Blocks: e10s-select
Updated•8 years ago
|
Flags: needinfo?(jgriffiths)
Comment 2•8 years ago
|
||
Jim: this is not great but I think it's polish. Setting P1, can you set to '+'? I don't have permissions to set '+'.
Flags: needinfo?(jgriffiths) → needinfo?(jmathies)
Updated•8 years ago
|
Updated•8 years ago
|
Whiteboard: e10st?
Assignee | ||
Comment 3•8 years ago
|
||
This patch clears the active state of the select on mouseup, and does so just after the mouseup event fires. This seems to work ok. There is an obscure edgecase not fixed which I don't think really matters: Click and hold then keydown and press enter (that is select an item with the keyboard while holding the mouse). The active state will clear on popup close rather than mouseup.
Comment 4•8 years ago
|
||
Comment on attachment 8772110 [details] [diff] [review] Clear the active state on mouseup Review of attachment 8772110 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8772110 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac078f039076
Assignee | ||
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b41ba5363c60
Assignee | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=19d91134271f
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b361e455e6ab4c37c9368d5b9c914b22997efb7 Bug 1256313, clear active state on select button when releasing the mouse in e10s, r=mconley
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9b361e455e6a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•8 years ago
|
Flags: qe-verify+
Comment 10•8 years ago
|
||
(In reply to arni2033 from comment #0) > STR (A),(B): > 1. Open attached "testcase 1" > 2. Hover mouse over the <select>'s dropmarker, hold left mouse button > [drop-down list will open] > 3.A) Hover mouse over any visible option > 3.B) Hover mouse over option the upper scroll button in scrollbar > 4. Release left mouse button > 5. Move mouse to urlbar and click in urlbar This is still reproducible if I release the left mouse button over the scrollbar. Fx 50b11, Win 7 x64
Flags: needinfo?(enndeakin)
Comment 12•8 years ago
|
||
Marking this as verified fixed on Fx 50b11 considering the follow-up bug 1314647.
You need to log in
before you can comment on or make changes to this bug.
Description
•