Closed
Bug 1257035
Opened 9 years ago
Closed 8 years ago
Intermittent beta test_set_window_size.py TestSetWindowSize.test_that_we_can_maximise_the_window | TimeoutException: wait_for_condition timed out
Categories
(Testing :: Marionette Client and Harness, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: KWierso, Unassigned)
References
Details
(Keywords: intermittent-failure)
Comment 1•9 years ago
|
||
RE this bug's initial classification as "Core|Layout" -- I don't see any reason to suspect that this is a Layout bug. Seems much more likely that this is a bug in the harness, or in the OS (or some random blip on the particular system where this failed, with the OS blocking window-maximization temporarily for whatever reason).
Anyway -- for reference, the failing "wait_for_condition" seems to be here:
> 57 def test_that_we_can_maximise_the_window(self):
> [...]
> 70 self.marionette.maximize_window()
> 71 self.wait_for_condition(lambda m: m.execute_script("return window.wrappedJSObject.rcvd_event;"))
http://mxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette/tests/unit/test_set_window_size.py#57
This test code was all added by automatedtester (dburns), in bug 1069572, which is where the maximize_window() API that's being invoked here was added too.
He's probably the most likely to have some idea about what might be going wrong here...
I'm reclassifying this bug as Testing|Marionette (since that's the categorization of the bug that added this maximize_window API), and I'm tagging dburns for needinfo.
I also feel that the API is wrong. As of now we move the window to (0,0) and resize it to the screen width and height.
https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver.js#2680
Instead `window.maximize()` should be called so that a following `window.restore()` can restore the previous window constraints. By first moving and than resizing the window we will loose those.
Comment hidden (Intermittent Failures Robot) |
Comment 4•9 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #2)
> I also feel that the API is wrong. As of now we move the window to (0,0) and
> resize it to the screen width and height.
>
> https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver.
> js#2680
>
> Instead `window.maximize()` should be called so that a following
> `window.restore()` can restore the previous window constraints. By first
> moving and than resizing the window we will loose those.
feel free to raise a bug accordingly. That will not be fixed on an intermittent.
Flags: needinfo?(dburns)
Done as bug 1258316.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Summary: Intermittent beta test_set_window_size.py TestSetWindowSize.test_that_we_can_maximise_the_window | TimeoutException: TimeoutException: wait_for_condition timed out → Intermittent beta test_set_window_size.py TestSetWindowSize.test_that_we_can_maximise_the_window | TimeoutException: wait_for_condition timed out
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 26•8 years ago
|
||
Closing as intermittent has not been seen in last 45 days
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Updated•2 years ago
|
Product: Testing → Remote Protocol
Comment 27•2 years ago
|
||
Moving bug to Testing::Marionette Client and Harness component per bug 1815831.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•