1263776 - createPattern with 'no-repeat' bleeds color from edges of pattern image

Status: NEW

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Yury Delendik (:yury)]

Attachment: test_pat.html

When fill() is used with pattern that was created with 'no-repeat' parameter, the 2d context paints the pattern once and the rest of the area is filled with color of the pixel from the pattern edge that is closest to the pixel that is being painted (a la GL_CLAMP_TO_EDGE). It is expected only image of the pattern is painted.

Comment 1

[Yury Delendik (:yury)]

Attachment: Comparison of FF, Chrome, Safari and IE9

Comment 2

[Matt Woodrow (:mattwoodrow)]

Looking at the spec, it appears that no-repeat really does expect EXTEND_NONE behaviour, not clamping.

Our CanvasGeneralPattern::ForStyle() code uses ExtendMode::CLAMP for this case (since we don't support NONE in Moz2D).

CC'ing graphics people who might want to fix this :)

Comment 4

[andreabogazzi79]

Would be cool if someone could fix this one day.
Any chance?
If is a cairo based render i could also give a shot.

Comment 5

[andreabogazzi79]

http://jsfiddle.net/emeagcnx/17/

This is an old javascript only reproducible case

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Chrome uses the Decal tile mode now:
https://chromium.googlesource.com/chromium/src/+/89d63e3a995cf

And here's what Safari does https://github.com/WebKit/webkit/blob/10627ba484528fed3e7358b1801250bb004c8a99/Source/WebCore/platform/graphics/cg/PatternCG.cpp#L60

I wonder what Edge does.

Comment 7

[andreabogazzi79]

Nodecanvas, a cairo based implementation of canvas under node uses a cairo native constant to define the no repat and does not bleed.

Comment 8

[andreabogazzi79]

I wish an happy new year to all firefox devs here, but a special happy new year to the one that will eventually fix this bug.
Continue the great job!

Comment 10

[andreabogazzi79]

Any chance someone will fix it?

Comment 11

[Andrey Bienkowski]

https://bugzilla.mozilla.org/show_bug.cgi?id=1548706

Comment 12

[1663998104]

Is it still being repaired?